right-* messages contain wikitext but User::getRightDescription() returns them as plaintext
Closed, ResolvedPublicBUG REPORT
Actions

Description

right-* messages (human-readable definitions of user rights) might contain wikitext (specifically, the change-tag-related ones do), but User::getRightDescription() uses Message::text() to render them. This is not an issue for Special:ListGrants, Special:ListGroupRights and Special:GlobalGroupPermissions which use the method output as parameter for the listgrouprights-right-display message and then parse that message; but other interfaces such as Special:BotPasswords and the OAuth consumer registration form end up showing raw wikitext.

Details

	Subject	Repo	Branch	Lines +/-
	Split User::getRightDescription into two methods	mediawiki/core	master	+31 -2

Customize query in gerrit

Event Timeline

Tgr created this task.Jul 12 2022, 12:19 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2022, 12:19 AM

Tgr triaged this task as Low priority.Jul 12 2022, 12:19 AM

Tgr added a project: good first task.

Winston_Sung moved this task from Untriaged to Translation difficulties on the I18n board.Aug 9 2023, 1:30 PM

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptAug 9 2023, 1:30 PM

Krinkle edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team.Aug 10 2023, 10:25 PM

Krinkle edited projects, added MediaWiki-Platform-Team; removed MediaWiki-Platform-Team (Radar).

larissagaulia added a project: MediaWiki-Engineering-Group-onboarding.Aug 22 2023, 10:30 AM

larissagaulia moved this task from Inbox, needs triage to Within 2 Qs on the MediaWiki-Platform-Team board.

FJoseph-WMF added a project: MediaWiki CodeJam Dec 2023.Dec 5 2023, 2:18 PM

FJoseph-WMF moved this task from Incoming to Good First Tasks on the MediaWiki CodeJam Dec 2023 board.Dec 5 2023, 8:34 PM

Perhaps it makes sense to use Message::parse() in directly in User::getRightDescription(). It could be redundant for Special:ListGrants et al. since there is also some parsing happening there but at least it would prevent wikitext from being displayed as raw text. I'll submit a patch in line with this.

sguebo_WMF claimed this task.Dec 7 2023, 8:14 AM

Change 981176 had a related patch set uploaded (by African Hope; author: African Hope):

[mediawiki/core@master] Adjust User::getRightDescription to return parsed text

https://gerrit.wikimedia.org/r/981176

gerritbot added a project: Patch-For-Review.Dec 7 2023, 8:23 AM

Change 981176 merged by jenkins-bot:

[mediawiki/core@master] Split User::getRightDescription into two methods

https://gerrit.wikimedia.org/r/981176

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Jan 31 2024, 9:00 PM

sguebo_WMF closed this task as Resolved.Feb 1 2024, 5:18 AM

sguebo_WMF removed a project: Patch-For-Review.