Page MenuHomePhabricator

The transcode status table is added regardless of whether or not you have a transcoder installed
Closed, ResolvedPublic

Description

I get this table, but i have no intention of ever installing transcoding on my local machine. We might want to hide it, when it isn't actually doing anything.


Version: unspecified
Severity: normal

Details

Reference
bz29291

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:27 PM
bzimport set Reference to bz29291.
TheDJ created this task.Jun 6 2011, 8:31 PM

mdale wrote:

So hide the transcode status table on shared repo assets? and or add a local configuration variable that lets you disable transcoding all together so we don't add the transcode jobs and we don't check the transcode table when rendering sources.

I guess we should do both. ( done in r89609 )

TheDJ added a comment.Jun 6 2011, 11:01 PM

Almost...

See attachment for remote file.

TheDJ added a comment.Jun 6 2011, 11:02 PM

Created attachment 8629
screenshot of instantcommons video file.

Attached:

TheDJ added a comment.Jun 6 2011, 11:03 PM

and:

Notice: Undefined index: Folgers.ogv in /Users/hartman/Development/wiki-extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscode.php on line 390

Warning: Invalid argument supplied for foreach() in /Users/hartman/Development/wiki-extensions/TimedMediaHandler/TranscodeStatusTable.php on line 44

mdale wrote:

hmm did you svn update and action=purge the page?

For example the "Notice: Undefined index:" seems like it would not occur if we set self::$transcodeState[ $fileName ] = array(); right above that line. see @@ -370,6 +372,8 @@ in r89609

mdale wrote:

In chatting with Derk-Jan Hartman over IRC this fixed for him now.

There was some concern about the database tables being around even if transcoding is off, but its not easy to support switching the transcode option on and off if we remove these tables, so we will leave them in there. If transcoding is off no transcodes take place and no files pages will show the transcode table.