Page MenuHomePhabricator

Review and deploy TimedMediaHandler extension (timed media handler) to Wikimedia wikis
Closed, ResolvedPublic

Description

Author: mdale

Description:
A tracking bug to tag trunk dependency bugs. Timed media handler still needs to be reviewed, refined, some resource loader patches remain to be written, etc.

A live prototype install is available at:
http://prototype.wikimedia.org/timedmedia/Main_Page

That prototype page will reflect the most recent version of the extension.

I include an initial patch to trunk on this bug so people can get TMH running locally.


Version: unspecified
Severity: enhancement
URL: http://prototype.wikimedia.org/timedmedia/Main_Page

Details

Reference
bz27699

Related Objects

StatusAssignedTask
ResolvedNone
ResolvedNone
Declinedbrion
ResolvedNone
Declinedbrion
DeclinedNone
ResolvedNone
DeclinedNone
OpenNone
ResolvedTheDJ
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
Resolvedhashar
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz27699.
bzimport created this task.Feb 25 2011, 4:21 AM

mdale wrote:

*** Bug 23888 has been marked as a duplicate of this bug. ***

Where's the patch ?

mdale wrote:

Krinkle its an extension not a patch.

I am presently working through the first review pass by Roan here: http://www.mediawiki.org/wiki/User:Catrope/Extension_review/TimedMediaHandler

(In reply to comment #3)

(In reply to comment #2)

Where's the patch ?

Krinkle its an extension not a patch.

I am presently working through the first review pass by Roan here:
http://www.mediawiki.org/wiki/User:Catrope/Extension_review/TimedMediaHandler

That much I know, I was referring to this "patch":

I include an initial patch to trunk on this bug so people
can get TMH running locally.

Or is that no longer needed and part of the extension ?

mdale wrote:

(In reply to comment #4)

Or is that no longer needed and part of the extension ?

Yes the associated dependent patches ( 27336, 27641 ) have been applied to trunk

Added the raw extension name to bug title so it's easier to find. :)

Changing to Wikimedia.

mdale wrote:

Brion did you get a chance to review the associated closed bugs that you reported? Feel free to re-open anything that is still not resolved.

  • Bug 7433 has been marked as a duplicate of this bug. ***

What's the status of this bug?

(In reply to comment #10)

What's the status of this bug?

This is a normal prodedure in Wikimedia... just do nothing... over years.

sumanah wrote:

Argh, sorry I missed the "what's the status of this bug?" question a few weeks ago

TMH has been reviewed by Ian Baker and NeilK extensively, with lots of changes made by Michael Dale. Review notes and Michael's follow-up at https://www.mediawiki.org/wiki/TimedMediaHandler/ReviewNotes . It's currently being tested by Chris McMahon and was also tested partially by Tauhida Parveen, including transcoding support, at http://commons.wikimedia.beta.wmflabs.org/wiki/File:Electric_sheep.webm . Progress on deploying TMH is dependent on robustness of Wikimedia Labs; Labs as a robust environment, suitable for testing, is improving as Antoine Musso works on it.

CC'ing Chris and Antoine so they can possibly give further updates.

sumanah wrote:

Jan Gerber is currently working on TMH and we should have more news next week.

sumanah wrote:

Update from Chris McMahon: http://www.gossamer-threads.com/lists/wiki/wikitech/289186 "First, the TimedMediaHandler extension that we've been testing in the beta commons wiki for quite some time has moved off of the the beta cluster and is now being installed on test2wiki in preparation for a production deployment."

https://test2.wikipedia.org/wiki/Special:Version - yes, TMH is installed there. :-) https://www.mediawiki.org/wiki/Extension:TimedMediaHandler/TestPlan is the test plan so you can help by using those ideas to try to break it. :-)

So this bug will be fixed soon? All dependencies have been cleared so far...

sumanah wrote:

Asking Chris Steipp to mark any outstanding (or fixed) blocker issues.

Sorry for the slow response. My concerns were:

  • Someone needs to make sure the 3rd party pieces are updated-- Michael Dale indicated he would do that
  • It would be good to deploy apparmor confining for the transcoders. I'll add a bug for that, but not a blocker, since we don't confine any of our media processing currently.
  • Jan addressed my concerns about iframing, so it's no longer an issue.

sumanah wrote:

Assigning to Michael Dale since it sounds like he's in charge of the only blocker (making sure that the 3rd party pieces are updated). Thanks.

Oh, and just to clarify: Michael updated everything in July, and said he would take on making sure they stay up to date. So, if the upstreams haven't been updated since July, then I think we're ready to go. Maybe Michael can confirm?

mdale wrote:

We are in sync with:

  • Kaltura HTML 1.7 -- latest major release
  • getid3: We are running version 1.9.3-20111213 which is the latest release: http://www.getid3.org/

(In reply to comment #20)

We are in sync with:

  • Kaltura HTML 1.7 -- latest major release
  • getid3: We are running version 1.9.3-20111213 which is the latest release: http://www.getid3.org/

Great, I think it's ready to deploy then

mdale wrote:

Its running on test2: http://test2.wikipedia.org/wiki/Special:Version

Been attempting to follow up with other folks per some minor updates, image scallers and the next wiki to deploy it on.

Okay, now that test2.wikipedia.org is live, can we add mediawiki.org and test.wikipedia.org? These wikis are the usual guinea pigs (cf. https://www.mediawiki.org/wiki/MediaWiki_1.21/Roadmap#Schedule_for_the_deployments).

Yes yes yes! Looks like this did get deployed to test.wikipedia.org (at least, I assume so because .webm and the Kaltura player are working).

Once 1.21wmf2 deploys on production wikis, does that mean .webm will be allowed on Commons and through the UploadWizard? Is there any sort of fanfare planned, like a blog post, or some documentation on best practices for videos now that we can do webm and (I'm assuming) closed captioning will be working again?

No, it's only enabled on testwiki and test2wiki currently. It's not connected to the version of MediaWiki deployed on the site. 1.21wmf2 is already deployed on all non-wikipedia sites.

Okay, so what's the deployment plan for this? Is there anything stopping this from moving to production sites?

@Michael Dale, I'm sure Guillaume and/or the communications team with preparing some fanfare. :)

jgerber wrote:

Currently one blocker is the transition of the imagescalers to precise, all required packages are in place but the update has not been done so far.

The other part, not blocking for enabling on more wikis, is transcoding, the videoscalers are in place but some changes need to be reviewed and merged before they can be used. (https://gerrit.wikimedia.org/r/#/c/28208/)

sumanah wrote:

Gerrit change 28208 has now been merged (thanks, Faidon!), so I believe the last blocker is the upgrade on the imagescalers to Precise Pangolin.

sumanah wrote:

The imagescaler OS upgrade is tracked in RT ticket 3210.

sumanah wrote:

Peter's email "[Wikitech-l] All wmf imagescalers now running ubuntu 12.04 precise" clears up that blocker: http://lists.wikimedia.org/pipermail/wikitech-l/2012-October/064019.html We'll watch the imagescalers for issues for probably the rest of this week before declaring that we can go forward with the TMH deployment.

Adding bug 41528 as a blocker, which looks like it was introduced as part of a fix to a different thumbnailing problem.

This seems deployed, am I missing something?

Snaevar removed a subscriber: Snaevar.Oct 12 2015, 9:40 PM