Page MenuHomePhabricator

WelcomeSurvey: Post-login redirect hooks might interfere with central login during signup
Closed, ResolvedPublicBUG REPORT

Description

GrowthExperiments redirects (most) users to Special:WelcomeSurvey after signup. CentralAuth redirects users to the central login wiki after login (also after the implicit login that happens during signup), to establish a central session. With the current implemntation, this two might conflict, and thus GrowthExperiments might interfere with central login (up until the user does a non-signup login, which would fix the central session).

We'll change the hooks used for redirection in GrowthExperiments.

Originally this was investigated in the context of T267273: [arwiki] Submitting a POST on a form redirected to immediately after account creation sometimes logs user out ; since this issue is about central login failures, not local ones, it cannot be the cause, but in theory the central session would be used automatically to recover a lost local session, so this issue might be a secondary cause of that bug by preventing the fallback mechanism from working. We won't know for sue until this change is in production, unfortunately.

Event Timeline

Tgr changed the task status from Open to In Progress.Jul 14 2022, 4:58 PM
Tgr assigned this task to kostajh.
Tgr triaged this task as High priority.
Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 751209 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] WelcomeSurvey/VariantHooks: Change hook used for redirection

https://gerrit.wikimedia.org/r/751209

Change 751209 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] WelcomeSurvey/VariantHooks: Change hook used for redirection

https://gerrit.wikimedia.org/r/751209

Change 822485 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.23] WelcomeSurvey/VariantHooks: Change hook used for redirection

https://gerrit.wikimedia.org/r/822485

Change 822485 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.23] WelcomeSurvey/VariantHooks: Change hook used for redirection

https://gerrit.wikimedia.org/r/822485

The patch is now deployed to production.

@Etonkovidova this affects the following code paths:

  • Going to the welcome survey after registration.
  • Jumping straight to the homepage after registration when the user is part of a campaign with the skipWelcomeSurvey tag.
  • The same for non-CentralAuth wikis.

There should be no functional change, beyond the page load after registration taking a little longer (as the CentralAuth login redirection is now working).

Probably the first path is the only one worth testing - campaigns see very little use, and we don't have non-CentralAuth wikis with welcome survey.

Mentioned in SAL (#wikimedia-operations) [2022-08-15T20:31:28Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.23/extensions/GrowthExperiments: Backport: [[gerrit:822485|WelcomeSurvey/VariantHooks: Change hook used for redirection (T313064)]] (duration: 04m 37s)

The patch is now deployed to production.

@Etonkovidova this affects the following code paths:

  • Going to the welcome survey after registration.
  • Jumping straight to the homepage after registration when the user is part of a campaign with the skipWelcomeSurvey tag.
  • The same for non-CentralAuth wikis.

There should be no functional change, beyond the page load after registration taking a little longer (as the CentralAuth login redirection is now working).

Probably the first path is the only one worth testing - campaigns see very little use, and we don't have non-CentralAuth wikis with welcome survey.

Thx, @Tgr!
Checked enwiki, ruwiki, and arwiki - no change in functionality (also I did not not observe the issue described in T267273).