Page MenuHomePhabricator

Most of the reply links don't work on ckbwiki
Closed, ResolvedPublic

Description

https://www.mediawiki.org/wiki/Topic:Wzfuy7th4xarw160

Hi, most of the reply links don't work on ckbwiki. For example, please go to this talk page and if you click/tap on the reply links, you see an error message, which contains these two messages (MediaWiki:Discussiontools-error-comment-disappeared and MediaWiki:Discussiontools-error-comment-disappeared-reload), saying that the statement could not be found, but the statements exist. Thanks!

Event Timeline

This is a very similar bug to T312828, similarly related to the changes from T304595, but the cause is different. MediaWiki overrides some of Moment's localisation code to format localized digits differently, and when Moment doesn't have a locale for a specific language, this override is applied to the English locale, which we rely on (after https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/813348) to format timestamps with non-localized digits.

The issue also affects some other less-visible features – for example, the date selectors on https://ckb.wikipedia.org/wiki/تایبەت:بەشدارییەکان (Special:Contributions) do not work.

Change 814361 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Ensure custom locales for Moment.js overrides, don't change 'en'

https://gerrit.wikimedia.org/r/814361

@matmarex Thank you so much for creating this task. You're right. A long time ago, I've noticed that the dates don't work on that special page you mentioned above, but I didn’t know what the problem was. It would be great if that could be fixed as well. Thanks!

Change 814361 merged by jenkins-bot:

[mediawiki/core@master] Ensure custom locales for Moment.js overrides, don't change 'en'

https://gerrit.wikimedia.org/r/814361

Change 814769 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@wmf/1.39.0-wmf.19] Ensure custom locales for Moment.js overrides, don't change 'en'

https://gerrit.wikimedia.org/r/814769

Change 814769 merged by jenkins-bot:

[mediawiki/core@wmf/1.39.0-wmf.19] Ensure custom locales for Moment.js overrides, don't change 'en'

https://gerrit.wikimedia.org/r/814769

Mentioned in SAL (#wikimedia-operations) [2022-07-18T20:13:20Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.19/resources/src/moment/moment-locale-overrides.js: rMWc4d8a217b4ce: Ensure custom locales for Moment.js overrides, dont change en (T313188) (duration: 02m 44s)

The fix is deployed now, the issue should no longer occur.