Page MenuHomePhabricator
Create Task
Maniphest T313209

SendNotificationsForUnillustratedWatchedTitles does not consider GlobalPreferences
Closed, ResolvedPublicBUG REPORT
Actions

Description

SendNotificationsForUnillustratedWatchedTitles.php (the script we're using to generate notifications for image suggestions on a weekly basis) executes a query to find eligible users. While that query looks at user preferences, it does not (and can not) consider global preferences, which live in a separate database.

Details

SubjectRepoBranchLines +/-
Use getOption to detect user preferencesmediawiki/extensions/ImageSuggestionswmf/1.39.0-wmf.19+40 -42
Use getOption to detect user preferencesmediawiki/extensions/ImageSuggestionsmaster+40 -42
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Jul 18 2022, 10:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2022, 10:04 AM
gerritbot added a comment.Jul 18 2022, 10:04 AM

Change 814737 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ImageSuggestions@master] Use getOption to detect user preferences

https://gerrit.wikimedia.org/r/814737

gerritbot added a project: Patch-For-Review.Jul 18 2022, 10:04 AM
matthiasmullie claimed this task.Jul 18 2022, 10:10 AM
matthiasmullie moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Jul 18 2022, 10:47 AM

Change 814737 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@master] Use getOption to detect user preferences

https://gerrit.wikimedia.org/r/814737

matthiasmullie mentioned this in rEISUa3210a7bd645: Use getOption to detect user preferences.Jul 18 2022, 10:48 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 18 2022, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2022, 11:30 AM
gerritbot added a comment.Jul 18 2022, 12:40 PM

Change 814767 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ImageSuggestions@wmf/1.39.0-wmf.19] Use getOption to detect user preferences

https://gerrit.wikimedia.org/r/814767

gerritbot added a project: Patch-For-Review.Jul 18 2022, 12:40 PM
gerritbot added a comment.Jul 18 2022, 1:10 PM

Change 814767 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@wmf/1.39.0-wmf.19] Use getOption to detect user preferences

https://gerrit.wikimedia.org/r/814767

matthiasmullie mentioned this in rEISU5d0f20f9b26c: Use getOption to detect user preferences.Jul 18 2022, 1:11 PM
Stashbot added a comment.Jul 18 2022, 1:19 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-18T13:19:30Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.39.0-wmf.19/extensions/ImageSuggestions/maintenance/SendNotificationsForUnillustratedWatchedTitles.php: Backport: [[gerrit:814767|Use getOption to detect user preferences (T313209)]] (duration: 02m 50s)

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.19; 2022-07-04); removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 18 2022, 2:00 PM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jul 18 2022, 2:06 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Jul 21 2022, 9:37 PM
CBogen moved this task from To Do to SD: Experienced Contributor Notifications on the Image-Suggestions board.Aug 4 2022, 6:32 PM
matthiasmullie closed this task as Resolved.Aug 18 2022, 9:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits