Page MenuHomePhabricator
Create Task
Maniphest T313775

MinervaNeue "Wikitext Editor.Closing editor (overlay button)" test is flaky
Open, Needs TriagePublic
Actions

Description

Minerva test is flaky and causes wmf-quibble-selenium-php72-docker job to fail.
For instance, https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/162660/console#console-section-13 and https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/161869/console#console-section-13
Error is displayed as shown below:

13:38:58 [0-1] Error in "Wikitext Editor.Closing editor (overlay button)"
13:38:59 Error: element (".overlay .cancel") still not displayed after 5000ms
13:38:59     at Element.<anonymous> (/workspace/src/skins/MinervaNeue/node_modules/@wdio/utils/build/shim.js:276:24)
13:38:59     at iClickTheOverlayCloseButton (/workspace/src/skins/MinervaNeue/tests/selenium/features/step_definitions/common_steps.js:107:47)
13:38:59     at Context.<anonymous> (/workspace/src/skins/MinervaNeue/tests/selenium/specs/editor_wikitext_nosave.js:24:3)

Screenshot 2022-07-26 at 01.44.26.png (1×2 px, 637 KB)

Note: This is currently a blocker for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/790682

Details

SubjectRepoBranchLines +/-
selenium: Skip flaky testmediawiki/skins/MinervaNeuemaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

EAkinloose created this task.Jul 26 2022, 12:47 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJul 26 2022, 12:47 AM
Jdlrobson added a project: Quality-and-Test-Engineering-Team.Jul 26 2022, 7:10 AM
Jdlrobson subscribed.

The error suggests there's either a bug causing the mobile editor to not load or there's a timing problem (e.g. test doesn't wait long enough)

zeljkofilipin added a project: User-zeljkofilipin.Jul 26 2022, 1:07 PM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Deep work 🌊 to Q3 👔 on the User-zeljkofilipin board.Jul 28 2022, 1:27 PM
zeljkofilipin subscribed.
EAkinloose claimed this task.Aug 22 2022, 1:05 PM
EAkinloose updated the task description. (Show Details)
zeljkofilipin changed the task status from Open to In Progress.Aug 23 2022, 10:47 AM
zeljkofilipin moved this task from Q3 👔 to Deep work 🌊 on the User-zeljkofilipin board.
EAkinloose closed this task as Invalid.Sep 21 2022, 2:08 PM

This issue was triggered by this commit and it is now abandoned.

zeljkofilipin reopened this task as Open.Dec 7 2022, 2:37 PM
zeljkofilipin removed EAkinloose as the assignee of this task.
zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.
zeljkofilipin removed a project: Quality-and-Test-Engineering-Team.
zeljkofilipin added a comment.Dec 7 2022, 2:40 PM

This is happening again. See mediawiki/core/860887 (PS9).

gerritbot added a comment.Dec 7 2022, 2:48 PM

Change 865667 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/skins/MinervaNeue@master] selenium: Skip flaky test

https://gerrit.wikimedia.org/r/865667

gerritbot added a project: Patch-For-Review.Dec 7 2022, 2:48 PM
zeljkofilipin claimed this task.Dec 7 2022, 2:55 PM
zeljkofilipin moved this task from Waiting 🏹 to Deep work 🌊 on the User-zeljkofilipin board.
gerritbot added a comment.Dec 7 2022, 3:41 PM

Change 865667 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] selenium: Skip flaky test

https://gerrit.wikimedia.org/r/865667

zeljkofilipin removed zeljkofilipin as the assignee of this task.Dec 7 2022, 3:42 PM
zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 7 2022, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 7 2022, 4:30 PM
zeljkofilipin moved this task from Waiting 🏹 to Backlog 🪒 on the User-zeljkofilipin board.Feb 24 2023, 3:28 PM
Michael subscribed.Oct 18 2023, 8:09 AM

Not sure if this is (almost) the same as T348539: Slow connection warning in editor appearing in Selenium test: Error in "Wikitext Editor.Closing editor (browser button)" Error: waitUntil condition timed out after 5000ms?

Michael mentioned this in T348539: Slow connection warning in editor appearing in Selenium test: Error in "Wikitext Editor.Closing editor (browser button)" Error: waitUntil condition timed out after 5000ms.Oct 18 2023, 8:09 AM
Ammarpad subscribed.Nov 2 2023, 8:06 AM

@Jdlrobson do you think the fix in T348539 will allow re-enabling this test?

Jdlrobson added a comment.Nov 2 2023, 3:55 PM

I would assume so since those 2 tests share test steps but I can't confirm that without the associated video report that went with the test failure. I would suggest merging these tickets for now.

Jbol mentioned this in T280652: Delete tests disabled for more than 1 year.Feb 20 2024, 3:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits