It would be cool if 1.38 supported php 8.1.
This might be a questionable cause, given that 1.39 will be released so soon.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T316080 Make PHP 8.1 voting on applicable and currently supported MW release branches | |||
| Resolved | BUG REPORT | Bawolff | T314208 Make REL1_38 pass test suite on php 8.1 |
Event Timeline
Comment Actions
One of the tests that work on master, is due to 472a914c63baaff93, but that seems like quite a lot to backport.
Comment Actions
Change 820587 had a related patch set uploaded (by Brian Wolff; author: Brian Wolff):
[mediawiki/core@REL1_38] Set $wgServer for HttpRequestFactoryTest to prevent warnings on php8.1
Comment Actions
Change 820588 had a related patch set uploaded (by Brian Wolff; author: Func):
[mediawiki/core@REL1_38] phpunit: Fallback to global default user options
Comment Actions
Change 820589 had a related patch set uploaded (by Brian Wolff; author: Brian Wolff):
[mediawiki/core@REL1_38] Fix one missed case in backport of f82a734751489838de
Comment Actions
Change 820588 merged by jenkins-bot:
[mediawiki/core@REL1_38] phpunit: Fallback to global default user options
Comment Actions
Change 820589 merged by jenkins-bot:
[mediawiki/core@REL1_38] Fix one missed case in backport of f82a734751489838de
Comment Actions
Change 820587 merged by jenkins-bot:
[mediawiki/core@REL1_38] Set $wgServer for HttpRequestFactoryTest to prevent warnings on php8.1
Comment Actions
Ok, so now it seems like qunit is failing:
23:37:25 05 08 2022 23:37:25.692:DEBUG [middleware:source-files]: Fetching /workspace/src/node_modules/karma-qunit/lib/adapter.js 23:37:25 05 08 2022 23:37:25.692:DEBUG [web-server]: serving (cached): /workspace/src/node_modules/karma-qunit/lib/adapter.js 23:37:26 Chrome Headless 90.0.4430.212 (Linux x86_64) ERROR 23:37:26 Script error. 23:37:26 at :0:0 23:37:26 05 08 2022 23:37:26.130:DEBUG [Chrome Headless 90.0.4430.212 (Linux x86_64)]: CONFIGURING -> CONNECTED 23:37:26 05 08 2022 23:37:26.132:DEBUG [launcher]: CAPTURED -> BEING_KILLED 23:37:26 05 08 2022 23:37:26.132:DEBUG [launcher]: BEING_KILLED -> BEING_FORCE_KILLED 23:37:26 05 08 2022 23:37:26.132:DEBUG [Chrome Headless 90.0.4430.212 (Linux x86_64)]: CONNECTED -> DISCONNECTED
https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php81-docker/51/console
Not really sure what to make of that.
Comment Actions
It is passing now on php 8.1 (I am defining this as MW core. No idea about bundled extensions or vendor dependencies). I think php8 passes but its segfaulting all over the place in CI.