Page MenuHomePhabricator
Create Task
Maniphest T314267

getZTesterMetadata: handle appropriately when state.errorState is true
Closed, ResolvedPublic
Actions

Description

Currently zTesterResults.js function getZTesterMetadata does not check for state.errorState = true. Should do so.

At a minimum, we should return an empty ZMap. To facilitate this, consider copying makeEmptyZMap from function-schemata/utils.js into mixins/schemata.js

Details

SubjectRepoBranchLines +/-
Show error message when function call returns a HTTP error instead of a Z22mediawiki/extensions/WikiLambdamaster+147 -75
Customize query in gerrit

Related Objects

Event Timeline

DMartin-WMF created this task.Aug 1 2022, 12:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2022, 12:54 AM
DMartin-WMF added a project: WikiLambda Front-end.Aug 1 2022, 1:03 AM
Maintenance_bot added a project: Abstract Wikipedia team.Aug 1 2022, 1:30 AM
DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Aug 1 2022, 6:37 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:29 PM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:43 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF triaged this task as High priority.Mar 24 2023, 12:57 AM
• Mcastro moved this task from To triage: Nice-to-haves to Verify in production on the Abstract Wikipedia team board.Jan 11 2024, 5:51 PM
Jdforrester-WMF lowered the priority of this task from High to Low.Jan 11 2024, 9:08 PM
Jdforrester-WMF moved this task from Verify in production to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF subscribed.

On review, this indeed is still a potential issue, sadly. Moving to Ready.

DMartin-WMF mentioned this in T354917: Orchestrator sometimes returns a result in normal form.Jan 15 2024, 8:30 PM
gengh claimed this task.Jun 27 2024, 1:29 PM
gerritbot added a comment.Jun 28 2024, 1:41 PM

Change #1050612 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Show error message when function call returns a HTTP error instead of a Z22

https://gerrit.wikimedia.org/r/1050612

gerritbot added a project: Patch-For-Review.Jun 28 2024, 1:41 PM
Jdforrester-WMF closed this task as Resolved.Jul 1 2024, 8:54 PM
Jdforrester-WMF reopened this task as In Progress.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q1 (Jul–Sep)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
gerritbot added a comment.Jul 1 2024, 9:01 PM

Change #1050612 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Show error message when function call returns a HTTP error instead of a Z22

https://gerrit.wikimedia.org/r/1050612

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2024, 9:31 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Jul 1 2024, 10:00 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Jul 10 2024, 4:51 PM
Jdforrester-WMF closed this task as Resolved.Jul 18 2024, 3:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits