Page MenuHomePhabricator
Create Task
Maniphest T314630

Standardize Java build for metrics-platform
Open, Needs TriagePublic
Actions

Description

The metrics-platform project is a mix of multiple languages, including Java. Up to now, the Java build was custom and not relying on our usual template. To ensure coherence and benefit from the same features (SonarQube integration, publication of docs, etc...), we want this project to use the usual templates for building Java projects.

A minimal attempt at configuration is available at https://gerrit.wikimedia.org/r/c/integration/config/+/820396, but it conflicts with the existing configuration.

Details

SubjectRepoBranchLines +/-
Move Maven wrapper to project root dir.mediawiki/libs/metrics-platformmaster+1 -2
Zuul: [mediawiki/libs/metrics-platform] Run Java jobs on maven file pathsintegration/configmaster+9 -0
Zuul: [mediawiki/libs/metrics-platform] Add experimental regular java jobsintegration/configmaster+11 -0
jjb: Add Java build jobs for mediawiki/libs/metrics-platformintegration/configmaster+5 -0
Customize query in gerrit

Event Timeline

Gehel created this task.Aug 5 2022, 8:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2022, 8:55 AM
gerritbot added a comment.Aug 5 2022, 8:56 AM

Change 820396 had a related patch set uploaded (by Gehel; author: Gehel):

[integration/config@master] Java build for mediawiki/libs/metrics-platform

https://gerrit.wikimedia.org/r/820396

gerritbot added a project: Patch-For-Review.Aug 5 2022, 8:56 AM
gerritbot added a comment.Aug 5 2022, 3:13 PM

Change 820764 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/libs/metrics-platform] Add experimental regular java jobs

https://gerrit.wikimedia.org/r/820764

gerritbot added a comment.Aug 5 2022, 3:17 PM

Change 820396 merged by jenkins-bot:

[integration/config@master] jjb: Add Java build jobs for mediawiki/libs/metrics-platform

https://gerrit.wikimedia.org/r/820396

gerritbot added a comment.Aug 5 2022, 3:33 PM

Change 820764 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/libs/metrics-platform] Add experimental regular java jobs

https://gerrit.wikimedia.org/r/820764

Stashbot added a comment.Aug 5 2022, 3:33 PM

Mentioned in SAL (#wikimedia-releng) [2022-08-05T15:33:44Z] <James_F> Zuul: [mediawiki/libs/metrics-platform] Add experimental regular java jobs for T314630

Jdforrester-WMF subscribed.Aug 5 2022, 4:13 PM

I ran the experimental jobs on https://gerrit.wikimedia.org/r/c/mediawiki/libs/metrics-platform/+/820088/8 but they errored:

00:00:14.424 [FATAL tini (7)] exec /src/mvnw failed: No such file or directory
Maintenance_bot removed a project: Patch-For-Review.Aug 5 2022, 4:30 PM
gerritbot added a comment.Aug 6 2022, 1:08 PM

Change 820834 had a related patch set uploaded (by Gehel; author: Gehel):

[mediawiki/libs/metrics-platform@master] Move Maven wrapper to project root dir.

https://gerrit.wikimedia.org/r/820834

gerritbot added a project: Patch-For-Review.Aug 6 2022, 1:08 PM
Gehel added a comment.Aug 6 2022, 1:09 PM
In T314630#8134129, @Jdforrester-WMF wrote:

I ran the experimental jobs on https://gerrit.wikimedia.org/r/c/mediawiki/libs/metrics-platform/+/820088/8 but they errored:

00:00:14.424 [FATAL tini (7)] exec /src/mvnw failed: No such file or directory

Corrected in https://gerrit.wikimedia.org/r/c/mediawiki/libs/metrics-platform/+/820834

gerritbot added a comment.Aug 8 2022, 1:11 PM

Change 821219 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/libs/metrics-platform] Run Java jobs on maven file paths

https://gerrit.wikimedia.org/r/821219

gerritbot added a comment.Aug 8 2022, 1:21 PM

Change 821219 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/libs/metrics-platform] Run Java jobs on maven file paths

https://gerrit.wikimedia.org/r/821219

Stashbot added a comment.Aug 8 2022, 1:23 PM

Mentioned in SAL (#wikimedia-releng) [2022-08-08T13:23:00Z] <James_F> Zuul: [mediawiki/libs/metrics-platform] Run Java jobs on maven file paths for T314630

gerritbot added a comment.Aug 9 2022, 7:17 AM

Change 820834 had a related patch set uploaded (by Gehel; author: Gehel):

[mediawiki/libs/metrics-platform@master] Move Maven wrapper to project root dir.

https://gerrit.wikimedia.org/r/820834

Gehel added a comment.Aug 9 2022, 7:35 AM

The experimental build seems to be passing on https://gerrit.wikimedia.org/r/c/mediawiki/libs/metrics-platform/+/820834. At least metrics-platform-maven-java8-docker is green. metrics-platform-maven-java8-docker-site-publish is failing, but that is due to a known flaky test (which will be corrected at some future point). The current build (trigger-metrics-platform-pipeline-test-java) is now failing, since it expects Maven wrapper (mvnw) to be in the java directory, but that's expected.

What's left to do:

  • deactivate the current build (trigger-metrics-platform-pipeline-test-java) since it is being replaced by the standard java builds (and maybe cleanup some templates if this isn't used anymore)
  • have metrics-platform-maven-java8-docker run on every CR
  • have metrics-platform-maven-java8-docker run on every CR pre-merge (is that gate-and-submit?)
  • have metrics-platform-maven-java8-docker-site-publish run post merge on the main branch (master at this point)
  • maybe adapt some of the zuul triggers (but that's something that I entirely don't understand)
thcipriani removed a project: Release-Engineering-Team.Sep 14 2022, 4:53 PM
thcipriani added a project: Release-Engineering-Team (Radar).
gerritbot added a comment.Sep 28 2022, 5:04 AM

Change 820834 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] Move Maven wrapper to project root dir.

https://gerrit.wikimedia.org/r/820834

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits