Page MenuHomePhabricator

Investigate why ProofreadPage (patch 813328) causes selenium CI failures
Closed, ResolvedPublicBUG REPORT

Description

Error: filetype-banned: ".djvu" is not a permitted file type. Permitted file types are png, gif, jpg, jpeg, webp, ogg, ogv, oga, flac, opus, wav, webm, mp3, midi, mid, mpg, mpeg.
     at /workspace/src/extensions/ProofreadPage/node_modules/mwbot/src/index.js:262:31
     at tryCatcher (/workspace/src/extensions/ProofreadPage/node_modules/bluebird/js/release/util.js:16:23)
     at Promise._settlePromiseFromHandler (/workspace/src/extensions/ProofreadPage/node_modules/bluebird/js/release/promise.js:547:31)
     at Promise._settlePromise (/workspace/src/extensions/ProofreadPage/node_modules/bluebird/js/release/promise.js:604:18)
     at Promise._settlePromise0 (/workspace/src/extensions/ProofreadPage/node_modules/bluebird/js/release/promise.js:649:10)
     at Promise._settlePromises (/workspace/src/extensions/ProofreadPage/node_modules/bluebird/js/release/promise.js:729:18)
     at _drainQueueStep (/workspace/src/extensions/ProofreadPage/node_modules/bluebird/js/release/async.js:93:12)
     at _drainQueue (/workspace/src/extensions/ProofreadPage/node_modules/bluebird/js/release/async.js:86:9)
     at Async._drainQueues (/workspace/src/extensions/ProofreadPage/node_modules/bluebird/js/release/async.js:102:5)
     at Immediate.Async.drainQueues [as _onImmediate] (/workspace/src/extensions/ProofreadPage/node_modules/bluebird/js/release/async.js:15:14)
     at processImmediate (internal/timers.js:464:21)

per this comment

Event Timeline

Soda triaged this task as High priority.

In patch 813328 I've added a few selenium tests that require a uploading a djvu file. We also edit the LocalSettings.php file to specifically allow djvu files in the selenium setup which should have taken care of this particular scenario. Maybe we want to restart the local server as well after editing the files ?

This is breaking CI tests for CheckUser.

taavi raised the priority of this task from High to Unbreak Now!.Aug 15 2022, 10:41 AM

In patch 813328 I've added a few selenium tests that require a uploading a djvu file. We also edit the LocalSettings.php file to specifically allow djvu files in the selenium setup which should have taken care of this particular scenario. Maybe we want to restart the local server as well after editing the files ?

Based on https://github.com/wikimedia/mediawiki-extensions-GrowthExperiments/blob/master/tests/selenium/wdio.conf.js#L51-L64 GrowthExperiments appear to be doing something similar ?

Change 823123 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/ProofreadPage@master] Fix selenium CI errors caused by Ib24f6339424f9ab4fb94e7eb76db756a446a3be7

https://gerrit.wikimedia.org/r/823123

Change 823123 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Fix selenium CI errors caused by Ib24f6339424f9ab4fb94e7eb76db756a446a3be7

https://gerrit.wikimedia.org/r/823123

Urbanecm subscribed.

Looks like the patch did the trick. Closing.