Page MenuHomePhabricator

AbuseFilter special pages should use new skin tab feature
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where):
In T313349 we made it possible for special pages to register menus. This will soon be added to Minerva and Vector 2022 skins.

A backwards compatible change can be made which will make it easier to navigate between sub pages in AbuseFilter special page.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):

BeforeAfter
Screen Shot 2022-08-18 at 1.12.22 PM.png (1×2 px, 290 KB)
Screen Shot 2022-08-18 at 1.12.03 PM.png (608×2 px, 150 KB)

Benefits (why should this be implemented?):
The new tabs are more inline with skin design, have larger touch areas and what is the currently selected page.

Event Timeline

Change 816211 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/AbuseFilter@master] Register AbuseFilter menu as standard tabs

https://gerrit.wikimedia.org/r/816211

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/11c19507c1/w

@Jdlrobson Is it really intended that the menu appears twice (both the new and old style navigation) in the new Vector?

obrazek.png (171×2 px, 26 KB)

@Jdlrobson Is it really intended that the menu appears twice (both the new and old style navigation) in the new Vector?

obrazek.png (171×2 px, 26 KB)

No. Looks like there is an issue with the logic. Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/816211/14..16/includes/Special/AbuseFilterSpecialPage.php.

Change 816211 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Register AbuseFilter menu as standard tabs

https://gerrit.wikimedia.org/r/816211