Page MenuHomePhabricator

[third-party FaceBook extension] Warning: Parameter 3 to __lambda_func() expected to be a reference, value given in includes/parser/Parser.php on line 3470
Closed, InvalidPublic

Description

Author: anton.kochkov

Description:
Warning: Parameter 3 to __lambda_func() expected to be a reference, value given in includes/parser/Parser.php on line 3470

on this source text:

Widgets

[[Widget:Google Spreadsheet]]

Here is my plans

  1. Integrate one
  2. Integrate second

Social Integration

<fb:comments></fb:comments>


Version: unspecified
Severity: normal

Details

Reference
bz29557

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:32 PM
bzimport set Reference to bz29557.
bzimport added a subscriber: Unknown Object (MLST).

Core MediaWiki doesn't use lambdas. This seems to be an extension related.

Sounds like it's probably whatever extension handles that <fb:comments> tag.

(Extension's tag hook needs to be updated to take the $parser option by value/object rather than by reference -- remove the '&' from it.)

This seems to be maintained at SourceForce, you might want to report it there.

Seems to be this extension?

http://www.mediawiki.org/wiki/Extension:Facebook

They don't seem to have bug reports enabled on the SourceForge project, so you may need to contact the authors directly.

Closing as INVALID. Unfortunately we cannot help you with reports on code that is not being maintained in the Wikimedia repositories.

garbearucla wrote:

Hi, I'm the author of the facebook extension. A few years ago, the MediaWiki documentation specified pass-by-reference parameters for some hooks. Slowly, a lot of these are quietly being converted to pass-by-value params (4 or 5 breaking changes in the history of my extension). Would I be wise to convert as many of the remaining reference params as possible to guard against future conversions like this?