[Regression] Legacy vector: Color of Special:Contributions red links is different than talk page red links
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Urbanecm
	Aug 19 2022, 11:59 AM

Description

Originally reported at https://cs.wikipedia.org/wiki/Wikipedie:Pod_l%C3%ADpou_(technika)#c-Draceane-20220819115100-David_V.-20220813173800.

Talk page red links have different color from Special:Contributions red link, see https://cs.wikipedia.org/wiki/Speci%C3%A1ln%C3%AD:Protokolovac%C3%AD_z%C3%A1znamy?type=newusers&user=&page=&wpdate=&tagfilter=&subtype=&useskin=vector as an example (or screenshot below):

There appear to be the following two CSS definitions with different shades of red:

.mw-usertoollinks-contribs-no-edits { /* Special:Contributions */
    color: #dd3333;
}

.skin-vector-legacy a.new { /* new pages, such as talk page link */
    color: #ba0000;
}

Can the shade of red be the same for all red links?

QA Results - Prod

AC	Status	Details
1	✅	T315662#8187273

Details

	Subject	Repo	Branch	Lines +/-
	Remove FIXME, add variables	mediawiki/skins/Vector	master	+2 -17

Customize query in gerrit

Event Timeline

Urbanecm created this task.Aug 19 2022, 11:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2022, 11:59 AM

Draceane subscribed.Aug 19 2022, 1:13 PM

Jdlrobson renamed this task from Legacy vector: Color of Special:Contributions red links is different than talk page red links to [regression] Legacy vector: Color of Special:Contributions red links is different than talk page red links.Aug 22 2022, 7:57 AM

Jdlrobson added a project: Regression.

ovasileva triaged this task as High priority.Aug 22 2022, 7:58 AM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q1); removed Web-Team-Backlog.

Change 825327 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Remove unnecessary FIXME

https://gerrit.wikimedia.org/r/825327

gerritbot added a project: Patch-For-Review.Aug 22 2022, 11:34 AM

Can the shade of red be the same for all red links?

Looks like there's a bit of technical debt that needs removing. The contribs link is showing the right color, but the red link isn't. @Volker_E can you review?

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Aug 22 2022, 11:37 AM

ovasileva renamed this task from [regression] Legacy vector: Color of Special:Contributions red links is different than talk page red links to [Regression] Legacy vector: Color of Special:Contributions red links is different than talk page red links.Aug 22 2022, 3:21 PM

ovasileva lowered the priority of this task from High to Medium.Aug 22 2022, 5:38 PM

ovasileva set the point value for this task to 2.

ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

Change 825327 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove FIXME, add variables

https://gerrit.wikimedia.org/r/825327

Maintenance_bot removed a project: Patch-For-Review.Aug 22 2022, 7:31 PM

Jdlrobson moved this task from Ready for Development to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Aug 22 2022, 7:37 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 22 2022, 8:00 PM

Edtadros claimed this task.Aug 25 2022, 5:04 PM

Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

Test Result - Prod

Status: ✅ PASS
Environment: cswiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: All red links should be the same color red.

Screen Shot 2022-08-25 at 4.04.52 PM.png (238×886 px, 107 KB)

Screen Shot 2022-08-25 at 4.05.04 PM.png (227×860 px, 111 KB)

Screen Shot 2022-08-25 at 4.04.43 PM.png (230×899 px, 102 KB)

Edtadros updated the task description. (Show Details)Aug 25 2022, 11:08 PM

ovasileva closed this task as Resolved.Aug 26 2022, 8:46 AM

	F35490375: Screen Shot 2022-08-25 at 4.04.43 PM.png
	Aug 25 2022, 11:07 PM

	F35490376: Screen Shot 2022-08-25 at 4.05.04 PM.png
	Aug 25 2022, 11:07 PM

	F35490374: Screen Shot 2022-08-25 at 4.04.52 PM.png
	Aug 25 2022, 11:07 PM

[Regression] Legacy vector: Color of Special:Contributions red links is different than talk page red linksClosed, ResolvedPublic2 Estimated Story PointsActions