Page MenuHomePhabricator
Create Task
Maniphest T316311

GrowthExperiments\WelcomeSurveyHooks->onCentralAuthPostLoginRedirect does write on GET
Closed, ResolvedPublicBUG REPORT
Actions

Description

Logstash: https://logstash.wikimedia.org/goto/4329483df25ad32e391b4a09093365e3

Expectation (masterConns <= 0) by MediaWiki::main not met (actual: 2):
[connect to db1136 (centralauth)]
from /srv/mediawiki/php-1.39.0-wmf.26/includes/libs/rdbms/TransactionProfiler.php(467)
#0 /srv/mediawiki/php-1.39.0-wmf.26/includes/libs/rdbms/TransactionProfiler.php(222): Wikimedia\Rdbms\TransactionProfiler->reportExpectationViolated(string, string, integer)
#1 /srv/mediawiki/php-1.39.0-wmf.26/includes/libs/rdbms/loadbalancer/LoadBalancer.php(980): Wikimedia\Rdbms\TransactionProfiler->recordConnection(string, string, boolean)
#2 /srv/mediawiki/php-1.39.0-wmf.26/includes/libs/rdbms/loadbalancer/LoadBalancer.php(941): Wikimedia\Rdbms\LoadBalancer->getServerConnection(integer, string, integer)
#3 /srv/mediawiki/php-1.39.0-wmf.26/includes/libs/rdbms/database/DBConnRef.php(95): Wikimedia\Rdbms\LoadBalancer->getConnectionInternal(integer, array, string, integer)
#4 /srv/mediawiki/php-1.39.0-wmf.26/includes/libs/rdbms/database/DBConnRef.php(101): Wikimedia\Rdbms\DBConnRef->ensureConnection()
#5 /srv/mediawiki/php-1.39.0-wmf.26/includes/libs/rdbms/database/DBConnRef.php(351): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#6 /srv/mediawiki/php-1.39.0-wmf.26/extensions/CentralAuth/includes/User/CentralAuthUser.php(564): Wikimedia\Rdbms\DBConnRef->selectRow(array, array, array, string, array, array)
#7 /srv/mediawiki/php-1.39.0-wmf.26/extensions/CentralAuth/includes/User/CentralAuthUser.php(452): MediaWiki\Extension\CentralAuth\User\CentralAuthUser->loadFromDatabase()
#8 /srv/mediawiki/php-1.39.0-wmf.26/extensions/CentralAuth/includes/User/CentralAuthUser.php(737): MediaWiki\Extension\CentralAuth\User\CentralAuthUser->loadState()
#9 /srv/mediawiki/php-1.39.0-wmf.26/extensions/CentralAuth/includes/CentralAuthHooks.php(486): MediaWiki\Extension\CentralAuth\User\CentralAuthUser->isAttached()
#10 /srv/mediawiki/php-1.39.0-wmf.26/includes/HookContainer/HookContainer.php(160): MediaWiki\Extension\CentralAuth\CentralAuthHooks->onUserSaveSettings(User)
#11 /srv/mediawiki/php-1.39.0-wmf.26/includes/HookContainer/HookRunner.php(4328): MediaWiki\HookContainer\HookContainer->run(string, array)
#12 /srv/mediawiki/php-1.39.0-wmf.26/includes/user/UserOptionsManager.php(398): MediaWiki\HookContainer\HookRunner->onUserSaveSettings(User)
#13 /srv/mediawiki/php-1.39.0-wmf.26/extensions/GrowthExperiments/includes/WelcomeSurvey.php(336): MediaWiki\User\UserOptionsManager->saveOptions(User)
#14 /srv/mediawiki/php-1.39.0-wmf.26/extensions/GrowthExperiments/includes/WelcomeSurvey.php(376): GrowthExperiments\WelcomeSurvey->saveSurveyData(array)
#15 /srv/mediawiki/php-1.39.0-wmf.26/extensions/GrowthExperiments/includes/WelcomeSurveyHooks.php(124): GrowthExperiments\WelcomeSurvey->saveGroup(string)
#16 /srv/mediawiki/php-1.39.0-wmf.26/includes/HookContainer/HookContainer.php(160): GrowthExperiments\WelcomeSurveyHooks->onCentralAuthPostLoginRedirect(string, string, boolean, string, string)
#17 /srv/mediawiki/php-1.39.0-wmf.26/extensions/CentralAuth/includes/Hooks/CentralAuthHookRunner.php(54): MediaWiki\HookContainer\HookContainer->run(string, array)
#18 /srv/mediawiki/php-1.39.0-wmf.26/extensions/CentralAuth/includes/Special/SpecialCentralLogin.php(333): MediaWiki\Extension\CentralAuth\Hooks\CentralAuthHookRunner->onCentralAuthPostLoginRedirect(string, string, boolean, string, string)
#19 /srv/mediawiki/php-1.39.0-wmf.26/extensions/CentralAuth/includes/Special/SpecialCentralLogin.php(90): MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin->doLoginComplete(string)
#20 /srv/mediawiki/php-1.39.0-wmf.26/includes/specialpage/SpecialPage.php(701): MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin->execute(string)
#21 /srv/mediawiki/php-1.39.0-wmf.26/includes/specialpage/SpecialPageFactory.php(1426): SpecialPage->run(string)
#22 /srv/mediawiki/php-1.39.0-wmf.26/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#23 /srv/mediawiki/php-1.39.0-wmf.26/includes/MediaWiki.php(905): MediaWiki->performRequest()
#24 /srv/mediawiki/php-1.39.0-wmf.26/includes/MediaWiki.php(562): MediaWiki->main()
#25 /srv/mediawiki/php-1.39.0-wmf.26/index.php(50): MediaWiki->run()
#26 /srv/mediawiki/php-1.39.0-wmf.26/index.php(46): wfIndexMain()
#27 /srv/mediawiki/w/index.php(3): require(string)
#28 {main}

Also a bunch of Expectation (writes <= 0) by MediaWiki::main not met (actual: 1) errors, with similar stack traces (minus the CentralAuth part).

I'm not sure why/how CentralAuth is involved in this, but probably we should make sure that the survey group is recorded immediately on registration and not during the redirect.

Details

SubjectRepoBranchLines +/-
Fix WelcomeSurvey CentralAuthPostLoginRedirect hook (step 1)mediawiki/extensions/GrowthExperimentswmf/1.39.0-wmf.26+26 -4
Fix WelcomeSurvey CentralAuthPostLoginRedirect hookmediawiki/extensions/GrowthExperimentsmaster+28 -5
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Aug 26 2022, 6:56 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 26 2022, 6:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Aug 26 2022, 6:57 AM
Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Aug 26 2022, 7:07 AM

Change 826774 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Fix WelcomeSurvey CentralAuthPostLoginRedirect hook

https://gerrit.wikimedia.org/r/826774

gerritbot added a project: Patch-For-Review.Aug 26 2022, 7:07 AM
Tgr claimed this task.Aug 26 2022, 7:07 AM
Tgr triaged this task as High priority.
Tgr moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Tgr updated the task description. (Show Details)Aug 26 2022, 7:12 AM
gerritbot added a comment.Aug 29 2022, 10:08 AM

Change 827191 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.26] Fix WelcomeSurvey CentralAuthPostLoginRedirect hook

https://gerrit.wikimedia.org/r/827191

gerritbot added a comment.Aug 29 2022, 10:10 AM

Change 827191 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.26] Fix WelcomeSurvey CentralAuthPostLoginRedirect hook

Reason:

https://gerrit.wikimedia.org/r/827191

gerritbot added a comment.Aug 29 2022, 10:50 AM

Change 826774 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix WelcomeSurvey CentralAuthPostLoginRedirect hook

https://gerrit.wikimedia.org/r/826774

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Aug 29 2022, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 29 2022, 11:30 AM
gerritbot added a comment.Aug 29 2022, 6:00 PM

Change 827191 restored by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.26] Fix WelcomeSurvey CentralAuthPostLoginRedirect hook

https://gerrit.wikimedia.org/r/827191

gerritbot added a project: Patch-For-Review.Aug 29 2022, 6:00 PM
gerritbot added a comment.Aug 29 2022, 8:51 PM

Change 827191 merged by Clare Ming:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.26] Fix WelcomeSurvey CentralAuthPostLoginRedirect hook (step 1)

https://gerrit.wikimedia.org/r/827191

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.26; 2022-08-22); removed MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Aug 29 2022, 9:00 PM
Stashbot added a comment.Aug 29 2022, 9:01 PM

Mentioned in SAL (#wikimedia-operations) [2022-08-29T21:01:33Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.26/extensions/GrowthExperiments/includes/WelcomeSurveyHooks.php: Backport: [[gerrit:827191|Fix WelcomeSurvey CentralAuthPostLoginRedirect hook (step 1) (T315583 T316311)]] (duration: 03m 36s)

Stashbot mentioned this in T315583: PHP Warning: Invalid argument supplied for foreach() at GlobalFunctions (from GrowthExperiments WelcomeSurveyHooks.php).Aug 29 2022, 9:01 PM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 30 2022, 7:39 AM

Should be fixed in production now.

Etonkovidova closed this task as Resolved.Sep 1 2022, 8:23 PM
Etonkovidova subscribed.

Checked - the issue is not present; the last timestamp - Aug 29, 2022 @ 21:00:27.563 (logstash link

Krinkle moved this task from Untriaged to Aug 2022 on the Wikimedia-production-error board.Sep 8 2022, 10:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits