Page MenuHomePhabricator
Create Task
Maniphest T317215

Selser broken on html endpoints
Closed, ResolvedPublic
Actions

Description

@Quiddity noted,

I've noticed at Officewiki recently, that my VE-edits will sometimes also result in many changes to whitespace, and hence confusing diffs.

meaning that selser isn't being run.

This is because SelserData isn't returned if !$this->hasOriginalHtml(),
https://github.com/wikimedia/mediawiki/blob/master/includes/parser/Parsoid/HTMLTransform.php#L439-L444

On private wikis, RESTBase isn't enabled, so the old html isn't sent back. Parsoid has the ability to reparse the page in order to perform selser but it needs a SelserData with a null oldHTML,
https://github.com/wikimedia/parsoid/blob/master/src/Wikitext/ContentModelHandler.php#L101-L109

The restriction of requiring the original html makes sense in the pagebundle case, in light of T146187

This looks like it was added in If97a74ce251f281b7d980928a01b764d6ec0d0a4

Details

SubjectRepoBranchLines +/-
Fix selser on html endpointsmediawiki/coreREL1_39+1 -6
Fix selser on html endpointsmediawiki/corewmf/1.39.0-wmf.28+1 -6
Fix selser on html endpointsmediawiki/corewmf/1.39.0-wmf.27+1 -6
Fix selser on html endpointsmediawiki/coremaster+1 -6
Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.Sep 7 2022, 4:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2022, 4:19 PM
gerritbot added a comment.Sep 7 2022, 4:37 PM

Change 830669 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Fix selser on html endpoints

https://gerrit.wikimedia.org/r/830669

gerritbot added a project: Patch-For-Review.Sep 7 2022, 4:37 PM
gerritbot added a comment.Sep 7 2022, 8:54 PM

Change 830669 merged by jenkins-bot:

[mediawiki/core@master] Fix selser on html endpoints

https://gerrit.wikimedia.org/r/830669

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 7 2022, 9:00 PM
gerritbot added a comment.Sep 7 2022, 9:01 PM

Change 830702 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@wmf/1.39.0-wmf.27] Fix selser on html endpoints

https://gerrit.wikimedia.org/r/830702

gerritbot added a comment.Sep 7 2022, 9:02 PM

Change 830703 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@wmf/1.39.0-wmf.28] Fix selser on html endpoints

https://gerrit.wikimedia.org/r/830703

Arlolra triaged this task as High priority.Sep 7 2022, 10:17 PM
• JMcLeod_WMF moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Sep 8 2022, 2:13 PM
gerritbot added a comment.Sep 8 2022, 8:20 PM

Change 830702 merged by jenkins-bot:

[mediawiki/core@wmf/1.39.0-wmf.27] Fix selser on html endpoints

https://gerrit.wikimedia.org/r/830702

Stashbot added a comment.Sep 8 2022, 8:21 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-08T20:21:25Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:830702|Fix selser on html endpoints (T317215)]]

Stashbot added a comment.Sep 8 2022, 8:21 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-08T20:21:48Z] <samtar@deploy1002> samtar and arlolra: Backport for [[gerrit:830702|Fix selser on html endpoints (T317215)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Sep 8 2022, 8:33 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-08T20:33:31Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:830702|Fix selser on html endpoints (T317215)]] (duration: 12m 06s)

gerritbot added a comment.Sep 8 2022, 8:54 PM

Change 830703 merged by jenkins-bot:

[mediawiki/core@wmf/1.39.0-wmf.28] Fix selser on html endpoints

https://gerrit.wikimedia.org/r/830703

Stashbot added a comment.Sep 8 2022, 8:55 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-08T20:55:00Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:830703|Fix selser on html endpoints (T317215)]]

Stashbot added a comment.Sep 8 2022, 8:55 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-08T20:55:24Z] <samtar@deploy1002> samtar and arlolra: Backport for [[gerrit:830703|Fix selser on html endpoints (T317215)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Sep 8 2022, 9:00 PM
Stashbot added a comment.Sep 8 2022, 9:01 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-08T21:01:49Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:830703|Fix selser on html endpoints (T317215)]] (duration: 06m 48s)

Arlolra closed this task as Resolved.Sep 8 2022, 9:08 PM
Arlolra claimed this task.
Arlolra added a subscriber: daniel.
Maintenance_bot removed a project: Patch-For-Review.Sep 8 2022, 9:30 PM
ssingh awarded a token.Sep 9 2022, 2:22 PM
gerritbot added a comment.Sep 12 2022, 4:21 PM

Change 831601 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@REL1_39] Fix selser on html endpoints

https://gerrit.wikimedia.org/r/831601

gerritbot added a project: Patch-For-Review.Sep 12 2022, 4:21 PM
gerritbot added a comment.Sep 15 2022, 5:23 AM

Change 831601 merged by Jforrester:

[mediawiki/core@REL1_39] Fix selser on html endpoints

https://gerrit.wikimedia.org/r/831601

Maintenance_bot removed a project: Patch-For-Review.Sep 15 2022, 5:30 AM
ReleaseTaggerBot edited projects, added MW-1.39-notes; removed MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Sep 15 2022, 6:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL