Page MenuHomePhabricator

Resolve Z18s, Z9s, and Z7s Which Are Not at the Top Level of an Argument
Closed, ResolvedPublic

Description

If a function received argument of type List( String ) [1], some of whose elements were in fact Z9/References or some other unresolved type (e.g. [2]), those elements would not be resolved, causing validation to fail (among other defects). This should be rectified.

[1]

{
  Z1K1: 'Z7',
  Z7K1: 'Z881',
  Z881K1: 'Z6'
}

[2]

[
  'Z6',
  'Z100041'
]

Event Timeline

cmassaro renamed this task from Resolve Z18s, Z9s, and Z7s Which Are Not at Top Level of an Argument to Resolve Z18s, Z9s, and Z7s Which Are Not at the Top Level of an Argument .Sep 7 2022, 6:53 PM
cmassaro created this task.
cmassaro updated the task description. (Show Details)
Mahir256 renamed this task from Resolve Z18s, Z9s, and Z7s Which Are Not at the Top Level of an Argument to Resolve Z18s, Z9s, and Z7s Which Are Not at the Top Level of an Argument.Sep 7 2022, 9:37 PM

We are going to hold off on solving this one explicitly. If the validator overhaul works correctly, this will no longer be an issue.

Jdforrester-WMF changed the task status from Open to Stalled.Sep 20 2022, 6:41 PM
Jdforrester-WMF subscribed.

Stalled pending a decision on the verification strategy.

Note that I think this issue is not depending on the validation strategy (on the contrary, this issue would even be a blocker for a working validation strategy). We can fix and should fix it independently.

Change 861933 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Fully evaluate arguments before executing functions.

https://gerrit.wikimedia.org/r/861933

Change 861933 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Fully evaluate arguments before executing functions.

https://gerrit.wikimedia.org/r/861933