Page MenuHomePhabricator
Create Task
Maniphest T317985

Error: Call to a member function isSpecial() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   Error: Call to a member function isSpecial() on null
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.1/extensions/GrowthExperiments/includes/HomepageHooks.php(478)
#0 /srv/mediawiki/php-1.40.0-wmf.1/includes/HookContainer/HookContainer.php(338): GrowthExperiments\HomepageHooks::onSkinMinervaOptionsInit(MediaWiki\Minerva\Skins\SkinMinerva, MediaWiki\Minerva\SkinOptions)
#1 /srv/mediawiki/php-1.40.0-wmf.1/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#2 /srv/mediawiki/php-1.40.0-wmf.1/includes/Hooks.php(137): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#3 /srv/mediawiki/php-1.40.0-wmf.1/skins/MinervaNeue/includes/Hooks.php(288): Hooks::run(string, array)
#4 /srv/mediawiki/php-1.40.0-wmf.1/skins/MinervaNeue/includes/Hooks.php(337): MediaWiki\Minerva\Hooks::setMinervaSkinOptions(MobileContext, MediaWiki\Minerva\Skins\SkinMinerva)
#5 /srv/mediawiki/php-1.40.0-wmf.1/includes/HookContainer/HookContainer.php(338): MediaWiki\Minerva\Hooks::onRequestContextCreateSkinMobile(MobileContext, MediaWiki\Minerva\Skins\SkinMinerva)
#6 /srv/mediawiki/php-1.40.0-wmf.1/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#7 /srv/mediawiki/php-1.40.0-wmf.1/extensions/MobileFrontend/includes/MobileFrontendHooks.php(128): MediaWiki\HookContainer\HookContainer->run(string, array)
#8 /srv/mediawiki/php-1.40.0-wmf.1/includes/HookContainer/HookContainer.php(338): MobileFrontendHooks::onRequestContextCreateSkin(RequestContext, MediaWiki\Minerva\Skins\SkinMinerva)
#9 /srv/mediawiki/php-1.40.0-wmf.1/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#10 /srv/mediawiki/php-1.40.0-wmf.1/includes/HookContainer/HookRunner.php(3187): MediaWiki\HookContainer\HookContainer->run(string, array)
#11 /srv/mediawiki/php-1.40.0-wmf.1/includes/context/RequestContext.php(507): MediaWiki\HookContainer\HookRunner->onRequestContextCreateSkin(RequestContext, MediaWiki\Minerva\Skins\SkinMinerva)
#12 /srv/mediawiki/php-1.40.0-wmf.1/includes/parser/ParserOutput.php(429): RequestContext->getSkin()
#13 /srv/mediawiki/php-1.40.0-wmf.1/extensions/DiscussionTools/includes/Notifications/EventDispatcher.php(70): ParserOutput->getText()
#14 /srv/mediawiki/php-1.40.0-wmf.1/extensions/DiscussionTools/includes/Notifications/EventDispatcher.php(112): MediaWiki\Extension\DiscussionTools\Notifications\EventDispatcher::getParsedRevision(MediaWiki\Revision\RevisionStoreRecord)
#15 /srv/mediawiki/php-1.40.0-wmf.1/extensions/DiscussionTools/includes/Hooks/EchoHooks.php(112): MediaWiki\Extension\DiscussionTools\Notifications\EventDispatcher::generateEventsForRevision(array, MediaWiki\Revision\RevisionStoreRecord)
#16 /srv/mediawiki/php-1.40.0-wmf.1/includes/HookContainer/HookContainer.php(338): MediaWiki\Extension\DiscussionTools\Hooks\EchoHooks::onEchoGetEventsForRevision(array, MediaWiki\Revision\RevisionStoreRecord, boolean)
#17 /srv/mediawiki/php-1.40.0-wmf.1/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#18 /srv/mediawiki/php-1.40.0-wmf.1/includes/Hooks.php(137): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#19 /srv/mediawiki/php-1.40.0-wmf.1/extensions/Echo/includes/DiscussionParser.php(165): Hooks::run(string, array)
#20 /srv/mediawiki/php-1.40.0-wmf.1/extensions/Echo/includes/Hooks.php(558): EchoDiscussionParser::generateEventsForRevision(MediaWiki\Revision\RevisionStoreRecord, boolean)
#21 /srv/mediawiki/php-1.40.0-wmf.1/includes/deferred/MWCallableUpdate.php(38): MediaWiki\Extension\Notifications\Hooks::MediaWiki\Extension\Notifications\{closure}()
#22 /srv/mediawiki/php-1.40.0-wmf.1/includes/deferred/DeferredUpdates.php(474): MWCallableUpdate->doUpdate()
#23 /srv/mediawiki/php-1.40.0-wmf.1/includes/deferred/DeferredUpdates.php(399): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#24 /srv/mediawiki/php-1.40.0-wmf.1/includes/deferred/DeferredUpdates.php(227): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, MediaWiki\JobQueue\JobQueueGroupFactory, string)
#25 /srv/mediawiki/php-1.40.0-wmf.1/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#26 /srv/mediawiki/php-1.40.0-wmf.1/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#27 /srv/mediawiki/php-1.40.0-wmf.1/includes/deferred/DeferredUpdates.php(230): DeferredUpdatesScope->processUpdates(integer, Closure)
#28 /srv/mediawiki/php-1.40.0-wmf.1/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(AtomicSectionUpdate, integer)
#29 /srv/mediawiki/php-1.40.0-wmf.1/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#30 /srv/mediawiki/php-1.40.0-wmf.1/includes/deferred/DeferredUpdates.php(235): DeferredUpdatesScope->processUpdates(integer, Closure)
#31 /srv/mediawiki/php-1.40.0-wmf.1/extensions/EventBus/includes/JobExecutor.php(105): DeferredUpdates::doUpdates()
#32 /srv/mediawiki/rpc/RunSingleJob.php(77): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#33 {main}
Impact
Notes

Details

MediaWiki Version
1.40.0-wmf.1
Request URL
https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php
SubjectRepoBranchLines +/-
Check for null title in SkinMinervaOptionsInit hook handlermediawiki/extensions/GrowthExperimentsmaster+5 -3
Customize query in gerrit

Event Timeline

Zabe created this task.Sep 16 2022, 2:28 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptSep 16 2022, 2:28 PM
Aklapper added a project: GrowthExperiments-Homepage.Sep 16 2022, 3:16 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 16 2022, 3:16 PM
gerritbot added a comment.Sep 21 2022, 6:37 AM

Change 833701 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/GrowthExperiments@master] Check for null title in SkinMinervaOptionsInit hook handler

https://gerrit.wikimedia.org/r/833701

gerritbot added a project: Patch-For-Review.Sep 21 2022, 6:37 AM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Sep 21 2022, 9:07 AM
kostajh subscribed.
In T317985#8249723, @gerritbot wrote:

Change 833701 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/GrowthExperiments@master] Check for null title in SkinMinervaOptionsInit hook handler

https://gerrit.wikimedia.org/r/833701

Thank you for the patch!

kostajh triaged this task as Medium priority.Sep 21 2022, 9:08 AM
kostajh moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Sep 21 2022, 9:30 AM

Change 833701 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Check for null title in SkinMinervaOptionsInit hook handler

https://gerrit.wikimedia.org/r/833701

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2022, 9:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 21 2022, 10:00 AM
thcipriani moved this task from Untriaged to Sep 2022 on the Wikimedia-production-error board.Oct 20 2022, 3:53 PM
Etonkovidova closed this task as Resolved.Oct 20 2022, 4:42 PM
Etonkovidova claimed this task.
Etonkovidova subscribed.

Checked - link for Sep15-Oct20/2022 - no more errors have been recorded after Sep 16, 2022.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits