Page MenuHomePhabricator

Request Entity Too Large!!!
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • create a function with a native code implementation
  • specify at least one input as a list of lists, e.g.
{
  Z1K1: 'Z7',
  Z7K1: 'Z881',
  Z881K1: {
      Z1K1: 'Z7',
      Z7K1: 'Z881',
      Z881K1: 'Z6'
  }
}
  • supply an argument of that type, too! e.g.
[
  {
    'Z1K1': 'Z7',
    'Z7K1': 'Z881',
    'Z881K1': 'Z6'
  },
  [
    'Z6',
    'sylvan historian that canst thus express'
  ]
]

What happens?:
The function-evaluator will fail violently with the error "request entity too large."

What should have happened instead?:
Request entity shouldn't have been too large.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

cmassaro renamed this task from Request Too Large!!! to Request Entity Too Large!!!.Sep 22 2022, 5:23 PM
cmassaro updated the task description. (Show Details)

Things we can consider doing:

  • "un-expanding" certain function calls, like built-in type or generic function resolution
  • making multiple chunked requests to the function-evaluator

Change 838888 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-evaluator@master] Increase max_body_size so that larger request entities can be sent.

https://gerrit.wikimedia.org/r/838888

Change 838888 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Increase max_body_size so that larger request entities can be sent.

https://gerrit.wikimedia.org/r/838888

Change 838889 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-evaluator@master] Expect Avro-serialized request bodies in addition to raw JSON.

https://gerrit.wikimedia.org/r/838889

Change 838890 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Serialize requests with Avro before sending.

https://gerrit.wikimedia.org/r/838890

Change 838889 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Expect Avro-serialized request bodies in addition to raw JSON.

https://gerrit.wikimedia.org/r/838889

Change 838890 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Serialize requests with Avro before sending.

https://gerrit.wikimedia.org/r/838890