Page MenuHomePhabricator
Create Task
Maniphest T319185

Suppressed accounts should be removed from Mentor dashboard
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Notice an inappropriate username of a mentee
  • Globally suppress the mentee

What happens?:

  • The mentee with an inappropriate username still appears on the Mentor dashboard:

What should have happened instead?:

  • The mentee is removed from the dashboard or crossed out there

Other information (browser name/version, screenshots, etc.):

image.png (366×941 px, 39 KB)

Now, I am not sure what would happen if I didn't have access rights to see the suppressed information (I am a global steward), but what I would expect to happen is to either have the mentee removed altogether or crossed out similarly to what is done in page histories for the username:

image.png (128×1 px, 106 KB)

Details

SubjectRepoBranchLines +/-
DataTableCellMentee: Strike-through suppressed menteesmediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.6+30 -7
DataTableCellMentee: Strike-through suppressed menteesmediawiki/extensions/GrowthExperimentsmaster+30 -7
Customize query in gerrit

Event Timeline

Base created this task.Oct 3 2022, 11:53 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 3 2022, 11:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Base added a comment.Oct 3 2022, 11:54 AM

(It also does not mention that the user is blocked at all in the dashboard, which is either the same or related bug depending on how you look at it).

Maintenance_bot added a project: GrowthExperiments-Mentorship.Oct 3 2022, 12:30 PM
Base renamed this task from Suppressed accounts should be removed from Mentour dashboard to Suppressed accounts should be removed from Mentor dashboard.Oct 4 2022, 9:25 AM
Base added a comment.Oct 4 2022, 4:43 PM

The account seems to be removed from the dashboard now. Is there some delay because it is managed by a job queue?

Urbanecm_WMF subscribed.Oct 5 2022, 9:53 AM

Hello @Base,

thanks for reporting the issue!

In T319185#8279348, @Base wrote:

(It also does not mention that the user is blocked at all in the dashboard, which is either the same or related bug depending on how you look at it).

The numbers are meant to update every three hours (getting some of the aggregated numbers is expensive, so it's not realtime unfortunately). That said, suppressed users are supposed to disappear immediately.

In T319185#8283786, @Base wrote:

The account seems to be removed from the dashboard now. Is there some delay because it is managed by a job queue?

This is not supposed to happen. Do you remember how long the delay was, please?

Urbanecm_WMF claimed this task.Oct 5 2022, 9:58 AM
Urbanecm_WMF triaged this task as High priority.
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team, Anti-Harassment.
Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Oct 5 2022, 10:15 AM
Urbanecm_WMF added a comment.Oct 6 2022, 12:35 PM

So, I tried to reproduce the issue at test.wikipedia. Fortunately, the account disappeared immediately from the dashboard when I used an unprivileged testing account. For my WMF account (has access to suppressed accounts via +staff), the account stayed in the dashboard (without signalizing the account is suppressed).

So, I guess there is no leak of private information (fortunately). We should, however, cross the username similar to page histories.

gerritbot added a comment.Oct 6 2022, 7:21 PM

Change 839674 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [WIP] DataTableCellMentee: Strike-through suppressed mentees

https://gerrit.wikimedia.org/r/839674

gerritbot added a project: Patch-For-Review.Oct 6 2022, 7:21 PM
Urbanecm_WMF changed the task status from Open to In Progress.Oct 6 2022, 7:28 PM
Urbanecm_WMF moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
Base added a comment.Oct 6 2022, 11:15 PM

Do you remember how long the delay was, please?

I don't know when it has disappeared exactly. I have written my comment about it doing so as soon as I have noticed it, but I wasn't really checking the dashboard in the meantime

Stang subscribed.Oct 6 2022, 11:18 PM
kostajh moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 18 2022, 3:26 PM
gerritbot added a comment.Oct 18 2022, 3:46 PM

Change 839674 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] DataTableCellMentee: Strike-through suppressed mentees

https://gerrit.wikimedia.org/r/839674

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 18 2022, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 18 2022, 4:31 PM
Urbanecm_WMF changed the task status from In Progress to Open.Oct 20 2022, 12:51 PM
gerritbot added a comment.Oct 20 2022, 12:52 PM

Change 844043 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.6] DataTableCellMentee: Strike-through suppressed mentees

https://gerrit.wikimedia.org/r/844043

gerritbot added a project: Patch-For-Review.Oct 20 2022, 12:52 PM
gerritbot added a comment.Oct 20 2022, 1:16 PM

Change 844043 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.6] DataTableCellMentee: Strike-through suppressed mentees

https://gerrit.wikimedia.org/r/844043

Stashbot added a comment.Oct 20 2022, 1:21 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-20T13:21:43Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:844043|DataTableCellMentee: Strike-through suppressed mentees (T319185)]]

Stashbot added a comment.Oct 20 2022, 1:22 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-20T13:22:03Z] <urbanecm@deploy1002> urbanecm and urbanecm: Backport for [[gerrit:844043|DataTableCellMentee: Strike-through suppressed mentees (T319185)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Stashbot added a comment.Oct 20 2022, 1:27 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-20T13:27:02Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:844043|DataTableCellMentee: Strike-through suppressed mentees (T319185)]] (duration: 05m 18s)

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2022, 1:33 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.6; 2022-10-17); removed MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 20 2022, 2:00 PM
Urbanecm_WMF closed this task as Resolved.Oct 20 2022, 2:13 PM

Verified during B&C deployment, resolving.

Stang unsubscribed.Oct 23 2022, 10:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits