Maniphest T319356

Replace custom user menu rendering
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

None

Authored By

	bwang
	Oct 4 2022, 9:55 PM

Description

Background

After T319349, we are able to replace all the PHP around rendering the user menu dropdown with a new approach of rendering multiple Menus inside a Dropdown. This removes a lot of tech debt from SkinVector.php, and sets the standard for how complex dropdowns like the article toolbar and main menu dropdown will be rendered in the future.

TODO

New menu buckets are created in Hooks.php that correspond with the anon editor menu group and the logout menu group
The new menu buckets are used in the user links template data
UserLinkslogin.mustache, UserLinkslogout.mustache and UserLinks__templogin.mustache are deleted

AC

No visual changes

Developer notes

This will involve changes to the HTML, cached HTML is a potential concern as well as changing id/classes.

Details

	Subject	Repo	Branch	Lines +/-
	Remove custom handling of user links menu items and handle case when anon editor links are disabled	mediawiki/skins/Vector	master	+230 -212
	POC: Refactor user menu dropdown to use multiple menu groups	mediawiki/skins/Vector	master	+82 -149

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T319356 Replace custom user menu rendering
		Resolved		None	T328954 Extensions adding menu items to 'user-menu' should not appear under "Pages for logged out editors"

Event Timeline

bwang created this task.Oct 4 2022, 9:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2022, 9:55 PM

bwang mentioned this in T319355: Move modern Vector PHP code in SkinVector.php to SkinVector22.php.Oct 4 2022, 9:55 PM

bwang updated the task description. (Show Details)Oct 4 2022, 10:06 PM

Change 837741 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] POC: Refactor user menu dropdown to use multiple menu groups

https://gerrit.wikimedia.org/r/837741

gerritbot added a project: Patch-For-Review.Oct 4 2022, 10:17 PM

@bwang: Assuming this task is about the Vector code base, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate project tags when possible. Thanks!

Jdlrobson added a project: Desktop Improvements (Vector 2022).Oct 5 2022, 7:50 PM

Jdlrobson triaged this task as Medium priority.Oct 6 2022, 6:15 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q2); removed Web-Team-Backlog.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

Jdlrobson set the point value for this task to 1.Oct 7 2022, 5:42 PM

ovasileva lowered the priority of this task from Medium to Low.Oct 25 2022, 5:00 PM

I dont think this is actually needed for article tools, it would be nice to have time to do this later on, especially after T320927, but I feel like this could be moved to the backlog.

Change 837741 abandoned by Bernard Wang:

[mediawiki/skins/Vector@master] POC: Refactor user menu dropdown to use multiple menu groups

Reason:

https://gerrit.wikimedia.org/r/837741

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2022, 10:30 PM

bwang mentioned this in T320927: Create Dropdown and Menu Skin component classes.Nov 15 2022, 6:30 PM

ovasileva moved this task from Upcoming to Blocked on Others on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.Dec 12 2022, 6:43 PM

ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-2022-23-Q2).Dec 19 2022, 5:32 PM

ovasileva moved this task from Incoming to Groomed on the Web-Team-Backlog board.

Jdlrobson moved this task from Incoming to Visual Enhancements / Layout on the Desktop Improvements (Vector 2022) board.Jan 18 2023, 3:51 PM

bwang added a subtask: T328954: Extensions adding menu items to 'user-menu' should not appear under "Pages for logged out editors".Feb 6 2023, 9:46 PM

Change 885910 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove custom handling of user links menu items and handle case when anon editor links are disabled

https://gerrit.wikimedia.org/r/885910

gerritbot added a project: Patch-For-Review.Feb 6 2023, 9:46 PM

Jdlrobson changed the status of subtask T328954: Extensions adding menu items to 'user-menu' should not appear under "Pages for logged out editors" from Open to Stalled.Feb 9 2023, 10:02 PM

Change 885910 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove custom handling of user links menu items and handle case when anon editor links are disabled

https://gerrit.wikimedia.org/r/885910

Maintenance_bot removed a project: Patch-For-Review.Feb 9 2023, 10:30 PM

bwang closed this task as Resolved.Feb 15 2023, 6:21 PM

bwang closed subtask T328954: Extensions adding menu items to 'user-menu' should not appear under "Pages for logged out editors" as Resolved.Feb 15 2023, 6:24 PM

Replace custom user menu renderingClosed, ResolvedPublic1 Estimated Story PointsActions