Maniphest T319427

PHP Deprecated: Use of Skin::footerLink was deprecated in MediaWiki 1.40. [Called from MediaWiki\Extension\OAuth\Frontend\SpecialPages\SpecialMWOAuth::handleAuthorizationForm]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Zabe
	Oct 5 2022, 3:02 PM

Description

Error

mwversion: 1.40.0-wmf.4
reqId: 09378cc2-233f-492c-9a32-fea32fdd31ef
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Deprecated: Use of Skin::footerLink was deprecated in MediaWiki 1.40. [Called from MediaWiki\Extension\OAuth\Frontend\SpecialPages\SpecialMWOAuth::handleAuthorizationForm]

exception.trace

from /srv/mediawiki/php-1.40.0-wmf.4/extensions/OAuth/src/Frontend/SpecialPages/SpecialMWOAuth.php(544)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.40.0-wmf.4/includes/debug/MWDebug.php(381): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.40.0-wmf.4/includes/debug/MWDebug.php(352): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.40.0-wmf.4/includes/debug/MWDebug.php(233): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.40.0-wmf.4/includes/GlobalFunctions.php(769): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.40.0-wmf.4/includes/skins/Skin.php(983): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.40.0-wmf.4/extensions/OAuth/src/Frontend/SpecialPages/SpecialMWOAuth.php(544): Skin->footerLink(string, string)
#7 /srv/mediawiki/php-1.40.0-wmf.4/extensions/OAuth/src/Frontend/SpecialPages/SpecialMWOAuth.php(155): MediaWiki\Extension\OAuth\Frontend\SpecialPages\SpecialMWOAuth->handleAuthorizationForm(string, string, boolean)
#8 /srv/mediawiki/php-1.40.0-wmf.4/includes/specialpage/SpecialPage.php(701): MediaWiki\Extension\OAuth\Frontend\SpecialPages\SpecialMWOAuth->execute(string)
#9 /srv/mediawiki/php-1.40.0-wmf.4/includes/specialpage/SpecialPageFactory.php(1433): SpecialPage->run(string)
#10 /srv/mediawiki/php-1.40.0-wmf.4/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#11 /srv/mediawiki/php-1.40.0-wmf.4/includes/MediaWiki.php(904): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.40.0-wmf.4/includes/MediaWiki.php(562): MediaWiki->main()
#13 /srv/mediawiki/php-1.40.0-wmf.4/index.php(50): MediaWiki->run()
#14 /srv/mediawiki/php-1.40.0-wmf.4/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}

Impact

Notes

Details

MediaWiki Version: 1.40.0-wmf.4
Request URL: https://www.mediawiki.org/wiki/Special:OAuth/authorize

	Subject	Repo	Branch	Lines +/-
	Replace deprecated Skin::footerLink for privacy link	mediawiki/extensions/OAuth	master	+24 -1

Customize query in gerrit

Related Objects

Mentioned Here: T59457: Split privacy policy message into link and display text
T302116: Componentize MenuLink and Footers

Event Timeline

Zabe created this task.Oct 5 2022, 3:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2022, 3:02 PM

Jdforrester-WMF triaged this task as High priority.Oct 6 2022, 7:32 PM

Deprecated in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/808913 / T302116 / "Use SkinComponentMenuLink::getTemplateData instead." / Respect of policy not given - https://www.mediawiki.org/wiki/Stable_interface_policy#Deprecation_process / https://codesearch.wmcloud.org/search/?q=%5Cb(footerLink%7ClastModified)%5Cs*%5C(&i=nope&files=%5C.php&excludeFiles=&repos=

Was changed some years ago to this function because it was using a deprecated function before (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OAuth/+/622847)

The need of that function was added with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OAuth/+/203996 / T59457 to share the code how to generate the privacy link from skin with that special page (was not sure if there is a good reason to call skin function from non-skin code)

Replacement looks like overkill for this usecase, it seems better to use the messages directly

Change 840212 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/OAuth@master] Replace deprecated Skin::footerLink for privacy link

https://gerrit.wikimedia.org/r/840212

gerritbot added a project: Patch-For-Review.Oct 7 2022, 6:46 PM

Change 840212 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Replace deprecated Skin::footerLink for privacy link

https://gerrit.wikimedia.org/r/840212

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2022, 7:30 PM

Jdforrester-WMF closed this task as Resolved.Oct 7 2022, 7:44 PM

Jdforrester-WMF assigned this task to Umherirrender.

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 7 2022, 8:00 PM

Krinkle moved this task from Untriaged to Oct 2022 on the Wikimedia-production-error board.Nov 17 2022, 4:19 PM

PHP Deprecated: Use of Skin::footerLink was deprecated in MediaWiki 1.40. [Called from MediaWiki\Extension\OAuth\Frontend\SpecialPages\SpecialMWOAuth::handleAuthorizationForm]Closed, ResolvedPublicPRODUCTION ERRORActions