Page MenuHomePhabricator

Instances of assertRegExp that need updating (as of 1.40.0-wmf.4)
Closed, ResolvedPublic

Description

This is against 1.40.0-wmf.4; so it might be out of date. Worth updating when 1.40.0-wmf.5 is branched.

WikibaseLexeme/tests/phpunit/mediawiki/Diff/ItemReferenceDifferenceVisualizerTest.php:		$this->assertRegExp(
WikibaseLexeme/tests/phpunit/mediawiki/Diff/ItemReferenceDifferenceVisualizerTest.php:		$this->assertRegExp(
WikibaseLexeme/tests/phpunit/mediawiki/Diff/ItemReferenceDifferenceVisualizerTest.php:		$this->assertRegExp(
WikibaseLexeme/tests/phpunit/mediawiki/View/TemplateModuleTest.php:		$this->assertRegExp(
GrowthExperiments/tests/phpunit/integration/HelpdeskQuestionPosterTest.php:		$this->assertRegExp(
GrowthExperiments/tests/phpunit/integration/HelpdeskQuestionPosterTest.php:		$this->assertRegExp(
GrowthExperiments/tests/phpunit/integration/Api/ApiQueryGrowthTasksTest.php:		$this->assertRegExp( "/^[a-z0-9]{32}+$/", $data['query']['growthtasks']['suggestions'][0]['token'] );
GrowthExperiments/tests/phpunit/integration/Api/ApiQueryGrowthTasksTest.php:		$this->assertRegExp( "/^[a-z0-9]{32}+$/", $pages['token'] );
WikibaseMediaInfo/tests/phpunit/mediawiki/View/MediaInfoEntityStatementsViewTest.php:		$this->assertRegExp( $this->getPropertyIdRegex( $sortedStatementList ), $html );
WikibaseMediaInfo/tests/phpunit/mediawiki/View/MediaInfoEntityStatementsViewTest.php:		$this->assertRegExp(
WikibaseMediaInfo/tests/phpunit/mediawiki/View/MediaInfoEntityStatementsViewTest.php:		$this->assertRegExp(
WikibaseMediaInfo/tests/phpunit/mediawiki/View/MediaInfoEntityTermsViewTest.php:		$this->assertRegExp(
WikibaseMediaInfo/tests/phpunit/mediawiki/View/MediaInfoEntityTermsViewTest.php:			$this->assertRegExp(
WikibaseMediaInfo/tests/phpunit/mediawiki/View/MediaInfoEntityTermsViewTest.php:			$this->assertRegExp(
WikibaseMediaInfo/tests/phpunit/mediawiki/View/MediaInfoEntityTermsViewTest.php:			$this->assertRegExp(
WikibaseMediaInfo/tests/phpunit/mediawiki/View/MediaInfoEntityTermsViewTest.php:			$this->assertRegExp(
WikibaseMediaInfo/tests/phpunit/mediawiki/View/MediaInfoEntityTermsViewTest.php:			$this->assertRegExp(
WikibaseMediaInfo/tests/phpunit/mediawiki/View/MediaInfoEntityTermsViewTest.php:			$this->assertRegExp(
Translate/tests/phpunit/unit/Utilities/ParsingPlaceholderFactoryTest.php:		$this->assertRegExp( '/[a-zA-Z0-9\x7f]/', $obj->make() );
DonationInterface/tests/phpunit/EmployerSearchApiTest.php:		$this->assertRegExp( '/^Employer data file is empty or can\'t be parsed.*/',
DonationInterface/tests/phpunit/EmployerSearchApiTest.php:		$this->assertRegExp( '/^Employer data file doesn\'t exist.*/',
DonationInterface/tests/phpunit/EmployerSearchApiTest.php:		$this->assertRegExp( '/^Wrong number of columns in a row of employer data file.*/',
DonationInterface/tests/phpunit/Adapter/GlobalCollect/RecurringTest.php:		$this->assertRegExp( '/SET_PAYMENT/', $result->getRawResponse() );
DonationInterface/tests/phpunit/Adapter/GlobalCollect/RecurringTest.php:		$this->assertRegExp( '/GET_ORDERSTATUS/', $result->getRawResponse(),
DonationInterface/tests/phpunit/Adapter/GlobalCollect/RecurringTest.php:		$this->assertRegExp( '/GET_ORDERSTATUS/', $result->getRawResponse() );
DonationInterface/tests/phpunit/Adapter/GlobalCollect/RecurringTest.php:		$this->assertRegExp( '/SET_PAYMENT/', $result->getRawResponse() );
DonationInterface/tests/phpunit/Adapter/Ingenico/IngenicoApiTest.php:					$this->assertRegExp(
DonationInterface/tests/phpunit/Adapter/Ingenico/RecurringTest.php:		$this->assertRegExp( '/SET_PAYMENT/', $result->getRawResponse() );
DonationInterface/tests/phpunit/Adapter/Ingenico/RecurringTest.php:		$this->assertRegExp(
DonationInterface/tests/phpunit/Adapter/Ingenico/RecurringTest.php:		$this->assertRegExp( '/GET_ORDERSTATUS/', $result->getRawResponse() );
DonationInterface/tests/phpunit/Adapter/Ingenico/RecurringTest.php:		$this->assertRegExp( '/SET_PAYMENT/', $result->getRawResponse() );
DonationInterface/tests/phpunit/Adapter/Ingenico/IngenicoTest.php:				$this->assertRegExp(
DonationInterface/tests/phpunit/MustacheFormTest.php:		$this->assertRegExp( $regexp, $html );
Wikibase/view/tests/phpunit/StatementGroupListViewTest.php:		$this->assertRegExp( '/^[^$]*\$' . implode( '\n[^$]*\$', [
Wikibase/view/tests/phpunit/EntityViewTestCase.php:		$this->assertRegExp( '/id="wb-[a-z]+-' . $entityId . '"/', $html );
Wikibase/view/tests/phpunit/StatementHtmlGeneratorTest.php:			$this->assertRegExp( $pattern, $html, $message );
Wikibase/repo/tests/phpunit/includes/Diff/BasicDiffViewTest.php:			$this->assertRegExp(
Wikibase/repo/tests/phpunit/includes/Diff/BasicDiffViewTest.php:		$this->assertRegExp( $pattern, $html, 'Diff table content line' );
Wikibase/repo/tests/phpunit/includes/Diff/SiteLinkDiffViewTest.php:			$this->assertRegExp(
Wikibase/repo/tests/phpunit/includes/Diff/SiteLinkDiffViewTest.php:		$this->assertRegExp( $pattern, $html, 'Diff table content line' );
Wikibase/repo/tests/phpunit/includes/Diff/DiffOpValueFormatterTest.php:		$this->assertRegExp( $pattern, $html );
Wikibase/repo/tests/phpunit/includes/Specials/SpecialListPropertiesTest.php:		$this->assertRegExp( '/P45.*P123.*P789/', $output ); // order is relevant
Wikibase/repo/tests/phpunit/includes/Specials/SpecialSetSiteLinkTest.php:		$this->assertRegExp(
Wikibase/repo/tests/phpunit/includes/Specials/SpecialEntityDataTest.php:			$this->assertRegExp( $expRegExp, $output, "output" );
Wikibase/repo/tests/phpunit/includes/Specials/SpecialEntityDataTest.php:				$this->assertRegExp( $exp, $value, "header: $name" );
Wikibase/repo/tests/phpunit/includes/Specials/SpecialEntityDataTest.php:			$this->assertRegExp( $expRegExp, $e->getHTML(), "error output" );
Wikibase/repo/tests/phpunit/includes/Specials/SpecialMergeItemsTest.php:		$this->assertRegExp( '!\(wikibase-mergeitems-success: Q1, \d+, Q2, \d+\)!', $html, 'Expected success message' );
Wikibase/repo/tests/phpunit/includes/LinkedData/EntityDataSerializationServiceTest.php:			$this->assertRegExp( $expectedDataRegex, $data, "expected: $key" );
Wikibase/repo/tests/phpunit/includes/LinkedData/EntityDataRequestHandlerTest.php:			$this->assertRegExp( $expectedOutput, $text, 'output' );
Wikibase/repo/tests/phpunit/includes/LinkedData/EntityDataRequestHandlerTest.php:				$this->assertRegExp( $exp, $value, "header: $name" );
Wikibase/repo/tests/phpunit/includes/LinkedData/EntityDataRequestHandlerTest.php:			$this->assertRegExp( $expectedOutput, $e->getHTML(), 'error output' );
Wikibase/repo/tests/phpunit/includes/LinkedData/EntityDataUriManagerTest.php:		$this->assertRegExp( $expectedExp, $actual );
Wikibase/repo/tests/phpunit/includes/SummaryFormatterTest.php:			$this->assertRegExp( $expected, $comment, "Didn't find the expected final comment" );
Wikibase/repo/tests/phpunit/includes/Api/GetEntitiesTest.php:		$this->assertRegExp(
Wikibase/repo/tests/phpunit/includes/Api/WikibaseApiTestCase.php:		$this->assertRegExp( $regex, $comment->text );
Wikibase/repo/tests/phpunit/includes/Api/ParseValueTest.php:			$this->assertRegExp( $expected, $data, $name );
Wikibase/repo/tests/phpunit/includes/Api/ApiConventionsTest.php:			$this->assertRegExp(
Wikibase/repo/tests/phpunit/includes/Api/ApiErrorReporterTest.php:			$this->assertRegExp( $info, $actualInfo, 'error info message' );
Wikibase/repo/tests/phpunit/includes/Api/ApiErrorReporterTest.php:			$this->assertRegExp( $expected, $data, $name );
Wikibase/repo/tests/phpunit/includes/Api/FormatSnakValueTest.php:		$this->assertRegExp( $pattern, $resultArray['result'] );
Wikibase/repo/tests/phpunit/includes/Actions/EditEntityActionTest.php:			$this->assertRegExp( $htmlPattern, $out->getHTML() );
Wikibase/repo/tests/phpunit/includes/Actions/EditEntityActionTest.php:					$this->assertRegExp( $pattern, $act, $p );
Wikibase/repo/tests/phpunit/includes/Actions/EditEntityActionTest.php:		$this->assertRegExp( '![:/=]Q\d+$!', $out->getRedirect(), 'successful operation should return a redirect' );
Wikibase/repo/tests/phpunit/includes/Actions/EditEntityActionTest.php:			$this->assertRegExp( $error, $out->getHTML() );
Wikibase/repo/tests/phpunit/includes/Actions/EditEntityActionTest.php:			$this->assertRegExp( '![:/=]Q\d+$!', $out->getRedirect(), 'successful operation should return a redirect' );
Wikibase/repo/tests/phpunit/includes/EntityModificationTestHelper.php:		Assert::assertRegExp( $regex, $entry['summary'], $message );
Wikibase/repo/tests/phpunit/includes/View/RepoSpecialPageLinkerTest.php:		$this->assertRegExp( $expectedMatch, $link );
Wikibase/repo/tests/phpunit/includes/ItemSearchTextGeneratorTest.php:			$this->assertRegExp( $pattern . 'm', $text );
Wikibase/repo/tests/phpunit/includes/RepoHooksTest.php:		$this->assertRegExp(
Wikibase/repo/tests/phpunit/includes/RepoHooksTest.php:		$this->assertRegExp(
Wikibase/client/tests/phpunit/integration/includes/RecentChanges/ChangeLineFormatterTest.php:			$this->assertRegExp( $pattern, $formattedLine );
Wikibase/client/tests/phpunit/integration/includes/RecentChanges/ChangeLineFormatterTest.php:			$this->assertRegExp( $pattern, $formattedLine );
Wikibase/client/tests/phpunit/integration/includes/RecentChanges/ChangeLineFormatterTest.php:			$this->assertRegExp( $pattern, $formattedLine );
Wikibase/client/tests/phpunit/integration/includes/ChangeNotificationJobTest.php:		$this->assertRegExp( $regex, $s );
Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeDeletionNotificationJobTest.php:		$this->assertRegExp( '/^ChangeDeletionNotification/', $job->toString() );
Wikibase/client/tests/phpunit/integration/includes/ChangeModification/ChangeVisibilityNotificationJobTest.php:		$this->assertRegExp( '/^ChangeVisibilityNotification/', $job->toString() );
Wikibase/client/tests/phpunit/integration/includes/DataAccess/ParserFunctions/StatementsParserFunctionIntegrationTest.php:		$this->assertRegExp(
Wikibase/client/tests/phpunit/integration/includes/DataAccess/ParserFunctions/PropertyParserFunctionIntegrationTest.php:		$this->assertRegExp(
Wikibase/client/tests/phpunit/unit/includes/RepoItemLinkGeneratorTest.php:			$this->assertRegExp( $expected, $link );
Wikibase/client/tests/phpunit/unit/includes/DataAccess/ParserFunctions/LanguageAwareRendererTest.php:		$this->assertRegExp(
Wikibase/client/tests/phpunit/unit/includes/DataAccess/ParserFunctions/LanguageAwareRendererTest.php:		$this->assertRegExp(
Wikibase/client/tests/phpunit/unit/includes/DataAccess/ParserFunctions/LanguageAwareRendererTest.php:		$this->assertRegExp(
Wikibase/client/tests/phpunit/unit/includes/DataAccess/ParserFunctions/LanguageAwareRendererTest.php:		$this->assertRegExp(
Wikibase/lib/tests/phpunit/Units/UnitConverterTest.php:		$this->assertRegExp( "/^\\$toValue/", $qConverted->getAmount()->getValue(), 'Wrong amount' );
Wikibase/lib/tests/phpunit/Formatters/InterWikiLinkHtmlFormatterTest.php:		$this->assertRegExp( $pattern, $html );
Wikibase/lib/tests/phpunit/Formatters/MonolingualHtmlFormatterTest.php:			$this->assertRegExp( $pattern, $text );
Wikibase/lib/tests/phpunit/Formatters/TimeDetailsFormatterTest.php:		$this->assertRegExp( $pattern, $html );
Wikibase/lib/tests/phpunit/Formatters/GlobeCoordinateDetailsFormatterTest.php:		$this->assertRegExp( $pattern, $html );
Wikibase/lib/tests/phpunit/Formatters/QuantityDetailsFormatterTest.php:		$this->assertRegExp( $pattern, $html );
Wikibase/lib/tests/phpunit/Formatters/WikiLinkHtmlFormatterTest.php:		$this->assertRegExp( $pattern, $html );
Wikibase/lib/tests/phpunit/Formatters/WikiLinkWikitextFormatterTest.php:		$this->assertRegExp( $pattern, $html );
Wikibase/lib/tests/phpunit/Formatters/ItemPropertyIdHtmlLinkFormatterTest.php:		$this->assertRegExp( $expectedPattern, $formatter->formatEntityId( new ItemId( 'Q123' ) ) );
Wikibase/lib/tests/phpunit/Formatters/PropertyValueSnakFormatterTest.php:		$this->assertRegExp( $expected, $actual );
Wikibase/lib/tests/phpunit/Formatters/HtmlUrlFormatterTest.php:		$this->assertRegExp( $pattern, $html );
Wikibase/lib/tests/phpunit/Formatters/LabelsProviderEntityIdHtmlLinkFormatterTest.php:		$this->assertRegExp( $expectedPattern, $result );
Wikibase/lib/tests/phpunit/Formatters/LabelsProviderEntityIdHtmlLinkFormatterTest.php:		$this->assertRegExp( $expectedPattern, $result );
Wikibase/lib/tests/phpunit/Formatters/LabelsProviderEntityIdHtmlLinkFormatterTest.php:		$this->assertRegExp( $expectedPattern, $this->newFormatter()->formatEntityId( $entityId ) );
Wikibase/lib/tests/phpunit/Formatters/LabelsProviderEntityIdHtmlLinkFormatterTest.php:		$this->assertRegExp( $expectedPattern, $this->newFormatter()->formatEntityId( $entityId ) );
Wikibase/lib/tests/phpunit/Formatters/MonolingualTextFormatterTest.php:		$this->assertRegExp( $pattern, $text );
Wikibase/lib/tests/phpunit/Formatters/CommonsInlineImageFormatterTest.php:			$this->assertRegExp( $pattern, $html );
Wikibase/lib/tests/phpunit/Formatters/CommonsInlineImageFormatterTest.php:		$this->assertRegExp( '/320px-Example\.jpg/', $html );
Wikibase/lib/tests/phpunit/Formatters/WikibaseValueFormatterBuildersTest.php:		$this->assertRegExp( $expected, $text );
Wikibase/lib/tests/phpunit/Formatters/WikibaseValueFormatterBuildersTest.php:		$this->assertRegExp( $expected, $text );
Wikibase/lib/tests/phpunit/Formatters/WikibaseValueFormatterBuildersTest.php:		$this->assertRegExp( $expected, $text );
Wikibase/lib/tests/phpunit/Formatters/OutputFormatValueFormatterFactoryTest.php:		$this->assertRegExp( $expectedPattern, $actual );
Wikibase/lib/tests/phpunit/Formatters/CommonsLinkFormatterTest.php:		$this->assertRegExp( $pattern, $html );
SimilarEditors/tests/phpunit/integration/SpecialSimilarEditorsTest.php:		$this->assertRegExp( '/name=\'wpTarget\' value=\'/', $html );
SimilarEditors/tests/phpunit/integration/SpecialSimilarEditorsTest.php:		$this->assertRegExp( '/table class="mw-datatable/', $html );
SecureLinkFixer/tests/phpunit/DomainsTest.php:			$this->assertRegExp( '/^[A-z0-9\-\.]*$/', $domain );
BetaFeatures/tests/phpunit/HTMLFeatureFieldTest.php:			$this->assertRegExp(
BetaFeatures/tests/phpunit/HTMLHorizontalRuleFieldTest.php:		$this->assertRegExp(
BetaFeatures/tests/phpunit/HTMLHorizontalRuleFieldTest.php:		$this->assertRegExp(
ConfirmEdit/tests/phpunit/HTMLFancyCaptchaFieldTest.php:		$this->assertRegExp( '/"fancycaptcha-image"/', $html );
ConfirmEdit/tests/phpunit/HTMLFancyCaptchaFieldTest.php:		$this->assertRegExp( '#src="https://example.com/"#', $html );
ConfirmEdit/tests/phpunit/HTMLFancyCaptchaFieldTest.php:		$this->assertRegExp( '/"mw-createacct-captcha-assisted"/', $html );
ConfirmEdit/tests/phpunit/HTMLFancyCaptchaFieldTest.php:		$this->assertRegExp( '/FooBarBaz/', $html );
EventLogging/tests/phpunit/integration/EventLoggingTest.php:		$this->assertRegExp( $this->timestamp->regexes['TS_ISO_8601'], $result['client_dt'] );
EventLogging/tests/phpunit/integration/EventLoggingHelperTest.php:		$this->assertRegExp( $ts->regexes['TS_ISO_8601'], $preparedEvent['dt'] );
EventLogging/tests/phpunit/integration/EventLoggingHelperTest.php:		$this->assertRegExp( $ts->regexes['TS_ISO_8601'], $preparedEvent['dt'] );
OAuth/tests/phpunit/Lib/OAuthRequestTest.php:		$this->assertRegExp('/[0-9a-f]{32}/', $request->get_parameter('oauth_nonce'));
OAuth/tests/phpunit/Rest/RequestClientEndpointTest.php:					$this->assertRegExp( '/((.*)\.(.*)\.(.*))/', $responseBody['access_token'] );
OAuth/tests/phpunit/Rest/ResetClientSecretEndpointTest.php:					$this->assertRegExp( '/((.*)\.(.*)\.(.*))/', $responseBody['access_token'] );

Event Timeline

Change 840350 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OAuth@master] tests: Replace assertRegExp with assertMatchesRegularExpression

https://gerrit.wikimedia.org/r/840350

Change 840351 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/SimilarEditors@master] tests: Replace assertRegExp with assertMatchesRegularExpression

https://gerrit.wikimedia.org/r/840351

Change 840352 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/SecureLinkFixer@master] tests: Replace assertRegExp with assertMatchesRegularExpression

https://gerrit.wikimedia.org/r/840352

Reedy renamed this task from Instances of assertRegExp that need updating to Instances of assertRegExp that need updating (as of 1.40.0-wmf.4).Oct 8 2022, 10:57 PM

Change 840352 merged by jenkins-bot:

[mediawiki/extensions/SecureLinkFixer@master] tests: Replace assertRegExp with assertMatchesRegularExpression

https://gerrit.wikimedia.org/r/840352

Change 840351 merged by jenkins-bot:

[mediawiki/extensions/SimilarEditors@master] tests: Replace assertRegExp with assertMatchesRegularExpression

https://gerrit.wikimedia.org/r/840351

Change 840350 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] tests: Replace assertRegExp with assertMatchesRegularExpression

https://gerrit.wikimedia.org/r/840350

Change 979151 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MultiMaps@master] tests: Replace assertRegExp with assertMatchesRegularExpression

https://gerrit.wikimedia.org/r/979151

Change 979152 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DonationInterface@master] tests: Replace assertRegExp with assertMatchesRegularExpression

https://gerrit.wikimedia.org/r/979152

Change 979158 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[purtle@master] tests: Replace assertRegExp with assertMatchesRegularExpression

https://gerrit.wikimedia.org/r/979158

Change 979151 merged by jenkins-bot:

[mediawiki/extensions/MultiMaps@master] tests: Replace assertRegExp with assertMatchesRegularExpression

https://gerrit.wikimedia.org/r/979151

Change 979158 merged by jenkins-bot:

[purtle@master] tests: Replace assertRegExp with assertMatchesRegularExpression

https://gerrit.wikimedia.org/r/979158

Change 979152 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] tests: Replace assertRegExp with assertMatchesRegularExpression

https://gerrit.wikimedia.org/r/979152