| Jdlrobson | |
| Oct 10 2022, 8:44 PM |
| F35606225: Screen Shot 2022-10-20 at 3.02.02 PM.png | |
| Oct 20 2022, 10:02 PM |
| F35600087: Screen Shot 2022-10-19 at 9.46.25 AM.png | |
| Oct 19 2022, 3:53 PM |
| F35600086: Screen Shot 2022-10-19 at 9.46.48 AM.png | |
| Oct 19 2022, 3:53 PM |
| F35600085: Screen Shot 2022-10-19 at 9.46.02 AM.png | |
| Oct 19 2022, 3:53 PM |
| F35597615: Screen Shot 2022-10-18 at 5.17.24 PM.png | |
| Oct 18 2022, 11:19 PM |
As follow up work to the introduction of SkinComponentMenu we should dry up the SkinTemplate::getPortletData and SkinTemplate::getPortletLabel methods to use the SkinComponentMenu
Change 840576 had a related patch set uploaded (by Mabualruz; author: Mabualruz):
[mediawiki/core@master] Remove SkinTemplate::getPortletData and SkinTemplate::getPortletLabel
Change 840576 merged by jenkins-bot:
[mediawiki/core@master] Remove SkinTemplate::getPortletData and SkinTemplate::getPortletLabel
I'm noticing the absence of the language button in the visual regression reports
Suggest running Pixel against a revert to see if they are restored. If so, then yeh we should revert this and try again (or submit a follow up!) :-) @Mabualruz could you take a look?
Note: This did not make the branch cut so no backports/reverts needed if we can sort this out by the end of the week.
@Mabualruz I created a revert at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/844496 and then ran ./pixel.js reference -b latest-release followed by ./pixel.js test -c 844496 . That resulted in 0 failures which suggests https://gerrit.wikimedia.org/r/c/mediawiki/core/+/840576 is resulting in the visual changes currently shown on https://pixel.wmcloud.org/reports/desktop/index.html . For future reference, these include:
I am trying to locate where did it fail to add the Add Languages. should we revert to minimise impact until I can find the fix?
Change 844548 had a related patch set uploaded (by Mabualruz; author: Mabualruz):
[mediawiki/core@master] Remove SkinTemplate::getPortletData and SkinTemplate::getPortletLabel
I added support for before and after html in the SkinComponentMenu.php, and passed the value of after from Skin.php. beforeHtml is done through hooks it seems I would prefer to look into it to make the workflow of after and before similar, so we can provide the SkinComponentMenu.php with values and let it handle the cases.
For now htmlBeforeContent is just a place holder logic that should abide to changes once we aligned with workflows like htmlAfterContent
Change 844548 merged by jenkins-bot:
[mediawiki/core@master] Add portlet support for after html in the SkinComponentMenu.php
Pixel is still flagging 4 issues . The remaining ones relate to the user dropdown.
The labels are no longer wrapped in spans.
Change 845071 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] Pass linkOptions to menu items
Change 845071 merged by jenkins-bot:
[mediawiki/core@master] Pass linkOptions to menu items
Change 845737 had a related patch set uploaded (by Nray; author: Nray):
[mediawiki/core@master] Convert SkinComponentMenu `is-empty` from string to boolean
Change 845737 merged by jenkins-bot:
[mediawiki/core@master] Convert SkinComponentMenu `is-empty` from string to boolean