Page MenuHomePhabricator
Create Task
Maniphest T320659

🐼️ Improve the InvalidPatchedStatementException thrown in JsonPatcher in case a value does not match the data type of its property
Closed, ResolvedPublic
Actions

Description

  • find out if SnakValidator reveals the mismatch and the PropertyId (if not: find an easy way to make it work or re-negotiate subtask)
  • create our own Exception as a subclass of InvalidPatchedStatementException
  • determine whether to throw the existing InvalidPatchedStatementException or its new subclass

Details

SubjectRepoBranchLines +/-
REST: patched-statement-value-type-mismatch errormediawiki/extensions/Wikibasemaster+159 -18
REST: Handle patched statement value type mismatchmediawiki/extensions/Wikibasemaster+113 -8
REST: patched-statement-value-type-mismatch errormediawiki/extensions/Wikibasemaster+184 -51
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ollie.Shotton_WMDE created this task.Oct 12 2022, 4:25 PM
Silvan_WMDE mentioned this in T320358: 🐼️ Improve error reporting for PATCH routes.Oct 13 2022, 10:17 AM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 16); removed Wikibase Product Platform (v1) (Sprint 15).Oct 24 2022, 9:45 PM
Ollie.Shotton_WMDE claimed this task.Oct 27 2022, 10:20 AM
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 16) board.
gerritbot added a comment.Nov 1 2022, 8:49 PM

Change 851718 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: patched-statement-value-type-mismatch error

https://gerrit.wikimedia.org/r/851718

gerritbot added a project: Patch-For-Review.Nov 1 2022, 8:49 PM
gerritbot added a comment.Nov 1 2022, 9:02 PM

Change 851719 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: patched-statement-value-type-mismatch error

https://gerrit.wikimedia.org/r/851719

gerritbot added a comment.Nov 2 2022, 5:15 PM

Change 852247 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: patched-statement-value-type-mismatch error

https://gerrit.wikimedia.org/r/852247

gerritbot added a comment.Nov 2 2022, 5:39 PM

Change 851718 abandoned by Ollie Shotton:

[mediawiki/extensions/Wikibase@master] REST: patched-statement-value-type-mismatch error

Reason:

in favour of solution 2: I45800683d5923d77dd8575a9a16df9cd056822f3

https://gerrit.wikimedia.org/r/851718

Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 16) board.Nov 3 2022, 9:53 AM
gerritbot added a comment.Nov 4 2022, 9:36 AM

Change 851719 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Handle patched statement value type mismatch

https://gerrit.wikimedia.org/r/851719

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 4 2022, 10:00 AM
gerritbot added a comment.Nov 4 2022, 3:36 PM

Change 852247 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: patched-statement-value-type-mismatch error

https://gerrit.wikimedia.org/r/852247

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2022, 4:30 PM
Ollie.Shotton_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 16) board.Nov 7 2022, 8:46 AM
WMDE-leszek closed this task as Resolved.Dec 1 2022, 8:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL