Page MenuHomePhabricator

Fix Wikimini.org W3C validator errors
Open, MediumPublic

Description

We can fix W3C validator errors from Wikimini.org:

https://validator.w3.org/nu/?doc=https%3A%2F%2Ffr.wikimini.org%2Fwiki%2FAccueil

The majority are related to the current skin in use.

Source code of the skin:

https://gitlab.wikimedia.org/repos/wikimedia-ch/wikimini.org-mediawiki-skin

Now we have: 144 messages.

Event Timeline

valerio.bozzolan updated the task description. (Show Details)
valerio.bozzolan moved this task from Backlog to Fixes on the Wikimini.org board.

Hi @andrisgombos! Feel free to read the title and the description of this Task: I think it can be really interesting for you and it can be really useful for Wikimini.org.

Let me know :)

@valerio.bozzolan Not sure where would be the best place to ping you, so I'm doing it here...thought you might be interested in the MediaWiki 1.39-compatible fork of the Wikimini skin I put together. I doubt it's suitable to be deployed as-is to Wikimini, if Wikimini were running MW 1.39; besides some obvious cleanup, the mysterious JS errors related to the .tooltip() stuff in ResourceLoader's production (default) mode are annoying and should be somehow fixed. All that said, this might provide an interesting base to hack on. :)

As for this particular issue at hand...looking at the HTML validation output for Special:BlankPage on fr.wikimini.org (since that gives you way more accurate results when we're talking about skin-level HTML validation issues), the only one of those that I've not fixed in my fork is the one related to the #stockIframe element having an empty src. I believe I've fixed the rest, but at the same time, I've temporarily introduced some "new" ones (the way how various links in the skin, e.g. "Report [inappropriate content]", "Top wiki contributors", etc. are generated isn't too great, but I ran into some issues trying to make those better so I figured I'd take another look at 'em at a later date), though I believe those aren't too complex to fix.

Raphoraph triaged this task as Medium priority.Jun 28 2023, 3:21 AM

WOW thanks for your work on that skin!

I'm not sure that I can help on the source code itself, but I can surely help in setting up a staging environment to see your work somehow online, and speed up testing. Would that somehow help?

Or, if the community is strongly OK with that and trust you, maybe we can just have your main branch in sync online in Wikimini.org directly, so users can just test your lovely work picking your skin from their preferences.

What do you think about?

WOW thanks for your work on that skin!

You're welcome. It was an interesting little exercise. :-)

What do you think about?

Whatever works for you and the community and is the easiest to set up. I've tested my work on a vanilla 1.39 installation and it mostly works as intended, though, as noted, not 100% perfectly. I'm more than willing to assist with whatever needs to be done wrt. this skin, but as noted in my earlier message, there was at least one bug I wasn't able to fix on my own, so any and all additional eyes would be more than welcome! Plus testing is something you can never do enough, as real users are infinitely more creative in the ways they use the site than a bunch of automated tests ever can be. ;-)