Page MenuHomePhabricator

Upgrade testing-Wikimini from MediaWiki 1.28.0 to 1.35
Open, MediumPublic8 Estimated Story Points

Description

This page collects info about the upgrade of the testing version of Wikimini from MediaWiki 1.28.0 to 1.35.

Event Timeline

Ouch.

Wikimedia\Rdbms\DBQueryError from line 1699 of /usr/share/mediawiki/includes/libs/rdbms/database/Database.php: Error 1054: Unknown column 'ipb_reason_id' in 'where clause' (127.0.0.1)
Function: MigrateComments::migrate
Query: SELECT  ipb_id,ipb_reason  FROM `wikimini_stockwiki`.`ipblocks`    WHERE ipb_reason_id = 0 AND (1=1)  ORDER BY ipb_id LIMIT 100  

#0 /usr/share/mediawiki/includes/libs/rdbms/database/Database.php(1683): Wikimedia\Rdbms\Database->getQueryException('Unknown column ...', 1054, 'SELECT  ipb_id,...', 'MigrateComments...')
#1 /usr/share/mediawiki/includes/libs/rdbms/database/Database.php(1658): Wikimedia\Rdbms\Database->getQueryExceptionAndLog('Unknown column ...', 1054, 'SELECT  ipb_id,...', 'MigrateComments...')
#2 /usr/share/mediawiki/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError('Unknown column ...', 1054, 'SELECT  ipb_id,...', 'MigrateComments...', false)
#3 /usr/share/mediawiki/includes/libs/rdbms/database/Database.php(1907): Wikimedia\Rdbms\Database->query('SELECT  ipb_id,...', 'MigrateComments...', 32)
#4 /usr/share/mediawiki/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select('ipblocks', Array, Array, 'MigrateComments...', Array)
#5 /usr/share/mediawiki/includes/libs/rdbms/database/DBConnRef.php(313): Wikimedia\Rdbms\DBConnRef->__call('select', Array)
#6 /usr/share/mediawiki/maintenance/migrateComments.php(162): Wikimedia\Rdbms\DBConnRef->select('ipblocks', Array, Array, 'MigrateComments...', Array)
#7 /usr/share/mediawiki/maintenance/migrateComments.php(55): MigrateComments->migrate('ipblocks', Array, 'ipb_reason')
#8 /usr/share/mediawiki/maintenance/includes/LoggedUpdateMaintenance.php(45): MigrateComments->doDBUpdates()
#9 /usr/share/mediawiki/includes/installer/DatabaseUpdater.php(1348): LoggedUpdateMaintenance->execute()
#10 /usr/share/mediawiki/includes/installer/DatabaseUpdater.php(554): DatabaseUpdater->migrateComments()
#11 /usr/share/mediawiki/includes/installer/DatabaseUpdater.php(517): DatabaseUpdater->runUpdates(Array, false)
#12 /usr/share/mediawiki/maintenance/update.php(181): DatabaseUpdater->doUpdates(Array)
#13 /usr/share/mediawiki/maintenance/doMaintenance.php(107): UpdateMediaWiki->execute()
#14 /usr/share/mediawiki/maintenance/update.php(253): require_once('/usr/share/medi...')
#15 {main}

While in theory this should work, it is probably not well tested. Going via 1.31 should help

I am seeing the same error migrating ipblocks, probably due to $wgSharedTables having ipblocks in it. I think the solution will be to unshare the tables.

Thank you so much @tstarling. I can surely try it this week.

I would suggest temporarily removing ipblocks from $wgSharedTables during the upgrade. Re-add it once all wikis are upgraded.