Page MenuHomePhabricator
Create Task
Maniphest T320935

api-testing tests break for GrowthExperiments
Closed, ResolvedPublic
Actions

Description

Following https://gerrit.wikimedia.org/r/c/mediawiki/core/+/818604, all GrowthExperiments builds for api-testing tests are failing with:

11:05:51   2 failing
11:05:51 
11:05:51   1) /transform/ endpoint
11:05:51        wt2html
11:05:51          should return a request too large error when just over limit (post wt):
11:05:51      Error: expected 413 "Payload Too Large", got 200 "OK"
11:05:51       at Test._assertStatus (node_modules/supertest/lib/test.js:270:12)
11:05:51       at Test._assertFunction (node_modules/supertest/lib/test.js:285:11)
11:05:51       at Test.assert (node_modules/supertest/lib/test.js:175:21)
11:05:51       at localAssert (node_modules/supertest/lib/test.js:133:12)
11:05:51       at /workspace/src/node_modules/supertest/lib/test.js:130:5
11:05:51       at Test.Request.callback (node_modules/superagent/lib/node/index.js:894:12)
11:05:51       at IncomingMessage.<anonymous> (node_modules/superagent/lib/node/index.js:1127:20)
11:05:51       at Unzip.<anonymous> (node_modules/superagent/lib/node/unzip.js:53:12)
11:05:51       at endReadableNT (internal/streams/readable.js:1317:12)
11:05:51       at processTicksAndRejections (internal/process/task_queues.js:82:21)
11:05:51 
11:05:51   2) /transform/ endpoint
11:05:51        html2wt
11:05:51          should return a request too large error when just over limit:
11:05:51      Error: expected 413 "Payload Too Large", got 200 "OK"
11:05:51       at Test._assertStatus (node_modules/supertest/lib/test.js:270:12)
11:05:51       at Test._assertFunction (node_modules/supertest/lib/test.js:285:11)
11:05:51       at Test.assert (node_modules/supertest/lib/test.js:175:21)
11:05:51       at localAssert (node_modules/supertest/lib/test.js:133:12)
11:05:51       at /workspace/src/node_modules/supertest/lib/test.js:130:5
11:05:51       at Test.Request.callback (node_modules/superagent/lib/node/index.js:894:12)
11:05:51       at IncomingMessage.<anonymous> (node_modules/superagent/lib/node/index.js:1127:20)
11:05:51       at Unzip.<anonymous> (node_modules/superagent/lib/node/unzip.js:53:12)
11:05:51       at endReadableNT (internal/streams/readable.js:1317:12)
11:05:51       at processTicksAndRejections (internal/process/task_queues.js:82:21)
11:05:51

Details

SubjectRepoBranchLines +/-
jjb: Deployed version of Quibble has QUIBBLE_APACHE flagintegration/configmaster+1 -2
api-testing: Skip the QUIBBLE_APACHE environment checkmediawiki/extensions/GrowthExperimentsmaster+0 -3
api-testing: Set QUIBBLE_APACHE flagintegration/quibblemaster+23 -10
dockerfiles: update to Quibble 1.4.7integration/configmaster+56 -1
release: Quibble 1.4.7integration/quibblemaster+18 -3
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Oct 17 2022, 9:35 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 17 2022, 9:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh claimed this task.Oct 17 2022, 9:36 AM
kostajh triaged this task as High priority.
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh added a project: ci-test-error.
gerritbot added a comment.Oct 17 2022, 9:51 AM

Change 843419 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] WIP: Debug restart php fpm service

https://gerrit.wikimedia.org/r/843419

gerritbot added a project: Patch-For-Review.Oct 17 2022, 9:51 AM
kostajh added projects: Quibble, Continuous-Integration-Config.EditedOct 17 2022, 9:58 AM
kostajh added a subscriber: hashar.

@hashar somehow QUIBBLE_APACHE environment variable isn't set in the api-testing context. We probably have some cleanup work to do there, in integration/config and/or Quibble.

My workaround for this task is to remove the QUIBBLE_APACHE check code in our api-testing code, see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/843419

kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 17 2022, 10:03 AM
gerritbot added a comment.Oct 17 2022, 10:05 AM

Change 843421 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] jjb: Deployed version of Quibble has QUIBBLE_APACHE flag

https://gerrit.wikimedia.org/r/843421

gerritbot added a comment.Oct 17 2022, 10:09 AM

Change 843422 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/quibble@master] api-testing: Set QUIBBLE_APACHE flag

https://gerrit.wikimedia.org/r/843422

kostajh added a comment.Oct 17 2022, 10:15 AM
In T320935#8320470, @gerritbot wrote:

Change 843421 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] jjb: Deployed version of Quibble has QUIBBLE_APACHE flag

https://gerrit.wikimedia.org/r/843421

! In T320935#8320478, @gerritbot wrote:

Change 843422 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/quibble@master] api-testing: Set QUIBBLE_APACHE flag

https://gerrit.wikimedia.org/r/843422

These are both cleanup patches. The main problem is that this code in mediawiki/tools/api-testing doesn't seem to carry over the environment variables when npm test is invoked:

if [ -z "${QUIBBLE_APACHE-}" ]; then
  export API_TESTING_CONFIG_FILE=quibble.json
else
  export API_TESTING_CONFIG_FILE=quibble.apache.json
fi

npm install --no-package-lock
npm test

We know that QUIBBLE_APACHE is set in the if/else statement, because quibble.apache.json is loaded and port 9143 appears in the log. But then npm test which wraps npm run lint && mocha --parallel does not receive the QUIBBLE_APACHE environment variable.

gerritbot added a comment.Oct 17 2022, 10:54 AM

Change 843419 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] api-testing: Skip the QUIBBLE_APACHE environment check

https://gerrit.wikimedia.org/r/843419

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 17 2022, 11:00 AM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 18 2022, 3:06 PM
gerritbot added a comment.Oct 21 2022, 5:48 PM

Change 843422 merged by jenkins-bot:

[integration/quibble@master] api-testing: Set QUIBBLE_APACHE flag

https://gerrit.wikimedia.org/r/843422

gerritbot added a comment.Oct 25 2022, 9:59 AM

Change 849037 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] release: Quibble 1.4.7

https://gerrit.wikimedia.org/r/849037

gerritbot added a comment.Oct 25 2022, 3:25 PM

Change 849037 merged by jenkins-bot:

[integration/quibble@master] release: Quibble 1.4.7

https://gerrit.wikimedia.org/r/849037

Stashbot mentioned this in T318029: Quibble fails with UnicodeDecodeError when test output has invalid unicode.Oct 25 2022, 3:36 PM

Mentioned in SAL (#wikimedia-releng) [2022-10-25T15:36:41Z] <hashar> Tag Quibble 1.4.7 @ f838a24cc2 # T320935 T318029

gerritbot added a comment.Oct 25 2022, 3:42 PM

Change 849116 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] dockerfiles: update to Quibble 1.4.7

https://gerrit.wikimedia.org/r/849116

gerritbot added a comment.Oct 25 2022, 3:49 PM

Change 849116 merged by jenkins-bot:

[integration/config@master] dockerfiles: update to Quibble 1.4.7

https://gerrit.wikimedia.org/r/849116

Stashbot added a comment.Oct 25 2022, 4:33 PM

Mentioned in SAL (#wikimedia-releng) [2022-10-25T16:33:44Z] <hashar> Updating Jenkins jobs for Quibble 1.4.7 # T320935 T318029

hashar added a comment.Oct 25 2022, 4:43 PM

I have updated Quibble on CI to version 1.4.7. It now injects QUIBBLE_APACHE=1 in the environment when running the api-testing stage.

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.8; 2022-10-31); removed MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 26 2022, 1:00 PM
gerritbot added a comment.Nov 4 2022, 12:03 PM

Change 843421 merged by jenkins-bot:

[integration/config@master] jjb: Deployed version of Quibble has QUIBBLE_APACHE flag

https://gerrit.wikimedia.org/r/843421

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2022, 12:30 PM
• EUdoh-WMF subscribed.Nov 23 2022, 7:31 AM

Hi @kostajh, can you kindly point me in the direction of the API test runs for GrowthExperiments?

kostajh added a comment.Nov 23 2022, 9:44 AM
In T320935#8415972, @EUdoh-WMF wrote:

Hi @kostajh, can you kindly point me in the direction of the API test runs for GrowthExperiments?

@EUdoh-WMF on any patch (E.g. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/859460) look for mediawiki-quibble-apitests-vendor-php74-docker , and if you click through to that and click on "Full Log" at the top of the page (e.g. https://integration.wikimedia.org/ci/job/mediawiki-quibble-apitests-vendor-php74-docker/5796/consoleFull) then go to the "Run API-Testing" section (https://integration.wikimedia.org/ci/job/mediawiki-quibble-apitests-vendor-php74-docker/5796/consoleFull#console-section-10), you'll see the output from GrowthExperiments api-testing tests.

• EUdoh-WMF moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 23 2022, 10:44 PM

I see it, thanks a lot. The tests are not failing with the earlier identified error anymore.

kostajh closed this task as Resolved.Nov 28 2022, 1:31 PM
In T320935#8418795, @EUdoh-WMF wrote:

I see it, thanks a lot. The tests are not failing with the earlier identified error anymore.

Cool. Then I will mark this as resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL