Page MenuHomePhabricator
Create Task
Maniphest T321083

Remove action API endpoint from Phonos
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Since T315481: Call IPA Engine from parser hook, the main entrypoint to Phonos is via parser tags. We no longer use the API endpoint at all. We should remove all associated code, since this endpoint serves no purpose.

Acceptance criteria

  • Remove the PhonosApi class and any other associated code.
  • The action=phonos endpoint should no longer exist.

Details

SubjectRepoBranchLines +/-
Phonos API files were removedtranslatewikimaster+1 -14
Remove action API endpoint from Phonosmediawiki/extensions/Phonosmaster+1 -215
Customize query in gerrit

Related Objects

Event Timeline

• NRodriguez created this task.Oct 18 2022, 2:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2022, 2:08 PM
MusikAnimal renamed this task from Remove API previously used to Remove action API endpoint from Phonos.Oct 18 2022, 3:39 PM
MusikAnimal updated the task description. (Show Details)
gerritbot added a comment.Oct 27 2022, 6:34 PM

Change 850251 had a related patch set uploaded (by Dmaza; author: Dmaza):

[mediawiki/extensions/Phonos@master] Remove action API endpoint from Phonos

https://gerrit.wikimedia.org/r/850251

gerritbot added a project: Patch-For-Review.Oct 27 2022, 6:34 PM
gerritbot added a comment.Oct 31 2022, 7:03 PM

Change 850251 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Remove action API endpoint from Phonos

https://gerrit.wikimedia.org/r/850251

dmaza mentioned this in rEPHN6d891d712c10: Remove action API endpoint from Phonos.Oct 31 2022, 7:06 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 31 2022, 7:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 31 2022, 8:00 PM
• JMcLeod_WMF closed this task as Resolved.Nov 3 2022, 5:33 PM
• JMcLeod_WMF set the point value for this task to 1.
• JMcLeod_WMF added a project: Community-Tech (CommTech-Sprint-35).
• JMcLeod_WMF moved this task from Ready 🎬 to Done 🏁 on the Community-Tech (CommTech-Sprint-35) board.Nov 3 2022, 5:36 PM
gerritbot added a comment.Nov 15 2022, 1:42 PM

Change 856979 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[translatewiki@master] Phonos API files were removed

https://gerrit.wikimedia.org/r/856979

gerritbot added a project: Patch-For-Review.Nov 15 2022, 1:42 PM
Nikerabbit subscribed.Nov 15 2022, 1:43 PM

Once the above patch is merged, https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Phonos/+/afed21cfe0d93eb6cab981eea775f698115d0e0d/i18n/api can be deleted.

gerritbot added a comment.Nov 15 2022, 2:34 PM

Change 856979 merged by jenkins-bot:

[translatewiki@master] Phonos API files were removed

https://gerrit.wikimedia.org/r/856979

Maintenance_bot removed a project: Patch-For-Review.Nov 15 2022, 3:30 PM
Aklapper added a comment.Dec 9 2022, 9:40 PM
In T321083#8395950, @Nikerabbit wrote:

Once the above patch is merged, https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Phonos/+/afed21cfe0d93eb6cab981eea775f698115d0e0d/i18n/api can be deleted.

That seems to be the case now; https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Phonos/+/refs/heads/master/i18n/api/ still exists.

Should that be a separate task? Or should this task be reopened?

Restricted Application edited projects, added Community-Tech; removed Community-Tech (CommTech-Sprint-35). · View Herald TranscriptDec 9 2022, 9:40 PM
Aklapper mentioned this in T332905: Delete /i18n/api/.Mar 23 2023, 3:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits