Page MenuHomePhabricator

Codesearch: "excludeFilePath" option should be preserved when switching
Closed, ResolvedPublicBUG REPORT

Description

In the new version of the tool, the search query, file path and ignore checkbox are preserved when switching to another search type (e.g. "Everything" to "MediaWiki core") but the options exclude list and, repo list (still) aren't. The repo list is arguably not that useful, but the exclude list should be preserved.

The URL parameter for the file path field is called excludeFilePath so this is probably just a copy-paste error.

Event Timeline

Krinkle renamed this task from Codesearch Beta: some options are not preserved when switching to Codesearch: "excludeFilePath" option should be preserved when switching.Apr 24 2023, 4:06 AM
Krinkle added a project: patch-welcome.
Krinkle updated the task description. (Show Details)

Change 1011214 had a related patch set uploaded (by Krinkle; author: Krinkle):

[labs/codesearch@master] frontend: Fix excludeFiles mismatch between form read and URL write

https://gerrit.wikimedia.org/r/1011214

Krinkle triaged this task as Medium priority.

Change 1011214 merged by jenkins-bot:

[labs/codesearch@master] frontend: Fix excludeFiles mismatch between form read and URL write

https://gerrit.wikimedia.org/r/1011214