Page MenuHomePhabricator
Create Task
Maniphest T321563

Fix search result margin on mobile view
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
matthiasmullie
Authored By
SimoneThisDot
Oct 25 2022, 2:04 PM
Tags
Referenced Files
F35703712: Screen Shot 2022-11-03 at 11.23.35 AM.png
Nov 3 2022, 6:25 PM
F35703666: Screenshot_20221103-105424_Chrome.jpg
Nov 3 2022, 6:25 PM
F35703694: Screen Shot 2022-11-03 at 11.13.25 AM.png
Nov 3 2022, 6:25 PM
F35703660: Screenshot_20221103-105830_Chrome.jpg
Nov 3 2022, 6:25 PM
F35625246: image.png
Oct 25 2022, 2:04 PM
Subscribers
Aklapper
Etonkovidova
SimoneThisDot

Description

Steps to replicate the issue (include links if applicable):

  • Open up on mobile
  • Search something

What happens?:

  • the search result is not left aligned

What should have happened instead?:

  • the result should have 16px on both sides no more than that

image.png (366×287 px, 35 KB)

Details

SubjectRepoBranchLines +/-
Override padding-left for Special:Search resultsmediawiki/skins/MinervaNeuemaster+6 -0
Customize query in gerrit

Event Timeline

SimoneThisDot created this task.Oct 25 2022, 2:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2022, 2:04 PM
gerritbot added a comment.Oct 25 2022, 2:15 PM

Change 849103 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/skins/MinervaNeue@master] Override padding-left for Special:Search results

https://gerrit.wikimedia.org/r/849103

gerritbot added a project: Patch-For-Review.Oct 25 2022, 2:15 PM
matthiasmullie claimed this task.Oct 25 2022, 2:18 PM
matthiasmullie moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
CBogen added a project: SDAW-Search-Improvements.Oct 25 2022, 2:30 PM
gerritbot added a comment.Oct 25 2022, 6:31 PM

Change 849103 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Override padding-left for Special:Search results

https://gerrit.wikimedia.org/r/849103

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 25 2022, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 25 2022, 7:30 PM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 27 2022, 12:48 PM
Etonkovidova closed this task as Resolved.Nov 3 2022, 6:25 PM
Etonkovidova subscribed.

Checked in wmf.8

before the fix - enwiki wmf.7enwiki wmf.8
Screenshot_20221103-105830_Chrome.jpg (2×1 px, 361 KB)
Screen Shot 2022-11-03 at 11.13.25 AM.png (1×742 px, 162 KB)

RTL

before the fix - arwiki wmf.7arwiki wmf.8
Screenshot_20221103-105424_Chrome.jpg (2×1 px, 351 KB)
Screen Shot 2022-11-03 at 11.23.35 AM.png (1×738 px, 162 KB)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits