Page MenuHomePhabricator

[M] [mobile] Immediately add padding-right on the search result searchPreview extension load
Closed, ResolvedPublic

Description

As an user, I would like to reduce the layout shift that is currently happening on the search results when the extension loads and the arrow is added on mobile view. To do so, we can apply the following:

AC:

  • Read the URL and the config directly on the server side to define if the extension has to be loaded or not
  • Remove the JS code that currently does this
  • Add a new stylesheet to be loaded Just on Mobile (using the target parameter) - The existing stylesheet need to be loaded with JS otherwise the arrows will show before the client can interact with them
  • Add the padding-right in the above created stylesheet

Event Timeline

CBogen renamed this task from Immediately add padding-right on the search result searchPreview extension load to [M] [mobile] Immediately add padding-right on the search result searchPreview extension load.Nov 2 2022, 5:00 PM

Change 862844 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Immediately add padding-right when searchPreview extension load

https://gerrit.wikimedia.org/r/862844

Change 862844 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Immediately add padding-right when searchPreview extension load

https://gerrit.wikimedia.org/r/862844

Etonkovidova subscribed.

Checked on betalabs mobile - no issues were found; needs to be verified after deployment.

Etonkovidova updated the task description. (Show Details)