Page MenuHomePhabricator
Create Task
Maniphest T322207

Get npm tests running for upgraded kartotherian
Closed, ResolvedPublic
Actions

Description

This is in the context of work to upgrade kartotherian to new major versions of its infrastructure.

Some of the points might end up being large enough to become their own subtasks.

  • Fix kartodock make npm_test so that it shows output and runs all the tests (failing or not).
  • Get CI to run our upgraded packages, by updating the image and OS packages in .pipeline/blubber.yaml
  • We're seeing concerning errors which seem to be short-circuiting tests, related to an ICU incompatibility. If these are real errors, they should be crashing the test with a failure rather than a success. What's happening here?
    • libboost needed a hint about where to find the ICU data file...
  • Make the tests pass, being sure that they are really calling the code.
  • Fix tests in CI

Details

SubjectRepoBranchLines +/-
Workaround: hint at ICU datafile locationmediawiki/services/kartotherianmaster+3 -1
Workaround: hint at ICU datafile locationmediawiki/services/kartotherianmapnik-3.1+3 -0
Upgrade blubber description to node-16 and libmapnik-3.1mediawiki/services/kartotherianmapnik-3.1+5 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Nov 2 2022, 12:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2022, 12:43 PM
lilients_WMDE moved this task from Backlog to In sprint on the WMDE-GeoInfo-FocusArea board.Nov 3 2022, 1:26 PM
awight claimed this task.Nov 3 2022, 2:24 PM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-10-26 board.
gerritbot added a comment.Nov 3 2022, 3:32 PM

Change 852913 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/services/kartotherian@mapnik-3.1] Upgrade blubber description to node-16 and libmapnik-3.1

https://gerrit.wikimedia.org/r/852913

gerritbot added a project: Patch-For-Review.Nov 3 2022, 3:32 PM
awight updated the task description. (Show Details)Nov 3 2022, 4:09 PM
awight updated the task description. (Show Details)
gerritbot added a comment.Nov 3 2022, 4:24 PM

Change 852913 merged by WMDE-Fisch:

[mediawiki/services/kartotherian@mapnik-3.1] Upgrade blubber description to node-16 and libmapnik-3.1

https://gerrit.wikimedia.org/r/852913

awight mentioned this in rMSKA5418f2966f99: Upgrade blubber description to node-16 and libmapnik-3.1.Nov 3 2022, 4:24 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 3 2022, 4:30 PM
awight updated the task description. (Show Details)Nov 3 2022, 4:37 PM
gerritbot added a comment.Nov 3 2022, 4:41 PM

Change 852956 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/services/kartotherian@mapnik-3.1] Workaround: hint at ICU datafile location

https://gerrit.wikimedia.org/r/852956

gerritbot added a project: Patch-For-Review.Nov 3 2022, 4:41 PM
gerritbot added a comment.Nov 3 2022, 5:03 PM

Change 852956 merged by jenkins-bot:

[mediawiki/services/kartotherian@mapnik-3.1] Workaround: hint at ICU datafile location

https://gerrit.wikimedia.org/r/852956

awight mentioned this in rMSKA9dd04619bd73: Workaround: hint at ICU datafile location.Nov 3 2022, 5:03 PM
awight closed this task as Resolved.Nov 3 2022, 5:06 PM
awight removed awight as the assignee of this task.
awight claimed this task.
awight updated the task description. (Show Details)
awight moved this task from Doing to Done on the WMDE-TechWish-Sprint-2022-10-26 board.
Maintenance_bot removed a project: Patch-For-Review.Nov 3 2022, 5:30 PM
gerritbot added a comment.Jan 12 2023, 11:11 AM

Change 879410 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/services/kartotherian@master] Workaround: hint at ICU datafile location

https://gerrit.wikimedia.org/r/879410

gerritbot added a project: Patch-For-Review.Jan 12 2023, 11:11 AM
gerritbot added a comment.Jan 12 2023, 11:38 AM

Change 879410 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Workaround: hint at ICU datafile location

https://gerrit.wikimedia.org/r/879410

thiemowmde mentioned this in rMSKA95d667cfba65: Workaround: hint at ICU datafile location.Jan 12 2023, 11:38 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 12 2023, 12:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits