Page MenuHomePhabricator

Global blocks should be displayed below local blocks
Open, Needs TriagePublicFeature

Description

Feature summary (what you would like to be able to do and where):
When editing a page while globally and locally blocked, global blocks should be displayed below local blocks.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
When users encounter a block, they generally read the first notice and follow the instructions. However, stewards do not generally have the ability to override local blocks. This means that a significant number of emails to stewards@ can not be solved by the stewards. However, they still add to the backlog of emails that require steward attention.

Benefits (why should this be implemented?):
By moving local blocks above global blocks, users will be more likely to seek help from the local projects that can actually solve their problems, instead of wasting steward time.

Event Timeline

AntiCompositeNumber renamed this task from Global blocks should be displayed below to Global blocks should be displayed below local blocks.Nov 15 2022, 3:37 AM
AntiCompositeNumber updated the task description. (Show Details)

After T322941, users should only see at most one block message.

After T322941, users should only see at most one block message.

T322941: Remove GlobalBlockingHooks::onGetUserPermissionsErrorsExpensive in favour of GlobalBlockingHooks::onGetUserBlock will stop the presentation of the duplicated global block message.

The case described here occurs when an IP is both locally and globally blocked — both block messages will still show (and this is desired behaviour afaik)

After T322941, users should only see at most one block message.

T322941: Remove GlobalBlockingHooks::onGetUserPermissionsErrorsExpensive in favour of GlobalBlockingHooks::onGetUserBlock will stop the presentation of the duplicated global block message.

The case described here occurs when an IP is both locally and globally blocked — both block messages will still show (and this is desired behaviour afaik)

My understanding is that after T322941 the local and global block messages will be combined into one composite block message.