Spacing between the collapsed ToC button and page title changes above 1000px
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	bwang
	Nov 15 2022, 10:28 PM

Description

Visual regression introduced by T320101. More context

Steps to replicate the issue (include links if applicable):

Go to https://en.wikipedia.beta.wmflabs.org/wiki/Polar_bear?useskin=vector-2022
Press "hide" to collapse the ToC into the page title.
Reduce viewport below 1000px and compare spacing between page title and ToC button

What happens?:
Total spacing between the ToC button icon and the page title changes from 10px to 17px below 1000px

What should have happened instead?:
The spacing between the ToC button icon and the page title should stay the same at 16px or 17px

Screenshots comparing change to master prior to deployment of visual enhancements feature flag:
https://phab.wmfusercontent.org/file/data/fxptotudlpxq4lygdeye/PHID-FILE-vjmqvm7lqtrr3aqoiano/preview-Screen_Shot_2022-11-09_at_4.22.15_PM.png
https://jmp.sh/Wh7Mecqr

Details

	Subject	Repo	Branch	Lines +/-
	Fix horizontal spacing for ToC button in the page titlebar when VisualEnhancementNext flag is enabled	mediawiki/skins/Vector	master	+14 -4

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T317884 [EPIC] Vector 2022 post-deployment work
Open		ovasileva	T317632 [EPIC] Visual refinements pt2
Resolved		Jdlrobson	T325064 [Category] Table of contents
Resolved	BUG REPORT	None	T323174 Spacing between the collapsed ToC button and page title changes above 1000px

Event Timeline

bwang created this task.Nov 15 2022, 10:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2022, 10:28 PM

bwang renamed this task from Spacing between the collapsed ToC button and page title changes above tablet viewports to Spacing between the collapsed ToC button and page title changes above 1000px.Nov 15 2022, 10:29 PM

Change 855101 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix horizontal spacing for ToC button in the page titlebar when VisualEnhancementNext flag is enabled

https://gerrit.wikimedia.org/r/855101

gerritbot added a project: Patch-For-Review.Nov 15 2022, 10:29 PM

bwang added a parent task: T322673: Test VectorVisualEnhancementsNext flag.Nov 15 2022, 10:57 PM

Jdlrobson moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.Nov 16 2022, 5:41 AM

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Nov 16 2022, 5:45 AM

ovasileva triaged this task as Low priority.Nov 16 2022, 9:25 PM

Jdlrobson mentioned this in T322673: Test VectorVisualEnhancementsNext flag.Nov 16 2022, 10:39 PM

ovasileva moved this task from Not ready to estimate to Current Fiscal Year on the Web-Team-Backlog board.Nov 17 2022, 3:32 PM

Jdlrobson edited parent tasks, added: T317632: [EPIC] Visual refinements pt2; removed: T322673: Test VectorVisualEnhancementsNext flag.Nov 23 2022, 4:06 PM

Change 855101 abandoned by Bernard Wang: