Page MenuHomePhabricator

importImages.php Internal Error
Closed, ResolvedPublic

Description

Author: gerard

Description:
When using the importImages.php script, this produces the following error and stack trace. This has happened on both wikis I've tried it on, with different extension sets, I've tried with using different relative dirs and I've checked permissions and chmod a thousand times.

Import Images

Importing Vehicle-BMW-M5-Taxi-VC.jpg...MediaWiki internal error.

Original exception: exception 'MWException' with message 'LocalFile: write operations are not supported' in /home/mods/public_html/includes/filerepo/File.php:1021
Stack trace:
#0 /home/mods/public_html/includes/filerepo/File.php(1036): File->readOnlyError()
#1 /home/mods/public_html/maintenance/importImages.php(244): File->recordUpload('20110813050120!...', 'Importing image...', '')
#2 {main}

Exception caught inside exception handler: exception 'MWException' with message 'FauxRequest::getRequestURL() not implemented' in /home/mods/public_html/includes/WebRequest.php:1108
Stack trace:
#0 /home/mods/public_html/includes/WebRequest.php(1137): FauxRequest->notImplemented('FauxRequest::ge...')
#1 /home/mods/public_html/includes/Exception.php(154): FauxRequest->getRequestURL()
#2 /home/mods/public_html/includes/Exception.php(213): MWException->getLogMessage()
#3 /home/mods/public_html/includes/Exception.php(422): MWException->report()
#4 /home/mods/public_html/includes/Exception.php(501): MWExceptionHandler::report(Object(MWException))
#5 [internal function]: MWExceptionHandler::handle(Object(MWException))
#6 {main}


Version: 1.20.x
Severity: major

Details

Reference
bz30355

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:50 PM
bzimport set Reference to bz30355.
bzimport added a subscriber: Unknown Object (MLST).

Which version of Mediawiki are you using?

gerard wrote:

(In reply to comment #1)

Which version of Mediawiki are you using?

1.19-svn

importImages.php explicitly calls $image->recordUpload -- this method on File is a stub, which is listed as being overridden in LocalFile .... BUT IS NOT in 1.19-svn.

There *is* a recordUpload2 method on LocalFile, but no RecordUpload.

I'm guessing somebody refactored things and didn't fix them all?

r87584 appears to be the culprit, removed LocalFile::recordUpload().

Confirmed r94543 fixes this on trunk; merged to REL1_18 as r94585.