This method is old, complex, and confusing. It is also called by pendingWriteQueryDuration(), via TransactionProfiler, which might trigger the ping query...which seems overly complex and needlessly prone to degenerate situations during errors.
$lastRoundTripEstimate should be set via open() and have a method to just plainly return the value. Alternately, pendingWriteQueryDuration() could just not have $type (e.g. ESTIMATE_TOTAL).
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| rdbms: remove $rtt parameter from Database::ping() | mediawiki/core | master | +32 -31 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Ladsgroup | T299691 Break down monster class: Database | |||
| Resolved | aaron | T323663 Simplify Database::ping() and avoid calling it from pendingWriteQueryDuration() |
Change 859651 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):
[mediawiki/core@master] rdbms: remove $rtt parameter from Database::ping()
Change 859651 merged by jenkins-bot:
[mediawiki/core@master] rdbms: remove $rtt parameter from Database::ping()