Page MenuHomePhabricator

[webservice] Allow configuring the image registry used to pull
Closed, ResolvedPublic3 Estimated Story Points

Description

Currently we hardcode the OCI repository to pull images from when running webservice start.

That will block us from being able to have different repositories in tools and toolsbeta.

This task is to make that setting configurable for the "buldiservice" webservice type, and create the puppet configuration
to configure both tools and toolsbeta.

A proposal for the config path is /etc/toolforge/webservice.yaml, and the configuration key buildservice_repository
of type string.

Note that the configuration path itself should be hardcoded to avoid users from being able to change the OCI repository
to pull images from.

Event Timeline

dcaro triaged this task as High priority.Nov 23 2022, 11:07 AM
dcaro created this task.
dcaro added a project: Toolforge Build Service.

Investigate also if webservice is being used from within pods, if so we will need to make the file available in them (through a mount or similar).

If so, then open a subtask for it and add a default value of "harbor.toolsbeta.wmflabs.org"

Change 867910 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[operations/software/tools-webservice@master] tools-webservice: read DEFAULT_BUILD_SERVICE_REGISTRY from config

https://gerrit.wikimedia.org/r/867910

Change 867911 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[operations/puppet@production] tools-webservice: create /etc/toolforge/webservice.yaml with puppet

https://gerrit.wikimedia.org/r/867911

Change 867911 merged by David Caro:

[operations/puppet@production] tools-webservice: create /etc/toolforge/webservice.yaml with puppet

https://gerrit.wikimedia.org/r/867911

dcaro changed the task status from Open to In Progress.Dec 20 2022, 2:18 PM

Change 867910 merged by jenkins-bot:

[operations/software/tools-webservice@master] tools-webservice: read buildservice_repository from webservice.yaml config file

https://gerrit.wikimedia.org/r/867910