Make DonationInterface compatible with MediaWiki 1.39
Closed, ResolvedPublic4 Estimated Story Points
Actions

Assigned To

Authored By

	Ejegg
	Nov 30 2022, 9:12 PM

Description

New LTS is available, let's get DonationInterface ready for it

Details

Subject	Repo	Branch	Lines +/-
Handle new namespace for RemexHtml	mediawiki/extensions/DonationInterface	master	+17 -7
Updates to paymentswiki LocalSettings for MW 1.39	wikimedia/fundraising/dev	master	+6 -10
Update composer.json for payments-wiki	mediawiki/core	fundraising/REL1_39	+9 K -3
Add extensions used on payments-wiki	mediawiki/core	fundraising/REL1_39	+15 -0
Add logos used on payments-wiki	mediawiki/core	fundraising/REL1_39	+0 -0
Remove extensions and skins not used on payments-wiki	mediawiki/core	fundraising/REL1_39	+0 -140

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ejegg	T324154 Make DonationInterface compatible with MediaWiki 1.39
		Resolved		Ejegg	T326372 Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4

Event Timeline

Ejegg created this task.Nov 30 2022, 9:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2022, 9:12 PM

XenoRyet moved this task from Triage to Sprint +2 on the Fundraising-Backlog board.Dec 12 2022, 8:53 PM

Dwisehaupt set the point value for this task to 4.Dec 12 2022, 9:40 PM

XenoRyet moved this task from Sprint +2 to Sprint +1 on the Fundraising-Backlog board.Dec 19 2022, 8:43 PM

XenoRyet moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Jan 3 2023, 8:35 PM

XenoRyet added a project: Fundraising Sprint Amazing grep.Jan 3 2023, 8:53 PM

Change 875983 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/core@fundraising/REL1_39] Remove extensions and skins not used on payments-wiki

https://gerrit.wikimedia.org/r/875983

gerritbot added a project: Patch-For-Review.Jan 5 2023, 5:56 PM

Change 875988 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/core@fundraising/REL1_39] Add logos used on payments-wiki

https://gerrit.wikimedia.org/r/875988

Change 875989 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/core@fundraising/REL1_39] Add extensions used on payments-wiki

https://gerrit.wikimedia.org/r/875989

Change 875991 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/core@fundraising/REL1_39] Update composer.json for payments-wiki

https://gerrit.wikimedia.org/r/875991

Ejegg claimed this task.Jan 5 2023, 6:31 PM

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Amazing grep board.

Change 876007 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Handle new namespace for RemexHtml

https://gerrit.wikimedia.org/r/876007

Change 876014 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/dev@master] Updates to paymentswiki LocalSettings for MW 1.39

https://gerrit.wikimedia.org/r/876014

Ejegg moved this task from Doing to Ready for Review on the Fundraising Sprint Amazing grep board.Jan 5 2023, 10:51 PM

The upgrade seems remarkably easy this time around!

To test:

pull down this localsettings patch in fundraising-dev base dir (should be back-compatible with MW1.35, so safe to merge now): https://gerrit.wikimedia.org/r/c/876014/
pull down end of this patch chain in src/payments dir: https://gerrit.wikimedia.org/r/c/875991/
pull down this patch in src/payments/extensions/DonationInterface (back-compatible with MW1.35, so safe to merge now): https://gerrit.wikimedia.org/r/c/876007
under the payments container, run composer install in /var/www/html
run tests and click around on the payments forms!

Note that we still need to get the CI tests updated to run a different suite on the fundraising/REL1_39 branch. That core patch is failing now because it is running the php7.3 suite and MW 1.39 needs at least php7.4.

Oh hey, we will need to finish T315585 before we can deploy this.

jgleeson moved this task from Ready for Review to Being Reviewed on the Fundraising Sprint Amazing grep board.Jan 6 2023, 2:01 PM

Copying the email reply here. Annoyingly when pasting from Gmail to Phabricator, it lost all the formatting so I've been lazy and copied it as an image.