Page MenuHomePhabricator
Create Task
Maniphest T324583

💥️ Consider moving DataValueValidator out of the Validation namespace
Closed, ResolvedPublic
Actions

Description

Using the DataValueValidator inside the PropertyValuePairDeserializer creates an interdependency between the two namespaces. This is bad.

Details

SubjectRepoBranchLines +/-
REST: Fix namespace interdependencymediawiki/extensions/Wikibasemaster+402 -266
REST: Solution 2 - move DataValueValidator interfacemediawiki/extensions/Wikibasemaster+28 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ollie.Shotton_WMDE created this task.Dec 6 2022, 4:11 PM
Ollie.Shotton_WMDE claimed this task.Dec 21 2022, 3:00 PM
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 19) board.
gerritbot added a comment.Dec 21 2022, 5:44 PM

Change 870661 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Solution 1 - new deserializer

https://gerrit.wikimedia.org/r/870661

gerritbot added a project: Patch-For-Review.Dec 21 2022, 5:44 PM
gerritbot added a comment.Dec 22 2022, 11:11 AM

Change 870821 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Solution 2 - move DataValueValidator interface

https://gerrit.wikimedia.org/r/870821

gerritbot added a comment.Dec 22 2022, 5:19 PM

Change 870821 abandoned by Ollie Shotton:

[mediawiki/extensions/Wikibase@master] REST: Solution 2 - move DataValueValidator interface

Reason:

in favour of Id7021f827a9a49924eae3c6ded11be1e878fc3c3

https://gerrit.wikimedia.org/r/870821

Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 19) board.Dec 22 2022, 5:20 PM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 20); removed Wikibase Product Platform (v1) (Sprint 19).Jan 3 2023, 11:14 AM
WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 20) board.
Ollie.Shotton_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform (v1) (Sprint 20) board.Jan 10 2023, 10:53 AM
Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 20) board.Jan 10 2023, 12:38 PM
gerritbot added a comment.Jan 10 2023, 1:27 PM

Change 870661 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Fix namespace interdependency

https://gerrit.wikimedia.org/r/870661

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 10 2023, 2:00 PM
Ollie.Shotton_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 20) board.Jan 10 2023, 3:07 PM
Ollie.Shotton_WMDE removed a project: Patch-For-Review.Jan 10 2023, 7:26 PM
WMDE-leszek closed this task as Resolved.Jan 30 2023, 8:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits