Page MenuHomePhabricator

Deprecated: Creation of dynamic property TransformTooBigImageAreaError::$tempFSFileReferences is deprecated in TempFSFile.php on line 135
Closed, ResolvedPublic

Description

Deprecated: Creation of dynamic property TransformTooBigImageAreaError::$tempFSFileReferences is deprecated in /var/www/wiki/mediawiki/core/includes/libs/filebackend/fsfile/TempFSFile.php on line 135

Event Timeline

This is part of TempFSFile::bind and the property is created on any object the function is called with.

It seems it is used to track a reference between the temp file and the object to get the garbage collector into work when the object is no longer used and to remove the temp file.

But it seems hard to find the explicit or implicit caller of the bind.

Change 888316 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/core@master] TempFSFile: Use a WeakMap for reference tracking if available

https://gerrit.wikimedia.org/r/888316

Change 888316 merged by jenkins-bot:

[mediawiki/core@master] TempFSFile: Use a WeakMap for reference tracking if available

https://gerrit.wikimedia.org/r/888316

Change 890852 had a related patch set uploaded (by Reedy; author: TK-999):

[mediawiki/core@REL1_39] TempFSFile: Use a WeakMap for reference tracking if available

https://gerrit.wikimedia.org/r/890852

Reedy assigned this task to TK-999.

Yay, my dev wiki homepage is no longer full of logspam!

Change 890852 merged by jenkins-bot:

[mediawiki/core@REL1_39] TempFSFile: Use a WeakMap for reference tracking if available

https://gerrit.wikimedia.org/r/890852