tbs: user-story 12: Add pre-commit to the buildservice repo
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Slst2020

Authored By

	dcaro
	Dec 14 2022, 3:38 PM

Description

https://github.com/toolforge/buildservice/

Suggestion of things that it can check (suggestions of the specific hook, but check that it's good before using it):

shellcheck - https://github.com/shellcheck-py/shellcheck-py
check-yaml - https://github.com/pre-commit/pre-commit-hooks
trailing-whitespace - https://github.com/pre-commit/pre-commit-hooks
check-merge-conflict - https://github.com/pre-commit/pre-commit-hooks
check-shebang-scripts-are-executable - https://github.com/pre-commit/pre-commit-hooks
check-executables-have-shebangs - https://github.com/pre-commit/pre-commit-hooks
markdownlint - https://github.com/markdownlint/markdownlint

Related Objects
Search...

Status	Assigned	Task
Resolved	LucasWerkmeister	T320140 Migrate wd-shex-infer from Toolforge GridEngine to Toolforge Kubernetes
Resolved	matmarex	T319707 Migrate dtcheck from Toolforge GridEngine to Toolforge Kubernetes
Resolved	Legoktm	T320062 Migrate steve-adder from Toolforge GridEngine to Toolforge Kubernetes
Resolved	Legoktm	T320011 Migrate rfa-voting-history from Toolforge GridEngine to Toolforge Kubernetes
Open	dcaro	T194332 [Epic,builds-api,components-api,webservice,jobs-api] Make Toolforge a proper platform as a service with push-to-deploy and build packs
Resolved	dcaro	T267374 [tbs.beta] Create a toolforge build service beta release
Resolved	dcaro	T325180 tbs: user-story 12: I want to easily run the tests for each of the codebases
Resolved	Slst2020	T325183 tbs: user-story 12: Add pre-commit to the buildservice repo

Event Timeline

dcaro triaged this task as High priority.Dec 14 2022, 3:38 PM

dcaro created this task.

dcaro added a project: Toolforge Build Service.Dec 14 2022, 3:57 PM

KHernandez-WMF mentioned this in T325180: tbs: user-story 12: I want to easily run the tests for each of the codebases.Dec 19 2022, 11:54 PM

KHernandez-WMF moved this task from Backlog to To be Discussed on the Toolforge Build Service board.Dec 20 2022, 2:17 PM

KHernandez-WMF moved this task from To be Discussed to Iteration 07 on the Toolforge Build Service board.Dec 20 2022, 5:08 PM

KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 07); removed Toolforge Build Service.

KHernandez-WMF moved this task from Iteration 07 to Iteration 08 on the Toolforge Build Service board.Jan 10 2023, 6:24 PM

KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 08); removed Toolforge Build Service (Iteration 07).

KHernandez-WMF set the point value for this task to 2.Jan 10 2023, 6:36 PM

Slst2020 updated the task description. (Show Details)Jan 16 2023, 10:10 AM

Slst2020 claimed this task.Jan 17 2023, 7:46 PM

Slst2020 moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 08) board.

fnegri edited projects, added cloud-services-team; removed cloud-services-team (Kanban).Jan 18 2023, 6:25 PM

fnegri moved this task from Kanban to Inbox on the cloud-services-team board.

Slst2020 changed the task status from Open to In Progress.Jan 19 2023, 2:49 PM

I'll add some python hooks as well – we have a few py scripts in there.

check-shebang-scripts-are-executable - https://github.com/pre-commit/pre-commit-hooks

I can't for the life of me make this hook work without giving both false negatives and false positives. Don't think it's worth spending more time on it for now. I've commented it out in case we want to revisit.

PR: https://github.com/toolforge/buildservice/pull/16

Slst2020 changed the task status from In Progress to Open.Jan 20 2023, 10:39 AM

Slst2020 moved this task from In Progress to In Review on the Toolforge Build Service (Iteration 08) board.

KHernandez-WMF moved this task from Iteration 08 to Iteration 09 on the Toolforge Build Service board.Jan 24 2023, 6:09 PM

KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 09); removed Toolforge Build Service (Iteration 08).

KHernandez-WMF moved this task from Next Up to In Review on the Toolforge Build Service (Iteration 09) board.

KHernandez-WMF moved this task from Iteration 09 to Iteration 10 on the Toolforge Build Service board.Feb 7 2023, 4:38 PM

KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 10); removed Toolforge Build Service (Iteration 09).

KHernandez-WMF moved this task from Next Up to In Review on the Toolforge Build Service (Iteration 10) board.

dcaro closed this task as Resolved.Feb 15 2023, 5:46 PM

dcaro moved this task from In Review to Done on the Toolforge Build Service (Iteration 10) board.