Page MenuHomePhabricator

tbs: user-story 12: Add pre-commit to the buildpack-admission-controller repo
Closed, ResolvedPublic2 Estimated Story Points

Description

https://github.com/toolforge/buildpack-admission-controller

Suggestion of things that it can check (suggestions of the specific hook, but check that it's good before using it):

Event Timeline

dcaro triaged this task as High priority.Dec 14 2022, 3:42 PM
dcaro created this task.

It seems like hadolint hook for pre-commit has been deprecated. see https://pre-commit.com/hooks.html

also what do you think about adding go-fmt to the go pre-commit hooks? @dcaro @Slst2020

go-fmt is for formatting go-lang code

also what do you think about adding go-fmt to the go pre-commit hooks? @dcaro @Slst2020

go-fmt is for formatting go-lang code

Ahh, I missed this comment earlier – sorry! Yes to go-fmt. How about we add go-vet as well?

Just added both couple of minutes ago

@Raymond_Ndibe When I reviewed the PR, I forgot to actually check if the pre-commit hooks pass. I did that now (pre-commit run --all-files), and saw some of them are failing and need fixing.

@Raymond_Ndibe When I reviewed the PR, I forgot to actually check if the pre-commit hooks pass. I did that now (pre-commit run --all-files), and saw some of them are failing and need fixing.

returning back to this I just submitted a patch addressing this. review when you can, here is the patch https://github.com/toolforge/buildpack-admission-controller/pull/22