Page MenuHomePhabricator

Consistently call phpunit functions in PageTriage
Closed, ResolvedPublic2 Estimated Story Points

Description

$this->assertEquals(), self::assertEquals() and static::assertEquals() all seem to be used in PageTriage... Same for various other PHPUnit functions too.

These should at least be consistent inside the repo...

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
HouseBlaster renamed this task from Consistenly call phpunit functions to Consistenly call phpunit functions in PageTriage.Dec 25 2022, 7:11 PM
Samwalton9-WMF renamed this task from Consistenly call phpunit functions in PageTriage to Consistently call phpunit functions in PageTriage.Jan 23 2023, 3:09 PM
Samwalton9-WMF set the point value for this task to 3.
Samwalton9-WMF changed the point value for this task from 3 to 2.
Scardenasmolinar changed the task status from Open to In Progress.Jun 29 2023, 2:49 PM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change 934431 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Change self::assert* and static::assert* to $this->assert*

https://gerrit.wikimedia.org/r/934431

Change 934431 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Change self::assert* and static::assert* to $this->assert*

https://gerrit.wikimedia.org/r/934431