Page MenuHomePhabricator

Thank action fails with "Revision ID is not valid" on RecentChanges
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

The thank action gets added to RecentChanges where no revision id is present and fails. (E.g. User creation log entries, page protection, etc)
We currently don't accept "log type" entries in PagerTool and even if we did, we'd need to change the onHistoryTool hook or create a new one to handle them.

Side-note: There is onLogEventsListLineEnding which seems to handle all the different "thank" cases we need

Expected behavior

  • If thank action is present it should not fail.
  • Recent changes entry types that can be thanked should match those in Special:Log/Watchlist/Contributions/etc

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dmaza changed the subtype of this task from "Task" to "Bug Report".Dec 21 2022, 4:02 PM

Change 870638 had a related patch set uploaded (by Dmaza; author: Dmaza):

[mediawiki/extensions/Thanks@master] Thank: Fix thank action with no revision id

https://gerrit.wikimedia.org/r/870638

Change 870638 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] Thank: Fix thank action with no revision id

https://gerrit.wikimedia.org/r/870638

Change 870738 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] Fix history pager tools

https://gerrit.wikimedia.org/r/870738

Change 870738 merged by jenkins-bot:

[mediawiki/core@master] Fix history pager tools

https://gerrit.wikimedia.org/r/870738

@dmaza I did two actions regarding the revision id is not valid. I created another account as seen in the first screenshot for username, Testthanks. In the 2nd and 3rd screenshots, it appears in Special:Log and Special:RecentChanges but has no option to thank them. The 4th screenshot, you are able to thank if you have an edit in Special:Watchlist. The whole account creation does not even appear at all in Special:Contributions as seen in the 5th screenshot.

When I did a Move for an article, Special:Contributions and Special:Log, you are able to thank them but not in Special:RecentChanges

OS: Mac 13.0
Browser: Chrome and Safari
Environment: Beta

New account created

T325753_Thanks_Revision ID is not valid.png (324×1 px, 49 KB)

Special:Log- no thank option

T325753_Thanks_Revision ID is not valid_Special_Log.png (912×1 px, 191 KB)

Special:RecentChanges- no thank option

T325753_Thanks_Revision ID is not valid_Special_RecentChanges.png (694×1 px, 219 KB)

Special:Watchlist- thank option available
{F36003032}

Special:Contributions- account creation does not appear

T325753_Thanks_Revision ID is not valid_Special_Contributions.png (344×1 px, 119 KB)

@MusikAnimal In creating a new account and trying to see if the thanks option is available with no revision ID.

  • In Special:Log acknowledges the account being created but does not have an option to thank them, as seen in the first screenshot.
  • Also in Special:Contributions, it does not acknowledge the account creation at all, as in the 2nd screenshot?

Is that fine still?

Special:Log

T325753_Thanks_Revision ID is not valid_Special_Log2.png (1×1 px, 392 KB)

Special:Contributions

T325753_Thanks_Revision ID is not valid_Special_Contributions2.png (324×1 px, 104 KB)

After talking with @MusikAnimal, account creation is not an action that can be thanked on.

Log: Account Creation
Special:Log- entry is visible but no thanks option
Special:RecentChanges- entry is visible but no thanks option
Special:Contributions- entry is not visible but as expected

Log: Move
Special:Log- entry is visible and has thanks option
Special:RecentChanges- entry is visible but no thanks option
Special:Contributions- entry is visible and has thanks option

Special:Watchlist- With any edit, you have a thanks option
Special:RecentChanges- entry is visible but no thanks option for move, protect, account creation, delete, undelete. Mostly only edits, you would only be able to give out thanks for Special:RecentChanges.

reviewed it with @dmaza and moving it to prod sign-off

dmaza set the point value for this task to 2.Jan 16 2023, 6:26 PM