Page MenuHomePhabricator

Update Thumbor documentation and repository
Closed, ResolvedPublic

Description

The ticket will be resolved if the following items are done:
  • Update README.md according to the current state of the project
  • Review the Makefile and update the current commands if necessary.
  • Update the docker-compose.yaml file according to the new working flow of the dev project version.
  • Check or update tox.ini, .flake8, .arclint, .arcconfig, pytest.ini, setup.py files if necessary.
  • Update data in Wikitech

Event Timeline

Hi, could you provide some more context please? (Latest changes of what / where exactly?) Thanks for elaborating a bit and helping understand what's going on! :)

Change 876229 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[operations/software/thumbor-plugins@master] WIP: Update Thumbor repository according to the latest changes

https://gerrit.wikimedia.org/r/876229

Hello @greg
I saw you were the author of the change that introduced Arcanist into the thumbor-plugins project.
As I noticed Arcanist hasn't been actively used since 2019. Now, all the code review process is on Gerrit. Shall we need to support .arcconfig, .arclint in the project since it isn't used? Or is it the strict rule to have and maintain it in the repo?
@hnowlan maybe you have some ideas about it.
Please feel free to share your thoughts.

Arcanist can be removed. That change was merged 6.5y ago and plans were different at that time (move from Gerrit to Phab Differential instead of GitLab).

Arcanist can be removed. That change was merged 6.5y ago and plans were different at that time (move from Gerrit to Phab Differential instead of GitLab).

Thank you for your input.

different at that time (move from Gerrit to Phab Differential instead of GitLab).

As I understood from the Avoiding arcanist paragraph, also this repo should be deleted from Phabricator Diffusion in terms of this process. Am I right?

We mirror (as in "read-only") repositories from Gerrit (and to some extent Github) to Phabricator Diffusion (code hosting), so should be fine to keep.
(For completeness, Phabricator Differential (code review) is not used by this repo, per T191182.)

dima.batt renamed this task from Update Thumbor repository according to the latest changes to Update Thumbor documentation and repository .Jan 12 2023, 12:14 PM
dima.batt updated the task description. (Show Details)
dima.batt updated the task description. (Show Details)

Change 876229 merged by jenkins-bot:

[operations/software/thumbor-plugins@master] Update Thumbor repository according to the latest changes

https://gerrit.wikimedia.org/r/876229

Change 881909 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[operations/software/thumbor-plugins@master] Add a wider list of thumbor local configs

https://gerrit.wikimedia.org/r/881909

Change 881909 merged by jenkins-bot:

[operations/software/thumbor-plugins@master] Add a longer list of thumbor local configs and fix make online-test command

https://gerrit.wikimedia.org/r/881909

FJoseph-WMF added a subscriber: Atieno.