Page MenuHomePhabricator
Create Task
Maniphest T326274

Reduce complexity of LB and LBF (introducing IConnectionProvider)
Closed, ResolvedPublic
Actions

Description

This is to track this quarter's OKR on removign at least 10% complexity score of these two classes. They are overly large without apparent benefit.

Internal clean ups: Remove unused code, Remove functions that bring no actual value, simplify the logic in data attributes. DRY the code, etc.

Work:

Details

SubjectRepoBranchLines +/-
Stop using LoadBalancer::getConnectionRef() so it can be hard-deprecatedmediawiki/coremaster+73 -95
rdbms: Hard-deprecate LoadBalancer::getConnectionRef()mediawiki/coremaster+20 -16
rdbms: Update outdated docs around deprecated reuseConnection()mediawiki/coremaster+17 -15
Remove call to LoadBalancer::reuseConnection()mediawiki/extensions/EntitySchemamaster+0 -2
Remove call to LoadBalancer::reuseConnection()mediawiki/extensions/PropertySuggestermaster+0 -4
Remove call to LoadBalancer::reuseConnection()mediawiki/extensions/SecurePollmaster+0 -4
Remove call to LoadBalancer::reuseConnection()mediawiki/extensions/WikimediaMaintenancemaster+0 -6
rdbms: Remove getLaggedReplicaMode() in favour of laggedReplicaUsed()mediawiki/coremaster+9 -19
tests: Remove DummyServicesTrait::getDummyDBLoadBalancermediawiki/coremaster+0 -9
rdbms: Move two methods from ILB to ILBForOwnermediawiki/coremaster+19 -19
rdbms: Roll up once-used small private/protected methods to the callermediawiki/coremaster+40 -95
rdbms: Remove or move unused public methods of ILB/ILBFmediawiki/coremaster+94 -182
rdbms: Move two static methods of LBFactory to ChronologyProtectormediawiki/coremaster+118 -119
rdbms: Remove LB::getReplicaResumePosmediawiki/coremaster+12 -50
rdbms: Use more narrow IReadableDatabase in SelectQueryBuildermediawiki/coremaster+48 -49
rdbms: Delegate Database object creation to DatabaseFactory out of LBmediawiki/coremaster+66 -97
rdbms: Make IConnectionProvider stablemediawiki/coremaster+0 -1
rdbms: Simplify $options argument in commitPrimaryChanges and moremediawiki/coremaster+17 -22
rdbms: Introduce ServerInfoHolder to limit access to servers in LBmediawiki/coremaster+426 -175
rdbms: Drop LBF::$currentConfigmediawiki/coremaster+0 -7
rdbms: Switch LBFactory::getReplicaDatabase to narrow IReadableDatabasemediawiki/coremaster+19 -15
Use the new method of getting database objectmediawiki/extensions/DiscussionToolsmaster+24 -18
rdbms: Introduce IConnectionProvider and IReadableDatabasemediawiki/coremaster+806 -701
[DNM] rdbms: Add $externalCluster argument to IConnectionProvidermediawiki/coremaster+20 -6
Switch some simple use of LoadBalancer to use new LBFactory methodsmediawiki/coremaster+16 -16
rdbms: Move back ::query() from IReadableDatabase to IDatabasemediawiki/coremaster+53 -53
[WIP] rdbms: Introduce ConnectionTrackermediawiki/coremaster+183 -130
Remove obsolete Rdbms query groups from getConnection callsmediawiki/coremaster+21 -37
rdbms: Drop simple only-once-used private functionsmediawiki/coremaster+41 -93
rdbms: Drop LB::forEachOpenConnection and forEachOpenPrimaryConnectionmediawiki/coremaster+0 -31
lib: Drop use of forEachOpenPrimaryConnection in FakeLoadBalancermediawiki/extensions/Wikibasemaster+0 -4
rdbms: Make LoadBalancer::getServerConnection() privatemediawiki/coremaster+3 -23
rdbms: Drop ::commitAll from LB/LBFmediawiki/coremaster+5 -46
Stop using $lbf->commitAll()mediawiki/extensions/TimedMediaHandlermaster+6 -2
rdbms: Simplify how 'laggedReplicaMode' is setmediawiki/coremaster+9 -13
Start using maxWriteDuration argumentmediawiki/extensions/EventBusmaster+7 -2
Remove maxWriteDuration temporarymediawiki/extensions/EventBusmaster+2 -7
rdbms: Drop waitTimeout and maxLag from ctor params of LB/LBFmediawiki/coremaster+7 -23
Migrate DataModelBackendLBFactory to using laggedReplicaUsed()mediawiki/extensions/ArticleFeedbackv5master+1 -1
rdbms: Drop hard-deprecated and unused ILBFactory::forEachLB()mediawiki/coremaster+1 -40
rdbms: Drop optional parameter of ILBFactory::commitAll()mediawiki/coremaster+5 -5
rdbms: Drop optional parameters of ILoadBalancer::waitForPrimaryPos()mediawiki/coremaster+20 -25
rdbms: Drop unused parameter in LoadBalancermediawiki/coremaster+2 -3
rdbms: Drop LoadBalancer::getLazyConnectionRef()mediawiki/coremaster+1 -23
rdbms: Drop LoadBalancer::setLocalDomain()mediawiki/coremaster+4 -14
Remove MWEchoDBFactory::waitForReplicas()mediawiki/extensions/Echomaster+6 -55
rdbms: Drop getChronologyProtectorClientId in LBF and ILBFmediawiki/coremaster+3 -20
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jan 31 2023, 4:27 PM

Change 885379 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/TimedMediaHandler@master] Stop using $lbf->commitAll()

https://gerrit.wikimedia.org/r/885379

gerritbot added a project: Patch-For-Review.Jan 31 2023, 4:27 PM
gerritbot added a comment.Jan 31 2023, 11:33 PM

Change 885379 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Stop using $lbf->commitAll()

https://gerrit.wikimedia.org/r/885379

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Feb 1 2023, 12:01 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 1 2023, 12:30 AM
gerritbot added a comment.Feb 1 2023, 7:29 AM

Change 885622 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Drop ::commitAll from LB/LBF

https://gerrit.wikimedia.org/r/885622

gerritbot added a project: Patch-For-Review.Feb 1 2023, 7:29 AM
gerritbot added a comment.Feb 1 2023, 7:45 PM

Change 885622 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Drop ::commitAll from LB/LBF

https://gerrit.wikimedia.org/r/885622

Maintenance_bot removed a project: Patch-For-Review.Feb 1 2023, 8:31 PM
gerritbot added a comment.Feb 2 2023, 7:33 AM

Change 885946 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Make LoadBalancer::getServerConnection() private

https://gerrit.wikimedia.org/r/885946

gerritbot added a project: Patch-For-Review.Feb 2 2023, 7:33 AM
gerritbot added a comment.Feb 2 2023, 8:59 AM

Change 885987 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/Wikibase@master] lib: Drop use of forEachOpenPrimaryConnection in FakeLoadBalancer

https://gerrit.wikimedia.org/r/885987

gerritbot added a comment.Feb 2 2023, 8:59 AM

Change 885988 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Drop LB::forEachOpenConnection and forEachOpenPrimaryConnection

https://gerrit.wikimedia.org/r/885988

gerritbot added a comment.Feb 2 2023, 9:31 AM

Change 885946 abandoned by Ladsgroup:

[mediawiki/core@master] rdbms: Make LoadBalancer::getServerConnection() private

Reason:

can't be done now

https://gerrit.wikimedia.org/r/885946

gerritbot added a comment.Feb 2 2023, 12:02 PM

Change 886011 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Delegate Database object creation to DatabaseFactory out of LB

https://gerrit.wikimedia.org/r/886011

gerritbot added a comment.Feb 2 2023, 1:32 PM

Change 886045 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Drop simple only-once-used private functions

https://gerrit.wikimedia.org/r/886045

gerritbot added a comment.Feb 2 2023, 2:35 PM

Change 886054 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Introduce ServerInfoHolder to limit access to servers in LB

https://gerrit.wikimedia.org/r/886054

gerritbot added a comment.Feb 2 2023, 9:18 PM

Change 886045 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Drop simple only-once-used private functions

https://gerrit.wikimedia.org/r/886045

gerritbot added a comment.Feb 3 2023, 5:50 AM

Change 885987 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] lib: Drop use of forEachOpenPrimaryConnection in FakeLoadBalancer

https://gerrit.wikimedia.org/r/885987

gerritbot added a comment.Feb 3 2023, 5:50 AM

Change 885988 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Drop LB::forEachOpenConnection and forEachOpenPrimaryConnection

https://gerrit.wikimedia.org/r/885988

gerritbot added a comment.Feb 8 2023, 4:24 PM

Change 887801 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Introduce IConnectionProvider

https://gerrit.wikimedia.org/r/887801

Krinkle added a comment.Feb 15 2023, 5:03 PM

I noticed that LoadBalancer::getConnectionRef() is currently an array internally, and while the signature allows a single string, it is generally used in its array form. I suggest that when we move this method to LBFactory that we make it string-only. e.g. LBFactory::getConnection( $type, $domain = false, $group = null );. Or, if we embrace @Ladsgroup 's idea for a "readable" IDatabase subset, it could become LBFactory::getReadConnection( $domain = false, $group = null ); paired with ::getWriteConnection().

gerritbot added a comment.Feb 15 2023, 5:10 PM

Change 889576 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] Remove obsolete Rdbms query groups from getConnection calls

https://gerrit.wikimedia.org/r/889576

gerritbot added a comment.Feb 15 2023, 6:55 PM

Change 889576 merged by jenkins-bot:

[mediawiki/core@master] Remove obsolete Rdbms query groups from getConnection calls

https://gerrit.wikimedia.org/r/889576

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.24; 2023-02-20); removed MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 15 2023, 7:00 PM
Ladsgroup added a comment.Feb 15 2023, 11:30 PM
In T326274#8619302, @Krinkle wrote:

I noticed that LoadBalancer::getConnectionRef() is currently an array internally, and while the signature allows a single string, it is generally used in its array form. I suggest that when we move this method to LBFactory that we make it string-only. e.g. LBFactory::getConnection( $type, $domain = false, $group = null );. Or, if we embrace @Ladsgroup 's idea for a "readable" IDatabase subset, it could become LBFactory::getReadConnection( $domain = false, $group = null ); paired with ::getWriteConnection().

FWIW, it's this patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/887801 I will do the interface split ASAP.

gerritbot added a comment.Feb 20 2023, 3:20 PM

Change 890469 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/DiscussionTools@master] [POC] Switch to using IConnectionProvider

https://gerrit.wikimedia.org/r/890469

gerritbot added a comment.Feb 21 2023, 4:30 PM

Change 886054 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Introduce ServerInfoHolder to limit access to servers in LB

https://gerrit.wikimedia.org/r/886054

gerritbot added a comment.Feb 21 2023, 6:37 PM

Change 887801 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Introduce IConnectionProvider and IReadableDatabase

https://gerrit.wikimedia.org/r/887801

gerritbot added a comment.Feb 21 2023, 7:03 PM

Change 890896 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Move back general purpose ::query() from IReadableDatabase to IDatabase

https://gerrit.wikimedia.org/r/890896

gerritbot added a comment.Feb 21 2023, 8:43 PM

Change 890904 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] [WIP] rdbms: Introduce ConnectionTracker

https://gerrit.wikimedia.org/r/890904

gerritbot added a comment.Feb 21 2023, 9:07 PM

Change 890896 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Move back ::query() from IReadableDatabase to IDatabase

https://gerrit.wikimedia.org/r/890896

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.25; 2023-02-27); removed MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 21 2023, 10:00 PM
gerritbot added a comment.Feb 22 2023, 7:25 PM

Change 891356 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] [DNM] rdbms: Add $externalCluster argument to IConnectionProvider

https://gerrit.wikimedia.org/r/891356

gerritbot added a comment.Feb 22 2023, 7:40 PM

Change 891357 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Switch some simple usages of LoadBalancer to use the new methods

https://gerrit.wikimedia.org/r/891357

gerritbot added a comment.Feb 23 2023, 1:54 AM

Change 891357 merged by jenkins-bot:

[mediawiki/core@master] Switch some simple use of LoadBalancer to use new LBFactory methods

https://gerrit.wikimedia.org/r/891357

gerritbot added a comment.Feb 26 2023, 4:08 AM

Change 891356 abandoned by Ladsgroup:

[mediawiki/core@master] [DNM] rdbms: Add $externalCluster argument to IConnectionProvider

Reason:

Proposed a way to hide this from devs: T330590

https://gerrit.wikimedia.org/r/891356

gerritbot added a comment.Feb 27 2023, 6:24 PM

Change 890469 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use the new method of getting database object

https://gerrit.wikimedia.org/r/890469

Krinkle added a subtask: T330590: External LBs should not be exposed to developers.Feb 27 2023, 7:47 PM
gerritbot added a comment.Feb 28 2023, 4:06 PM

Change 892043 had a related patch set uploaded (by Krinkle; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Switch LBFactory::getReplicaDatabase to narrow IReadableDatabase

https://gerrit.wikimedia.org/r/892043

gerritbot added a comment.Feb 28 2023, 4:24 PM

Change 892043 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Switch LBFactory::getReplicaDatabase to narrow IReadableDatabase

https://gerrit.wikimedia.org/r/892043

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.26; 2023-03-06); removed MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Feb 28 2023, 5:00 PM
gerritbot added a comment.Mar 1 2023, 3:17 PM

Change 893488 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Drop LBF::$currentConfig

https://gerrit.wikimedia.org/r/893488

gerritbot added a comment.Mar 2 2023, 1:07 AM

Change 893488 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Drop LBF::$currentConfig

https://gerrit.wikimedia.org/r/893488

Krinkle added a parent task: T326187: Make LoadBalancer::getReaderIndex handle down groups better.Mar 8 2023, 1:20 AM
gerritbot added a comment.Apr 5 2023, 4:11 PM

Change 906058 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Make IConnectionProvider stable

https://gerrit.wikimedia.org/r/906058

gerritbot added a comment.Apr 7 2023, 2:02 AM

Change 906058 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Make IConnectionProvider stable

https://gerrit.wikimedia.org/r/906058

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.4; 2023-04-10).Apr 7 2023, 3:00 AM
gerritbot added a comment.Apr 12 2023, 5:57 PM

Change 886011 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Delegate Database object creation to DatabaseFactory out of LB

https://gerrit.wikimedia.org/r/886011

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.5; 2023-04-17); removed MW-1.41-notes (1.41.0-wmf.4; 2023-04-10).Apr 12 2023, 6:00 PM
gerritbot added a comment.May 25 2023, 3:29 PM

Change 923371 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/core@master] rdbms: Use more narrow IReadableDatabase in SelectQueryBuilder

https://gerrit.wikimedia.org/r/923371

gerritbot added a comment.Jun 5 2023, 5:28 PM

Change 923371 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Use more narrow IReadableDatabase in SelectQueryBuilder

https://gerrit.wikimedia.org/r/923371

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.12; 2023-06-06); removed MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Jun 5 2023, 7:00 PM
Krinkle updated the task description. (Show Details)Jun 20 2023, 4:49 PM
Ladsgroup added a parent task: T343098: [epic] Data Persistence Hypothesis WE 3.2.1.Aug 1 2023, 10:02 AM
gerritbot added a comment.Aug 1 2023, 10:03 AM

Change 943630 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Move two static methods of LBFactory to ChronologyProtector

https://gerrit.wikimedia.org/r/943630

gerritbot added a comment.Aug 1 2023, 10:03 AM

Change 943625 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Remove LB::getReplicaResumePos

https://gerrit.wikimedia.org/r/943625

gerritbot added a comment.Aug 1 2023, 10:03 AM

Change 943628 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Remove or move unused public methods of ILB/ILBF

https://gerrit.wikimedia.org/r/943628

gerritbot added a comment.Aug 1 2023, 10:52 AM

Change 943625 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Remove LB::getReplicaResumePos

https://gerrit.wikimedia.org/r/943625

gerritbot added a comment.Aug 1 2023, 10:58 AM

Change 943628 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Remove or move unused public methods of ILB/ILBF

https://gerrit.wikimedia.org/r/943628

gerritbot added a comment.Aug 1 2023, 10:59 AM

Change 943630 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Move two static methods of LBFactory to ChronologyProtector

https://gerrit.wikimedia.org/r/943630

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Aug 1 2023, 11:00 AM
gerritbot added a comment.Aug 3 2023, 10:03 PM

Change 945675 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Roll up once-used small private/protected methods to the caller

https://gerrit.wikimedia.org/r/945675

gerritbot added a comment.Aug 3 2023, 11:30 PM

Change 945675 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Roll up once-used small private/protected methods to the caller

https://gerrit.wikimedia.org/r/945675

Krinkle mentioned this in T184529: Define a way to get a database connection based on a logical wiki ID..Aug 7 2023, 1:42 AM
Krinkle removed a project: Performance-Team (Radar).
Ladsgroup closed subtask T343917: Support ReadOnlyMode without internal LoadBalancer as Resolved.Sep 13 2023, 8:53 AM
Ladsgroup closed subtask T330590: External LBs should not be exposed to developers as Resolved.Oct 16 2023, 9:44 AM
Krinkle renamed this task from Reduce complexity of LB and LBF to Reduce complexity of LB and LBF (introducing IConnectionProvider).Nov 15 2023, 5:54 PM
gerritbot added a comment.Nov 16 2023, 9:07 PM

Change 975083 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Move two methods from ILB to ILBForOwner

https://gerrit.wikimedia.org/r/975083

gerritbot added a comment.Nov 17 2023, 2:41 AM

Change 975083 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Move two methods from ILB to ILBForOwner

https://gerrit.wikimedia.org/r/975083

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 17 2023, 3:00 AM
Ladsgroup added a comment.Nov 17 2023, 1:30 PM

::hasReplicaServers() and hasStreamingReplicaServers() probably can be merged, I have a feeling that almost all calls to hasReplicaServers() was meant to actually call hasStreamingReplicaServers instead.

Ladsgroup added a comment.Nov 17 2023, 1:30 PM
In T326274#9340640, @Ladsgroup wrote:

::hasReplicaServers() and hasStreamingReplicaServers() probably can be merged, I have a feeling that almost all calls to hasReplicaServers() was meant to actually call hasStreamingReplicaServers instead.

Obviously can be another dedicated ticket and we could close this instead.

gerritbot added a comment.Nov 22 2023, 7:14 PM

Change 976841 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] tests: Remove DummyServicesTrait::getDummyDBLoadBalancer

https://gerrit.wikimedia.org/r/976841

gerritbot added a comment.Nov 23 2023, 2:50 AM

Change 976841 merged by jenkins-bot:

[mediawiki/core@master] tests: Remove DummyServicesTrait::getDummyDBLoadBalancer

https://gerrit.wikimedia.org/r/976841

Ladsgroup closed subtask T325389: Deprecate ILoadBalancer::getAnyOpenConnection() as Resolved.Nov 28 2023, 3:53 PM
Ladsgroup closed this task as Resolved.Nov 28 2023, 3:56 PM
Ladsgroup mentioned this in T352191: Merge or simplify ILoadBalancer::hasReplicaServers() and ::hasStreamingReplicaServers().
Ladsgroup moved this task from In progress to Done on the DBA board.
In T326274#9340645, @Ladsgroup wrote:
In T326274#9340640, @Ladsgroup wrote:

::hasReplicaServers() and hasStreamingReplicaServers() probably can be merged, I have a feeling that almost all calls to hasReplicaServers() was meant to actually call hasStreamingReplicaServers instead.

Obviously can be another dedicated ticket and we could close this instead.

T352191: Merge or simplify ILoadBalancer::hasReplicaServers() and ::hasStreamingReplicaServers()

Oznogon mentioned this in T359770: REL1_39 extension requires LBFactory::getReplicaDatabase, which isn't in MW 1.39.Mar 10 2024, 7:25 PM
gerritbot added a comment.Apr 17 2024, 12:48 PM

Change #1020822 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Hard-deprecate LoadBalancer::getConnectionRef()

https://gerrit.wikimedia.org/r/1020822

gerritbot added a comment.Apr 17 2024, 12:55 PM

Change #1020711 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/EntitySchema@master] Remove call to LoadBalancer::reuseConnection()

https://gerrit.wikimedia.org/r/1020711

gerritbot added a comment.Apr 17 2024, 12:55 PM

Change #1020712 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/PropertySuggester@master] Remove call to LoadBalancer::reuseConnection()

https://gerrit.wikimedia.org/r/1020712

gerritbot added a comment.Apr 17 2024, 12:55 PM

Change #1020713 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/SecurePoll@master] Remove call to LoadBalancer::reuseConnection()

https://gerrit.wikimedia.org/r/1020713

gerritbot added a comment.Apr 17 2024, 12:55 PM

Change #1020714 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/WikimediaMaintenance@master] Remove call to LoadBalancer::reuseConnection()

https://gerrit.wikimedia.org/r/1020714

gerritbot added a comment.Apr 17 2024, 3:04 PM

Change #1020714 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] Remove call to LoadBalancer::reuseConnection()

https://gerrit.wikimedia.org/r/1020714

gerritbot added a comment.Apr 17 2024, 3:04 PM

Change #1020713 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Remove call to LoadBalancer::reuseConnection()

https://gerrit.wikimedia.org/r/1020713

gerritbot added a comment.Apr 17 2024, 3:22 PM

Change #1020712 merged by jenkins-bot:

[mediawiki/extensions/PropertySuggester@master] Remove call to LoadBalancer::reuseConnection()

https://gerrit.wikimedia.org/r/1020712

gerritbot added a comment.Apr 17 2024, 3:22 PM

Change #1020711 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Remove call to LoadBalancer::reuseConnection()

https://gerrit.wikimedia.org/r/1020711

Ladsgroup mentioned this in rEPSae6598bc466d: Remove call to LoadBalancer::reuseConnection().Apr 17 2024, 3:43 PM
gerritbot added a comment.Apr 17 2024, 3:56 PM

Change #1020859 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] rdbms: Update outdated docs around deprecated reuseConnection()

https://gerrit.wikimedia.org/r/1020859

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Apr 17 2024, 4:00 PM
gerritbot added a comment.Apr 17 2024, 5:06 PM

Change #1020859 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Update outdated docs around deprecated reuseConnection()

https://gerrit.wikimedia.org/r/1020859

gerritbot added a comment.Apr 30 2024, 12:31 PM

Change #1025744 had a related patch set uploaded (by Jforrester; author: Amir Sarabadani):

[mediawiki/core@master] Stop using LoadBalancer::getConnectionRef() so it can be hard-deprecated

https://gerrit.wikimedia.org/r/1025744

gerritbot added a comment.Apr 30 2024, 2:02 PM

Change #1025744 merged by jenkins-bot:

[mediawiki/core@master] Stop using LoadBalancer::getConnectionRef() so it can be hard-deprecated

https://gerrit.wikimedia.org/r/1025744

gerritbot added a comment.Apr 30 2024, 2:02 PM

Change #1020822 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Hard-deprecate LoadBalancer::getConnectionRef()

https://gerrit.wikimedia.org/r/1020822

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.4; 2024-05-07); removed MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Apr 30 2024, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL