tests are attached to the function
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	AAlhazwani-WMF
	Jan 9 2023, 11:30 AM

Description

When publishing changes to a function, specifically when the input and/or output type are edited, a disclaimer is displayed warning editors about potential consequences of such changes. This disclaimer should be displayed only when said function has existing implementations and/or tests attached. It is not necessary in the instance of a function without implementations/tests attached.

CleanShot 2023-01-09 at 12.28.47@2x.png (1×1 px, 129 KB)

Details

	Subject	Repo	Branch	Lines +/-
	FuctionEditorFooter.vue: Hide implementations/tests disclaimer while publishing if no implementations/tests are connected	mediawiki/extensions/WikiLambda	master	+161 -4

Customize query in gerrit

Event Timeline

AAlhazwani-WMF created this task.Jan 9 2023, 11:30 AM

DVrandecic moved this task from To triage to To triage: Nice-to-haves on the Abstract Wikipedia team board.Jan 10 2023, 7:38 PM

Jdforrester-WMF triaged this task as Medium priority.May 22 2024, 4:52 PM

Jdforrester-WMF added a project: WikiLambda Front-end.

Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.

DSmit-WMF claimed this task.Jun 21 2024, 8:55 AM

DSmit-WMF changed the task status from Open to In Progress.Jun 25 2024, 4:38 PM

Change #1049896 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] FuctionEditorFooter.vue: Hide implementations/tests disclaimer while publishing if no implementations/tests are connected

https://gerrit.wikimedia.org/r/1049896

gerritbot added a project: Patch-For-Review.Jun 26 2024, 11:09 AM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (24Q4 (Apr–Jun)); removed Abstract Wikipedia team.Jun 26 2024, 11:55 AM

Jdforrester-WMF moved this task from Incoming to In Progress on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.

Change #1049896 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] FuctionEditorFooter.vue: Hide implementations/tests disclaimer while publishing if no implementations/tests are connected

https://gerrit.wikimedia.org/r/1049896

Maintenance_bot removed a project: Patch-For-Review.Jun 26 2024, 2:31 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Jun 26 2024, 3:00 PM

Jdforrester-WMF moved this task from In Progress to Ready to deploy on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Jun 26 2024, 4:10 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q1 (Jul–Sep)); removed Abstract Wikipedia team (24Q4 (Apr–Jun)).Jul 1 2024, 9:11 PM

Jdforrester-WMF moved this task from Incoming to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Jul 10 2024, 4:50 PM

Jdforrester-WMF closed this task as Resolved.Jul 18 2024, 3:07 PM