Page MenuHomePhabricator
Create Task
Maniphest T326653

PHPStan failing on Wikibase backports to wmf branches
Closed, ResolvedPublic
Actions

Description

On patch set 2 of this Wikibase backport, CI failed (console):

Fatal error: Uncaught Error: Interface 'Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface' not found in /workspace/src/includes/libs/stats/IBufferingStatsdDataFactory.php:13
Stack trace:
#0 /workspace/src/includes/AutoLoader.php(221): require()
#1 [internal function]: AutoLoader::autoload()
#2 /workspace/src/includes/libs/stats/NullStatsdDataFactory.php(10): spl_autoload_call()
#3 /workspace/src/includes/AutoLoader.php(221): require('/workspace/src/...')
#4 [internal function]: AutoLoader::autoload()
#5 /workspace/src/includes/libs/rdbms/TransactionProfiler.php(117): spl_autoload_call()
#6 /workspace/src/includes/profiler/Profiler.php(61): Wikimedia\Rdbms\TransactionProfiler->__construct()
#7 /workspace/src/includes/profiler/Profiler.php(100): Profiler->__construct()
#8 /workspace/src/tests/phpunit/bootstrap.php(99): Profiler::init()
#9 phar:///workspace/src/extensions/Wikibase/vendor/phpstan/phpstan/phpstan.phar/src/Command/CommandHelper.php(133): require_once('/workspace/src/...')
#10 phar:///workspace/src/extensi in /workspace/src/includes/libs/stats/IBufferingStatsdDataFactory.php on line 13
PHP Fatal error:  Uncaught Error: Interface 'Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface' not found in /workspace/src/includes/libs/stats/IBufferingStatsdDataFactory.php:13
Stack trace:
#0 /workspace/src/includes/AutoLoader.php(221): require()
#1 [internal function]: AutoLoader::autoload()
#2 /workspace/src/includes/libs/stats/NullStatsdDataFactory.php(10): spl_autoload_call()
#3 /workspace/src/includes/AutoLoader.php(221): require('/workspace/src/...')
#4 [internal function]: AutoLoader::autoload()
#5 /workspace/src/includes/libs/rdbms/TransactionProfiler.php(117): spl_autoload_call()
#6 /workspace/src/includes/profiler/Profiler.php(61): Wikimedia\Rdbms\TransactionProfiler->__construct()
#7 /workspace/src/includes/profiler/Profiler.php(100): Profiler->__construct()
#8 /workspace/src/tests/phpunit/bootstrap.php(99): Profiler::init()
#9 phar:///workspace/src/extensions/Wikibase/vendor/phpstan/phpstan/phpstan.phar/src/Command/CommandHelper.php(133): require_once('/workspace/src/...')
#10 phar:///workspace/src/extensi in /workspace/src/includes/libs/stats/IBufferingStatsdDataFactory.php on line 13
Script phpstan analyze -a ../../tests/phpunit/bootstrap.php handling the phpstan event returned with error code 255
Script composer phpstan handling the test event returned with error code 255

We need to figure out why it’s failing and what we can do about it.

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jan 10 2023, 4:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2023, 4:32 PM
Lucas_Werkmeister_WMDE added a parent task: T324093: Enforce dependency rules with PHPat.Jan 10 2023, 4:32 PM
Lucas_Werkmeister_WMDE added a comment.EditedJan 10 2023, 4:39 PM

Apparently the CI job runs Wikibase’s composer test before installing MediaWiki core’s dependencies? (Screenshot taken from patch set 3 of the same change, where I removed the composer phpstan command to temporarily avoid the error.)

image.png (183×330 px, 23 KB)

And Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface is just the first type that happens to be missing.

And the reason this only fails on backports seems to be that… this is a quibble-composer-* job, which just… doesn’t run on main test builds on master? The main test pipeline has quibble-vendor-* and wmf-quibble-vendor-* and mediawiki-quibble-apitests-composer-*, but no other *-composer-* jobs – those are only in test-wmf and other pipelines?

Jdforrester-WMF subscribed.Jan 10 2023, 4:41 PM
In T326653#8513209, @Lucas_Werkmeister_WMDE wrote:

Apparently the CI job runs Wikibase’s composer test before installing MediaWiki core’s dependencies?

image.png (183×330 px, 23 KB)

And Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface is just the first type that happens to be missing.

And the difference seems to be that… this is a quibble-composer-* job, which just… doesn’t run on main test builds on master? The main test pipeline has quibble-vendor-* and wmf-quibble-vendor-* and mediawiki-quibble-apitests-composer-*, but no other *-composer-* jobs – those are only in test-wmf and other pipelines?

quibble-composer jobs are for release branches (and other circumstances where you're not aimed at Wikimedia production); they shouldn't ever be live on development or wmf/ branches.

Jakob_WMDE subscribed.Jan 10 2023, 4:42 PM
Lucas_Werkmeister_WMDE added a comment.Jan 10 2023, 4:46 PM
In T326653#8513221, @Jdforrester-WMF wrote:

quibble-composer jobs are for release branches (and other circumstances where you're not aimed at Wikimedia production); they shouldn't ever be live on development or wmf/ branches.

They seem to be in test-wmf and gate-and-submit-wmf at the moment if I’m reading the zuul/layout.yaml correctly: https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/53c171c0f8ff6333a22f7aefc54ab2acc4e50b3e/zuul/layout.yaml#1386 (part of the extension-quibble template)

gerritbot added a comment.Jan 10 2023, 4:46 PM

Change 878132 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Fix extension-quibble to run vendor not composer quibble on wmf

https://gerrit.wikimedia.org/r/878132

gerritbot added a project: Patch-For-Review.Jan 10 2023, 4:46 PM
Jdforrester-WMF added a comment.Jan 10 2023, 4:46 PM

Yeah, I accidentally broke this as part of the PHP 7.2 decommissioning with a copy-paste mistake. Odd that it's only happened now.

Lucas_Werkmeister_WMDE added a comment.Jan 10 2023, 4:47 PM

Aha, that sounds good, thank you :)

gerritbot added a comment.Jan 10 2023, 4:49 PM

Change 878132 merged by jenkins-bot:

[integration/config@master] Zuul: Fix extension-quibble to run vendor not composer quibble on wmf

https://gerrit.wikimedia.org/r/878132

Stashbot added a comment.Jan 10 2023, 4:50 PM

Mentioned in SAL (#wikimedia-releng) [2023-01-10T16:50:02Z] <James_F> Zuul: Fix extension-quibble to run vendor not composer quibble on wmf for T326653

Jdforrester-WMF added a comment.Jan 10 2023, 4:50 PM
In T326653#8513243, @Lucas_Werkmeister_WMDE wrote:

Aha, that sounds good, thank you :)

Sorry about this. Should be fixed now.

Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 10 2023, 5:12 PM
Lucas_Werkmeister_WMDE assigned this task to Jdforrester-WMF.

Yup, the test build is green now. Thanks for the fix!

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2023, 5:29 PM
Lucas_Werkmeister_WMDE mentioned this in T333454: PHPStan failing on Wikibase backports to REL1_40.Mar 29 2023, 2:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL