Change 880519 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] If no supported gateway, show donate wiki instead of error page

https://gerrit.wikimedia.org/r/880519

E.g.:
For country that we are not accept paypal, like AF. we still see the paypal option from donate wiki page, probably needs change there instead of redirect again to donate wiki.
so needs to edit the src/payments/extensions/DonationInterface/paypal_ec_gateway/config/payment_methods.yaml to filter out some countries
https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=AF&uselang=en&utm_medium=donatewiki_page&utm_source=Ways_to_Give&utm_campaign=donate_now_btn

@Pcoombe
Hi, peter, for this ticket, since it's related with the DonationForm.js (https://donate.wikimedia.org/w/index.php?title=MediaWiki:DonationForm.js) , it needs some help from you
1: Seems like we are not able to detect the currency from the param for our donate wiki, which I think is due to our that we use the default currency from country instead of check our param value, like the link https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=JP&uselang=en&currency=NOK, we will not use the nok but the default currency for the given country.

2: for the donate wiki we have extra paypal, looks like we also want to have a similar method for shouldShowApplePay for paypal to avoid the error like this link
https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=AF&uselang=en&utm_medium=donatewiki_page&utm_source=Ways_to_Give&utm_campaign=donate_now_btn

Thanks :)

Hi @AnnWF

1: That's correct, donatewiki doesn't accept a currency parameter, it just uses one currency per country. It would be very difficult to add currency changing this way, and I'm not sure I understand the use case here?

2: Sure, if you give me a complete list of countries where we can accept PayPal (ideally as ISO codes) then I can go through and remove the ones which shouldn't have it. I know there are also some countries where we accept PayPal, but only in USD not the local currency.

Hi @Pcoombe

1: ok, if this is expected behavior, then no worry, will keep this in mind then
2: here is the country list that accept paypal at this moment, thanks so much!
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/DonationInterface/+/refs/heads/master/paypal_ec_gateway/config/countries.yaml
also then if the local currency is only accepted for donate wiki, then if those countries only accept USD for paypal, we should exclude paypal from those country list right?
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/DonationInterface/+/refs/heads/master/paypal_ec_gateway/config/currencies.yaml so based on the supported currencies, if we have the default currency not qualified, then we should ignore it: https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/SmashPig/+/refs/heads/master/PaymentData/ReferenceData/NationalCurrencies.php#24

Here is excel sheet to filter the final country list https://docs.google.com/spreadsheets/d/1CQquX0gkST4gvr-sG224tVaCySHCZchQ/edit?usp=sharing&ouid=109990517551911357524&rtpof=true&sd=true based on above reference configs:
so final country list are:
AD
AS
AT
AU
BE
BQ
CA
CH
CK
CY
CZ
DE
DK
EC
EE
ES
FI
FM
FO
FR
GB
GF
GG
GL
GP
GR
GU
HK
HR
HU
IE
IL
IM
IT
JE
JP
KI
LI
LT
LU
LV
MC
ME
MF
MH
MQ
MT
MX
NF
NL
NO
NR
NU
NZ
PH
PL
PM
PN
PR
PT
PW
RE
SE
SI
SJ
SK
SM
SV
TC
TH
TV
TW
US
VA
VG
VI
YT

@Pcoombe Hi peter, let me know when could I test, thanks so much!

@AnnWF Okay, think I've got this sorted and removed all the unsupported ones. We do have a special "PayPal USD" template for donatewiki, for use in countries where the local currency is different, but PayPal only accepts USD, so I've used that where appropriate.

Sounds good, and I just use some random link which could lead to PayPal error now not shown from donate wiki, thanks!

@Pcoombe as discussed during today's meeting, we can use UZS for country UZ, and potentially check other countries that use RUB as default? Thanks a lot! :)

Thanks @AnnWF, I updated Uzbekistan to use UZS https://donate.wikimedia.org/?country=UZ

Also found Turkmenistan was using RUB and giving an error, updated it to the local currency TMT and it works now https://donate.wikimedia.org/?country=TM

In T326666#8599465, @Pcoombe wrote:

Thanks @AnnWF, I updated Uzbekistan to use UZS https://donate.wikimedia.org/?country=UZ

Also found Turkmenistan was using RUB and giving an error, updated it to the local currency TMT and it works now https://donate.wikimedia.org/?country=TM

Awesome, tested they both works great, thanks so much! Really appreciate it :)

Change 880519 abandoned by Wfan:

[mediawiki/extensions/DonationInterface@master] If no supported gateway, show donate wiki instead of error page

Reason:

should update the ways to give page not redirect here, abandon it

https://gerrit.wikimedia.org/r/880519

@Pcoombe Based on the setting, we do not support any payment method for Afghanistan, here is the example https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=AF (from code only Braintree Paypal support this country while we are not use Braintree Paypal at this moment), should we take it out from ways to give page? https://donate.wikimedia.org/wiki/Ways_to_Give thanks :)

Thanks @AnnWF, I removed Afghanistan from Ways to Give (diff)

In T326666#8605028, @Pcoombe wrote:

Thanks @AnnWF, I removed Afghanistan from Ways to Give (diff)

Hi @Pcoombe, looks good! Just saw couple error message, seems like we still needs to remove paypal from GH, HT thanks!

Okay, done those @AnnWF

Hi @Pcoombe,

Thanks so much for your help, and sorry that we have more from the error log haha,

1: we still see some error from AF cc, if you see IQ:
https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=IQ,
"we have a page as we are not fundraising at your country"
could we do the same for this AF?
https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=AF

2: below links are more link that are not supported for PayPal:
https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=AX

Thanks a lot!!!!!

Thanks @AnnWF. I switched both to the non-fundraising page. Honestly I was a bit surprised AF wasn't already, and AX is a region of Finland where we also don't fundraise.

@Pcoombe XK (Kosovo) is still creating this error with Paypal. I looked into it and none of our payment processors support it. We don't have Kosovo on ways to give but people are getting there with country=XK. Could you switch XK one to the non-fundraising page too ?

Okay, done: https://donate.wikimedia.org/?country=XK

Thanks so much @Pcoombe !

Hi Peter, @Pcoombe we have a similar error log for ET cc, seems like we are not enable ET in cc, https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=ET, thanks :)

Okay removed https://donate.wikimedia.org/w/index.php?title=Template:2012FR/Form-countryspecific-control/ET&diff=prev&oldid=40768. Thanks!

Thanks a lot!

In T326666#10416601, @Pcoombe wrote:

Okay removed https://donate.wikimedia.org/w/index.php?title=Template:2012FR/Form-countryspecific-control/ET&diff=prev&oldid=40768. Thanks!